linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: move the (z/u)install rules to arch/arm/Makefile
@ 2021-07-29 14:03 Masahiro Yamada
  2021-07-30  5:18 ` Uwe Kleine-König
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-07-29 14:03 UTC (permalink / raw)
  To: patches
  Cc: Masahiro Yamada, Arnd Bergmann, Kees Cook, Krzysztof Kozlowski,
	Uwe Kleine-König, linux-kernel, Nathan Chancellor,
	Viresh Kumar, Russell King, linux-arm-kernel

Currently, the (z/u)install targets in arch/arm/Makefile descend into
arch/arm/boot/Makefile to invoke the shell script, but there is no
good reason to do so.

arch/arm/Makefile can run the shell script directly.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

KernelVersion: v5.14-rc1

 arch/arm/Makefile      |  3 ++-
 arch/arm/boot/Makefile | 14 +-------------
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 173da685a52e..847c31e7c368 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -308,7 +308,8 @@ $(BOOT_TARGETS): vmlinux
 	@$(kecho) '  Kernel: $(boot)/$@ is ready'
 
 $(INSTALL_TARGETS):
-	$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@
+	$(CONFIG_SHELL) $(srctree)/$(boot)/install.sh "$(KERNELRELEASE)" \
+	$(boot)/$(patsubst %install,%Image,$@) System.map "$(INSTALL_PATH)"
 
 PHONY += vdso_install
 vdso_install:
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
index 0b3cd7a33a26..54a09f9464fb 100644
--- a/arch/arm/boot/Makefile
+++ b/arch/arm/boot/Makefile
@@ -96,23 +96,11 @@ $(obj)/bootp/bootp: $(obj)/zImage initrd FORCE
 $(obj)/bootpImage: $(obj)/bootp/bootp FORCE
 	$(call if_changed,objcopy)
 
-PHONY += initrd install zinstall uinstall
+PHONY += initrd
 initrd:
 	@test "$(INITRD_PHYS)" != "" || \
 	(echo This machine does not support INITRD; exit -1)
 	@test "$(INITRD)" != "" || \
 	(echo You must specify INITRD; exit -1)
 
-install:
-	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" \
-	$(obj)/Image System.map "$(INSTALL_PATH)"
-
-zinstall:
-	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" \
-	$(obj)/zImage System.map "$(INSTALL_PATH)"
-
-uinstall:
-	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" \
-	$(obj)/uImage System.map "$(INSTALL_PATH)"
-
 subdir-	    := bootp compressed dts
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: move the (z/u)install rules to arch/arm/Makefile
  2021-07-29 14:03 [PATCH] ARM: move the (z/u)install rules to arch/arm/Makefile Masahiro Yamada
@ 2021-07-30  5:18 ` Uwe Kleine-König
  0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2021-07-30  5:18 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: patches, Arnd Bergmann, Kees Cook, Krzysztof Kozlowski,
	linux-kernel, Nathan Chancellor, Viresh Kumar, Russell King,
	linux-arm-kernel, kernel

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Thu, Jul 29, 2021 at 11:03:51PM +0900, Masahiro Yamada wrote:
> Currently, the (z/u)install targets in arch/arm/Makefile descend into
> arch/arm/boot/Makefile to invoke the shell script, but there is no
> good reason to do so.
> 
> arch/arm/Makefile can run the shell script directly.

I didn't test, but I think this works in general. There shouldn't be a
principal problem as e.g. mips also doesn't have install in
arch/$(ARCH)/boot/Makefile.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-30  5:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 14:03 [PATCH] ARM: move the (z/u)install rules to arch/arm/Makefile Masahiro Yamada
2021-07-30  5:18 ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).