linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-nfc@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] nfc: hci: pass callback data param as pointer in nci_request()
Date: Fri, 30 Jul 2021 06:49:22 -0700	[thread overview]
Message-ID: <20210730064922.078bd222@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210730065625.34010-8-krzysztof.kozlowski@canonical.com>

On Fri, 30 Jul 2021 08:56:24 +0200 Krzysztof Kozlowski wrote:
> The nci_request() receives a callback function and unsigned long data
> argument "opt" which is passed to the callback.  Almost all of the
> nci_request() callers pass pointer to a stack variable as data argument.
> Only few pass scalar value (e.g. u8).
> 
> All such callbacks do not modify passed data argument and in previous
> commit they were made as const.  However passing pointers via unsigned
> long removes the const annotation.  The callback could simply cast
> unsigned long to a pointer to writeable memory.
> 
> Use "const void *" as type of this "opt" argument to solve this and
> prevent modifying the pointed contents.  This is also consistent with
> generic pattern of passing data arguments - via "void *".  In few places
> passing scalar values, use casts via "unsigned long" to suppress any
> warnings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

This generates a bunch of warnings:

net/nfc/nci/core.c:381:51: warning: Using plain integer as NULL pointer
net/nfc/nci/core.c:388:50: warning: Using plain integer as NULL pointer
net/nfc/nci/core.c:494:57: warning: Using plain integer as NULL pointer
net/nfc/nci/core.c:520:65: warning: Using plain integer as NULL pointer
net/nfc/nci/core.c:570:44: warning: Using plain integer as NULL pointer
net/nfc/nci/core.c:815:34: warning: Using plain integer as NULL pointer
net/nfc/nci/core.c:856:50: warning: Using plain integer as NULL pointer

BTW applying this set will resolve the warnings introduced by applying
"part 2" out of order, right? No further action needed?

  reply	other threads:[~2021-07-30 13:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30  6:56 [PATCH v2 0/8] nfc: constify pointed data - missed part Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 1/8] nfc: mrvl: correct nfcmrvl_spi_parse_dt() device_node argument Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 2/8] nfc: annotate af_nfc_exit() as __exit Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 3/8] nfc: hci: annotate nfc_llc_init() as __init Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 4/8] nfc: constify several pointers to u8, char and sk_buff Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 5/8] nfc: constify local pointer variables Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 6/8] nfc: nci: constify several pointers to u8, sk_buff and other structs Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 7/8] nfc: hci: pass callback data param as pointer in nci_request() Krzysztof Kozlowski
2021-07-30 13:49   ` Jakub Kicinski [this message]
2021-07-30 13:56     ` Krzysztof Kozlowski
2021-07-30 13:58       ` Jakub Kicinski
2021-07-30 14:03         ` Krzysztof Kozlowski
2021-07-30  6:56 ` [PATCH v2 8/8] nfc: hci: cleanup unneeded spaces Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730064922.078bd222@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfc@lists.01.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).