From: "Clément Léger" <clement.leger@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>, Sudeep Holla <sudeep.holla@arm.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH 3/3] dt-bindings: mfd: add "syscon-smc" YAML description
Date: Fri, 30 Jul 2021 09:21:13 +0200 [thread overview]
Message-ID: <20210730092113.25ce7f7c@fixe.home> (raw)
In-Reply-To: <YQMbV3elkU0yp92D@robh.at.kernel.org>
Le Thu, 29 Jul 2021 15:19:19 -0600,
Rob Herring <robh@kernel.org> a écrit :
> On Fri, Jul 23, 2021 at 03:52:39PM +0200, Clément Léger wrote:
> > This patch adds documentation for the "syscon-smc" compatible which
> > describes a syscon using a SMC regmap instead of a MMIO one. This
> > allows accessing system controllers that are set as secure by using
> > SMC handled by the secure monitor.
> >
> > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> > ---
> > .../devicetree/bindings/mfd/syscon-smc.yaml | 57
> > +++++++++++++++++++ 1 file changed, 57 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mfd/syscon-smc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon-smc.yaml
> > b/Documentation/devicetree/bindings/mfd/syscon-smc.yaml new file
> > mode 100644 index 000000000000..6ce1392c5e7f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/syscon-smc.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/syscon-smc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: System Controller Registers R/W via SMC Device Tree Bindings
> > +
> > +description: |
> > + System controller SMC node represents a register region
> > containing a set
> > + of miscellaneous registers accessed through a secure monitor.
> > + The typical use-case is the same as the syscon one but when
> > running with a
> > + secure monitor.
> > +
> > +maintainers:
> > + - Lee Jones <lee.jones@linaro.org>
> > +
> > +properties:
> > + compatible:
> > + anyOf:
> > + - items:
> > + - enum:
> > + - atmel,sama5d2-sfr
> > +
> > + - const: syscon-smc
>
> I regret having 'syscon' as a compatible, so nak on a 2nd flavor of
> it. It's only purpose is a hint to Linux to automagically create a
> regmap for you.
Indeed.
>
> All you need is the specific compatible, atmel,sama5d2-sfr, and you
> can imply the rest of this from it. That's assuming the conclusion is
> a register read/write interface on SMC is a good idea, but I don't
> think it is.
Ok noted, I'll try to find something else to implement that.
Clément
>
> Rob
prev parent reply other threads:[~2021-07-30 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 13:52 [PATCH 0/3] add SMC based regmap driver for secure syscon access Clément Léger
2021-07-23 13:52 ` [PATCH 1/3] regmap: add regmap using ARM SMCCC Clément Léger
2021-07-23 14:43 ` Mark Brown
2021-07-23 15:53 ` Clément Léger
2021-07-23 16:37 ` Mark Brown
2021-07-23 13:52 ` [PATCH 2/3] syscon: add support for "syscon-smc" compatible Clément Léger
2021-07-23 15:27 ` Lee Jones
2021-07-23 15:56 ` Clément Léger
2021-07-23 16:07 ` Arnd Bergmann
2021-07-23 16:41 ` Mark Brown
2021-07-24 12:36 ` Peng Fan (OSS)
2021-07-24 7:00 ` kernel test robot
2021-07-23 13:52 ` [PATCH 3/3] dt-bindings: mfd: add "syscon-smc" YAML description Clément Léger
2021-07-29 21:19 ` Rob Herring
2021-07-30 7:21 ` Clément Léger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730092113.25ce7f7c@fixe.home \
--to=clement.leger@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).