From: Daniel Thompson <daniel.thompson@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: kgdb-bugreport@lists.sourceforge.net, jason.wessel@windriver.com,
dianders@chromium.org, rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] kdb code refactoring
Date: Fri, 30 Jul 2021 11:06:51 +0100 [thread overview]
Message-ID: <20210730100651.of7dd7jzjmzpzfcx@maple.lan> (raw)
In-Reply-To: <20210712134620.276667-1-sumit.garg@linaro.org>
On Mon, Jul 12, 2021 at 07:16:16PM +0530, Sumit Garg wrote:
> Some more kdb code refactoring related to:
> - Removal of redundant kdb_register_flags().
> - Simplification of kdb defcmd macro logic.
>
> Tested with kgdbtest on arm64, doesn't show any regressions.
>
> Changes in v5:
> - Incorporated minor comments from Doug.
> - Added Doug's review tag.
>
> Changes in v4:
> - Split rename of "defcmd_set" to "kdb_macro" as a separate patch.
> - Incorporated misc. comments from Doug.
> - Added a patch that removes redundant prefix "cmd_" from name of
> members of struct kdbtab_t.
>
> Changes in v3:
> - Split patch into 2 for ease of review.
> - Get rid of kdb_register_flags() completely via switching all user to
> register pre-allocated kdb commands.
>
> Changes in v2:
> - Define new structs: kdb_macro_t and kdb_macro_cmd_t instead of
> modifying existing kdb command struct and struct kdb_subcmd.
> - Reword commit message.
>
> Sumit Garg (4):
> kdb: Rename struct defcmd_set to struct kdb_macro
> kdb: Get rid of redundant kdb_register_flags()
> kdb: Simplify kdb_defcmd macro logic
> kdb: Rename members of struct kdbtab_t
Series applied, thanks!
>
> include/linux/kdb.h | 27 +-
> kernel/debug/kdb/kdb_bp.c | 72 ++--
> kernel/debug/kdb/kdb_main.c | 626 +++++++++++++++------------------
> kernel/debug/kdb/kdb_private.h | 13 -
> kernel/trace/trace_kdb.c | 12 +-
> samples/kdb/kdb_hello.c | 20 +-
> 6 files changed, 357 insertions(+), 413 deletions(-)
>
> --
> 2.25.1
prev parent reply other threads:[~2021-07-30 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 13:46 [PATCH v5 0/4] kdb code refactoring Sumit Garg
2021-07-12 13:46 ` [PATCH v5 1/4] kdb: Rename struct defcmd_set to struct kdb_macro Sumit Garg
2021-07-12 13:46 ` [PATCH v5 2/4] kdb: Get rid of redundant kdb_register_flags() Sumit Garg
2021-07-12 13:46 ` [PATCH v5 3/4] kdb: Simplify kdb_defcmd macro logic Sumit Garg
2021-07-12 13:46 ` [PATCH v5 4/4] kdb: Rename members of struct kdbtab_t Sumit Garg
2021-07-30 10:06 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730100651.of7dd7jzjmzpzfcx@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).