linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: use __func__ to get function name in pr_err
@ 2021-07-26 12:29 Jason Wang
  2021-07-30 12:24 ` Will Deacon
  2021-07-30 18:00 ` Catalin Marinas
  0 siblings, 2 replies; 3+ messages in thread
From: Jason Wang @ 2021-07-26 12:29 UTC (permalink / raw)
  To: catalin.marinas
  Cc: will, jthierry, amit.kachhap, dave.martin, mark.rutland, tabba,
	linux-arm-kernel, linux-kernel, Jason Wang

Prefer using '"%s...", __func__' to get current function's name in
a debug message.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 arch/arm64/lib/insn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/lib/insn.c b/arch/arm64/lib/insn.c
index b506a4b1e38c..fccfe363e567 100644
--- a/arch/arm64/lib/insn.c
+++ b/arch/arm64/lib/insn.c
@@ -185,7 +185,7 @@ u64 aarch64_insn_decode_immediate(enum aarch64_insn_imm_type type, u32 insn)
 		break;
 	default:
 		if (aarch64_get_imm_shift_mask(type, &mask, &shift) < 0) {
-			pr_err("aarch64_insn_decode_immediate: unknown immediate encoding %d\n",
+			pr_err("%s: unknown immediate encoding %d\n", __func__,
 			       type);
 			return 0;
 		}
@@ -215,7 +215,7 @@ u32 __kprobes aarch64_insn_encode_immediate(enum aarch64_insn_imm_type type,
 		break;
 	default:
 		if (aarch64_get_imm_shift_mask(type, &mask, &shift) < 0) {
-			pr_err("aarch64_insn_encode_immediate: unknown immediate encoding %d\n",
+			pr_err("%s: unknown immediate encoding %d\n", __func__,
 			       type);
 			return AARCH64_BREAK_FAULT;
 		}
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: use __func__ to get function name in pr_err
  2021-07-26 12:29 [PATCH] arm64: use __func__ to get function name in pr_err Jason Wang
@ 2021-07-30 12:24 ` Will Deacon
  2021-07-30 18:00 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2021-07-30 12:24 UTC (permalink / raw)
  To: Jason Wang
  Cc: catalin.marinas, jthierry, amit.kachhap, dave.martin,
	mark.rutland, tabba, linux-arm-kernel, linux-kernel

On Mon, Jul 26, 2021 at 08:29:07PM +0800, Jason Wang wrote:
> Prefer using '"%s...", __func__' to get current function's name in
> a debug message.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  arch/arm64/lib/insn.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

Will

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: use __func__ to get function name in pr_err
  2021-07-26 12:29 [PATCH] arm64: use __func__ to get function name in pr_err Jason Wang
  2021-07-30 12:24 ` Will Deacon
@ 2021-07-30 18:00 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2021-07-30 18:00 UTC (permalink / raw)
  To: Jason Wang
  Cc: Will Deacon, linux-arm-kernel, amit.kachhap, linux-kernel,
	jthierry, tabba, dave.martin, mark.rutland

On Mon, 26 Jul 2021 20:29:07 +0800, Jason Wang wrote:
> Prefer using '"%s...", __func__' to get current function's name in
> a debug message.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: use __func__ to get function name in pr_err
      https://git.kernel.org/arm64/c/2806556c5e1a

-- 
Catalin


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-30 18:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 12:29 [PATCH] arm64: use __func__ to get function name in pr_err Jason Wang
2021-07-30 12:24 ` Will Deacon
2021-07-30 18:00 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).