linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Hui Liu <hui.liu@mediatek.com>
Cc: <robh+dt@kernel.org>, <jic23@kernel.org>, <lars@metafoo.de>,
	<pmeerw@pmeerw.net>, <srv_heupstream@mediatek.com>,
	<zhiyong.tao@mediatek.com>, <chun-hung.wu@mediatek.com>,
	<yingjoe.chen@mediatek.com>, <seiya.wang@mediatek.com>,
	<matthias.bgg@gmail.com>, <s.hauer@pengutronix.de>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-iio@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v1] iio: mtk-auxadc: add mutex_destroy
Date: Fri, 30 Jul 2021 14:44:39 +0100	[thread overview]
Message-ID: <20210730144439.00005e26@Huawei.com> (raw)
In-Reply-To: <20210729080135.17436-2-hui.liu@mediatek.com>

On Thu, 29 Jul 2021 16:01:35 +0800
Hui Liu <hui.liu@mediatek.com> wrote:

> Add mutex_destroy when probe fail and remove device.
> 
> Signed-off-by: Hui Liu <hui.liu@mediatek.com>

Hi Hui Liu,

Two things here.

1) You need to explain with a clear example flow when this would serve a
   useful purpose.  As I explained before, we do no in general put mutex_destroy()
   in remove paths as it is usually just noise.

2) It's in the wrong order logically. mutex init is between the clk_prepare_enable
   and iio_device_register, hence if we are going to have mutex destroy it must also
   be in that that location (remove should be reverse of probe or there should be
   a clear comment explaining why we need to do things in a different order.

3) If touching this code at all, please move all of the probe / remove to devm_
   managed code so that we don't need to get this ordering right at all because
   it will be done automatically.

So I won't apply this without 1 and even if I accepted the principle, it's
still in the wrong place in remove.

Jonathan

> ---
>  drivers/iio/adc/mt6577_auxadc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index 79c1dd68b909..d57243037ad6 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -289,6 +289,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
>  	ret = iio_device_register(indio_dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "failed to register iio device\n");
> +		mutex_destroy(&adc_dev->lock);
>  		goto err_power_off;
>  	}
>  
> @@ -313,6 +314,7 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
>  			      0, MT6577_AUXADC_PDN_EN);
>  
>  	clk_disable_unprepare(adc_dev->adc_clk);
> +	mutex_destroy(&adc_dev->lock);
>  
>  	return 0;
>  }


      reply	other threads:[~2021-07-30 13:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  8:01 [PATCH v1 0/1] AUXADC: Mediatek auxadc driver Hui Liu
2021-07-29  8:01 ` [PATCH v1] iio: mtk-auxadc: add mutex_destroy Hui Liu
2021-07-30 13:44   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730144439.00005e26@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hui.liu@mediatek.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=seiya.wang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    --cc=zhiyong.tao@mediatek.com \
    --subject='Re: [PATCH v1] iio: mtk-auxadc: add mutex_destroy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).