From: Steven Rostedt <rostedt@goodmis.org>
To: Kamal Agrawal <kamaagra@codeaurora.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
mhiramat@kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] tracing: Fix NULL pointer dereference in start_creating
Date: Fri, 30 Jul 2021 18:41:18 -0400 [thread overview]
Message-ID: <20210730184118.0ea8ef20@oasis.local.home> (raw)
In-Reply-To: <1627651386-21315-1-git-send-email-kamaagra@codeaurora.org>
On Fri, 30 Jul 2021 18:53:06 +0530
Kamal Agrawal <kamaagra@codeaurora.org> wrote:
> The event_trace_add_tracer() can fail. In this case, it leads to a crash
> in start_creating with below call stack. Handle the error scenario
> properly in trace_array_create_dir.
>
> Call trace:
> down_write+0x7c/0x204
> start_creating.25017+0x6c/0x194
> tracefs_create_file+0xc4/0x2b4
> init_tracer_tracefs+0x5c/0x940
> trace_array_create_dir+0x58/0xb4
> trace_array_create+0x1bc/0x2b8
> trace_array_get_by_name+0xdc/0x18c
>
> Fixes: 4114fbfd
Thanks, I'll queue this up.
-- Steve
> Signed-off-by: Kamal Agrawal <kamaagra@codeaurora.org>
> ---
> kernel/trace/trace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index c59dd35..33899a7 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -9135,8 +9135,10 @@ static int trace_array_create_dir(struct trace_array *tr)
> return -EINVAL;
>
> ret = event_trace_add_tracer(tr->dir, tr);
> - if (ret)
> + if (ret) {
> tracefs_remove(tr->dir);
> + return ret;
> + }
>
> init_tracer_tracefs(tr, tr->dir);
> __update_tracer_options(tr);
prev parent reply other threads:[~2021-07-30 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 13:23 [PATCH] tracing: Fix NULL pointer dereference in start_creating Kamal Agrawal
2021-07-30 22:41 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730184118.0ea8ef20@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=kamaagra@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).