From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1F4C432BE for ; Sat, 31 Jul 2021 12:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFA5B60FE7 for ; Sat, 31 Jul 2021 12:10:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233039AbhGaMKY (ORCPT ); Sat, 31 Jul 2021 08:10:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232902AbhGaMKV (ORCPT ); Sat, 31 Jul 2021 08:10:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB278C06175F for ; Sat, 31 Jul 2021 05:10:14 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9nnU-0007Ot-05; Sat, 31 Jul 2021 14:08:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m9nnD-0007eB-Mm; Sat, 31 Jul 2021 14:08:39 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m9nnD-0001LE-Jt; Sat, 31 Jul 2021 14:08:39 +0200 Date: Sat, 31 Jul 2021 14:08:36 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Boris Ostrovsky Cc: Bjorn Helgaas , Mark Rutland , Giovanni Cabiddu , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Peter Zijlstra , linux-pci@vger.kernel.org, Alexander Duyck , Russell Currey , Sathya Prakash , oss-drivers@corigine.com, Oliver O'Halloran , "H. Peter Anvin" , Jiri Olsa , linux-perf-users@vger.kernel.org, Stefano Stabellini , Herbert Xu , linux-scsi@vger.kernel.org, Michael Ellerman , Ido Schimmel , x86@kernel.org, qat-linux@intel.com, Alexander Shishkin , Ingo Molnar , Geert Uytterhoeven , Benjamin Herrenschmidt , linux-wireless@vger.kernel.org, Jakub Kicinski , Mathias Nyman , Yisen Zhuang , Fiona Trahe , Andrew Donnellan , Arnd Bergmann , Konrad Rzeszutek Wilk , Suganath Prabu Subramani , Simon Horman , Arnaldo Carvalho de Melo , Borislav Petkov , Michael Buesch , Jiri Pirko , Namhyung Kim , Thomas Gleixner , Andy Shevchenko , Juergen Gross , Salil Mehta , Sreekanth Reddy , xen-devel@lists.xenproject.org, Vadym Kochan , MPT-FusionLinux.pdl@broadcom.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, Wojciech Ziemba , linux-kernel@vger.kernel.org, Taras Chornyi , Zhou Wang , linux-crypto@vger.kernel.org, kernel@pengutronix.de, netdev@vger.kernel.org, Frederic Barrat , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Subject: Re: [PATCH v1 4/5] PCI: Adapt all code locations to not use struct pci_dev::driver directly Message-ID: <20210731120836.vegno6voijvlflws@pengutronix.de> References: <20210729203740.1377045-1-u.kleine-koenig@pengutronix.de> <20210729203740.1377045-5-u.kleine-koenig@pengutronix.de> <2b5e8cb5-fac2-5da2-f87b-d287d2c5ea81@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rawlqk3jhoxts24y" Content-Disposition: inline In-Reply-To: <2b5e8cb5-fac2-5da2-f87b-d287d2c5ea81@oracle.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rawlqk3jhoxts24y Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Boris, On Fri, Jul 30, 2021 at 04:37:31PM -0400, Boris Ostrovsky wrote: > On 7/29/21 4:37 PM, Uwe Kleine-K=F6nig wrote: > > --- a/drivers/pci/xen-pcifront.c > > +++ b/drivers/pci/xen-pcifront.c > > @@ -599,12 +599,12 @@ static pci_ers_result_t pcifront_common_process(i= nt cmd, > > result =3D PCI_ERS_RESULT_NONE; > > =20 > > pcidev =3D pci_get_domain_bus_and_slot(domain, bus, devfn); > > - if (!pcidev || !pcidev->driver) { > > + pdrv =3D pci_driver_of_dev(pcidev); > > + if (!pcidev || !pdrv) { >=20 > If pcidev is NULL we are dead by the time we reach 'if' statement. Oh, you're right. So this needs something like: if (!pcidev || !(pdrv =3D pci_driver_of_dev(pcidev))) or repeating the call to pci_driver_of_dev for each previous usage of pdev->driver. If there are no other preferences I'd got with the first approach for v2. Best regards and thanks for catching, Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --rawlqk3jhoxts24y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmEFPUEACgkQwfwUeK3K 7AlQoAgAidQUuX/L2YhXMvP0F+SSjym4ILhKdbRYnWojo/QbFUE8WbOQueAZA76q NW0vq2X07i0bUwTfbZoOgqSFvMfXJiETcN9R48epPUGWS2IT17NE8EgtH+/srht0 sGGI7bia2a1L++nruccUllCf1qMfngKRQUhatVOPYqIs2dX3ijjjpSAxHh8L+gjC nOMgWu7lZm7QQawBjQGfirpYGBUFdAh3odwm/JHN7+cZKC6dbhLYGm2WS8db1bCI 4k4EO2RpSeuZb9XaFPq9DEWy1exgtgjnmKt3Szrp31/xWizjhMEOrZVWfWD1bjUa rWcmnDR4bm4Fz/MdVFhjJq2XJQoIDw== =2o5y -----END PGP SIGNATURE----- --rawlqk3jhoxts24y--