From: kernel test robot <lkp@intel.com>
To: Puranjay Mohan <puranjay12@gmail.com>,
Michael.Hennerich@analog.com, alexandru.ardelean@analog.com,
jic23@kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
lars@metafoo.de, Dragos.Bogdan@analog.com,
Darius.Berghe@analog.com
Cc: kbuild-all@lists.01.org, Puranjay Mohan <puranjay12@gmail.com>
Subject: Re: [PATCH v7 3/3] iio: accel: adxl355: Add triggered buffer support
Date: Sun, 1 Aug 2021 08:22:19 +0800 [thread overview]
Message-ID: <202108010837.TJ8HXGtc-lkp@intel.com> (raw)
In-Reply-To: <20210731225045.399445-4-puranjay12@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3106 bytes --]
Hi Puranjay,
I love your patch! Yet something to improve:
[auto build test ERROR on iio/togreg]
[also build test ERROR on linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Puranjay-Mohan/iio-accel-add-support-for-ADXL355/20210801-065318
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: m68k-randconfig-r016-20210801 (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4910f5a21dff1f02b50cebccab5096f3cce329b9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Puranjay-Mohan/iio-accel-add-support-for-ADXL355/20210801-065318
git checkout 4910f5a21dff1f02b50cebccab5096f3cce329b9
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/iio/accel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/iio/accel/adxl355_core.c: In function 'adxl355_probe_trigger':
>> drivers/iio/accel/adxl355_core.c:609:19: error: 'struct iio_dev' has no member named 'id'
609 | indio_dev->id);
| ^~
vim +609 drivers/iio/accel/adxl355_core.c
596
597 static int adxl355_probe_trigger(struct iio_dev *indio_dev)
598 {
599 struct adxl355_data *data = iio_priv(indio_dev);
600 int ret;
601
602 if (!data->irq) {
603 dev_info(data->dev, "no irq, using polling\n");
604 return 0;
605 }
606
607 data->dready_trig = devm_iio_trigger_alloc(data->dev, "%s-dev%d",
608 indio_dev->name,
> 609 indio_dev->id);
610 if (!data->dready_trig)
611 return -ENOMEM;
612
613 data->dready_trig->ops = &adxl355_trigger_ops;
614 iio_trigger_set_drvdata(data->dready_trig, indio_dev);
615
616 ret = devm_request_irq(data->dev, data->irq,
617 &iio_trigger_generic_data_rdy_poll,
618 IRQF_ONESHOT, "adxl355_irq", data->dready_trig);
619 if (ret < 0)
620 return dev_err_probe(data->dev, ret, "request irq %d failed\n",
621 data->irq);
622
623 ret = devm_iio_trigger_register(data->dev, data->dready_trig);
624 if (ret) {
625 dev_err(data->dev, "iio trigger register failed\n");
626 return ret;
627 }
628
629 indio_dev->trig = iio_trigger_get(data->dready_trig);
630
631 return 0;
632 }
633
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33265 bytes --]
prev parent reply other threads:[~2021-08-01 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 22:50 [PATCH v7 0/3] iio: accel: add support for ADXL355 Puranjay Mohan
2021-07-31 22:50 ` [PATCH v7 1/3] dt-bindings: iio: accel: Add DT binding doc " Puranjay Mohan
2021-07-31 22:50 ` [PATCH v7 2/3] iio: accel: Add driver support " Puranjay Mohan
2021-08-02 12:19 ` Puranjay Mohan
2021-07-31 22:50 ` [PATCH v7 3/3] iio: accel: adxl355: Add triggered buffer support Puranjay Mohan
2021-08-01 0:22 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108010837.TJ8HXGtc-lkp@intel.com \
--to=lkp@intel.com \
--cc=Darius.Berghe@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).