From: Li Zhijian <lizhijian@cn.fujitsu.com>
To: <leon@kernel.org>, <dledford@redhat.com>, <jgg@ziepe.ca>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: [PATCH] RDMA/mlx5: return the EFAULT per ibv_advise_mr(3)
Date: Sun, 1 Aug 2021 17:20:50 +0800 [thread overview]
Message-ID: <20210801092050.6322-1-lizhijian@cn.fujitsu.com> (raw)
ibv_advise_mr(3) says:
EFAULT In one of the following: o When the range requested is out of the MR bounds,
or when parts of it are not part of the process address space. o One of the
lkeys provided in the scatter gather list is invalid or with wrong write access
Actually get_prefetchable_mr() will return NULL if it see above conditions
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
drivers/infiniband/hw/mlx5/odp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
index d0d98e584ebc..8d2a626c87cf 100644
--- a/drivers/infiniband/hw/mlx5/odp.c
+++ b/drivers/infiniband/hw/mlx5/odp.c
@@ -1791,7 +1791,7 @@ static int mlx5_ib_prefetch_sg_list(struct ib_pd *pd,
mr = get_prefetchable_mr(pd, advice, sg_list[i].lkey);
if (!mr)
- return -ENOENT;
+ return -EFAULT;
ret = pagefault_mr(mr, sg_list[i].addr, sg_list[i].length,
&bytes_mapped, pf_flags);
if (ret < 0) {
--
2.30.2
next reply other threads:[~2021-08-01 9:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 9:20 Li Zhijian [this message]
2021-08-01 11:27 ` [PATCH] RDMA/mlx5: return the EFAULT per ibv_advise_mr(3) Leon Romanovsky
2021-08-03 16:25 ` Jason Gunthorpe
2021-08-03 17:56 ` Leon Romanovsky
2021-08-03 18:13 ` Jason Gunthorpe
2021-08-04 5:35 ` Leon Romanovsky
2021-08-04 18:50 ` Jason Gunthorpe
2021-08-05 6:43 ` Leon Romanovsky
2021-08-16 2:59 ` lizhijian
2021-08-21 9:44 ` Li, Zhijian
2021-08-25 17:28 ` Jason Gunthorpe
2021-08-26 1:18 ` lizhijian
2021-08-28 8:42 ` Li, Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210801092050.6322-1-lizhijian@cn.fujitsu.com \
--to=lizhijian@cn.fujitsu.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).