From: Andrew Morton <akpm@linux-foundation.org>
To: Luigi Rizzo <lrizzo@google.com>
Cc: linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] Add mmap_assert_locked() annotations to find_vma*()
Date: Sun, 1 Aug 2021 12:33:35 -0700 [thread overview]
Message-ID: <20210801123335.6a7f8e1ee1e52ea64db80323@linux-foundation.org> (raw)
In-Reply-To: <20210731175341.3458608-1-lrizzo@google.com>
On Sat, 31 Jul 2021 10:53:41 -0700 Luigi Rizzo <lrizzo@google.com> wrote:
> find_vma() and variants need protection when used.
> This patch adds mmap_assert_lock() calls in the functions.
>
> To make sure the invariant is satisfied, we also need to add a
> mmap_read_loc() around the get_user_pages_remote() call in
> get_arg_page(). The lock is not strictly necessary because the mm
> has been newly created, but the extra cost is limited because
> the same mutex was also acquired shortly before in __bprm_mm_init(),
> so it is hot and uncontended.
>
Well, it isn't cost-free. find_vma() is called a lot and a surprising
number of systems apparently run with CONFIG_DEBUG_VM. Why do you
think this cost is justified?
next prev parent reply other threads:[~2021-08-01 19:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 17:53 [PATCH] Add mmap_assert_locked() annotations to find_vma*() Luigi Rizzo
2021-08-01 19:33 ` Andrew Morton [this message]
2021-08-02 0:16 ` Luigi Rizzo
2021-08-02 21:11 ` Andrew Morton
2021-08-03 16:08 ` Jason Gunthorpe
2021-08-03 21:48 ` Luigi Rizzo
2021-08-03 23:07 ` Liam Howlett
2021-08-03 23:35 ` Jason Gunthorpe
2021-08-03 23:57 ` Luigi Rizzo
2021-08-04 5:12 ` Liam Howlett
2021-08-04 14:42 ` Jann Horn
2021-08-04 15:21 ` Jason Gunthorpe
2021-08-04 21:22 ` Jann Horn
2021-08-04 17:32 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210801123335.6a7f8e1ee1e52ea64db80323@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lrizzo@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).