From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F34C432BE for ; Sun, 1 Aug 2021 17:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 528E661054 for ; Sun, 1 Aug 2021 17:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbhHARvF (ORCPT ); Sun, 1 Aug 2021 13:51:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbhHARvC (ORCPT ); Sun, 1 Aug 2021 13:51:02 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D3DC06175F for ; Sun, 1 Aug 2021 10:50:54 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1mAFbt-0002fK-Te; Sun, 01 Aug 2021 19:50:49 +0200 Date: Sun, 1 Aug 2021 19:50:49 +0200 From: Martin Kaiser To: Larry Finger Cc: Phillip Potter , Greg KH , Dan Carpenter , Linux Kernel Mailing List , linux-staging@lists.linux.dev, Fabio Aiuto Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Message-ID: <20210801175049.eubghjzmhx25ol73@viti.kaiser.cx> References: <20210727232219.2948-1-phil@philpotter.co.uk> <20210728074605.pp5rs4c65tofnqot@viti.kaiser.cx> <20210729133730.lnxqzawnvksp4skg@viti.kaiser.cx> <1d687d5f-d514-655a-f8bf-a5bac321affb@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d687d5f-d514-655a-f8bf-a5bac321affb@lwfinger.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg and Larry, thanks for your responses. Thus wrote Larry Finger (Larry.Finger@lwfinger.net): > I do see this driver being cleaned up to the point that it transitions to mainline. > It is not clear to me that it would fit into the rtlwifi framework. It > probably could use the USB driver there, but unlikely to use a lot more of > that code. Ok, that clarifies that path forward. I wasn't sure if a standalone (non-rtlwifi) driver is acceptable at all. > I will certainly be on the lookout for conflicts with the rtlwifi and > rtl8xxxu, indeed the whole drivers/net/wireless/realtek/, code as the > cleanup proceeds. At the moment, the driver (like the old one) can be compiled only as a module. I guess that's because of name conflicts between realtek drivers that originated from the same codebase. It seems that we'll have to rename some functions along the way. Thanks, Martin