From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FE4C4338F for ; Mon, 2 Aug 2021 13:30:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F3CC60F6D for ; Mon, 2 Aug 2021 13:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbhHBNaJ (ORCPT ); Mon, 2 Aug 2021 09:30:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:45534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233785AbhHBNaI (ORCPT ); Mon, 2 Aug 2021 09:30:08 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4BDD60EFF; Mon, 2 Aug 2021 13:29:58 +0000 (UTC) Date: Mon, 2 Aug 2021 09:29:52 -0400 From: Steven Rostedt To: Masahiro Yamada Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] trace: remove redundant dependency from IRQSOFF_TRACER Message-ID: <20210802092952.3047bb99@oasis.local.home> In-Reply-To: <20210731052233.4703-3-masahiroy@kernel.org> References: <20210731052233.4703-1-masahiroy@kernel.org> <20210731052233.4703-3-masahiroy@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 31 Jul 2021 14:22:33 +0900 Masahiro Yamada wrote: > IRQSOFF_TRACE is already guarded by a stronger condition, > TRACING_SUPPORT. > > 'depends on TRACE_IRQFLAGS_SUPPORT' is redundant. I'm fine with the other two patches, but this one concerns me. I'm not sure TRACING_SUPPORT really needs to depend on TRACE_IRQFLAGS_SUPPORT. When tracing was first introduced, the main use case was the irqsoff tracer. Today, with function graph tracing and events being introduced, it's one of the minor use cases of tracing support. I believe the only thing that requires the TRACE_IRQFLAGS_SUPPORT is the irqsoff tracer (and friends), so if anything, we should remove that dependency from TRACING_SUPPORT, not here. -- Steve > > Signed-off-by: Masahiro Yamada > --- > > kernel/trace/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 9d3f918b5867..b39e67db644e 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -265,7 +265,6 @@ config TRACE_PREEMPT_TOGGLE > config IRQSOFF_TRACER > bool "Interrupts-off Latency Tracer" > default n > - depends on TRACE_IRQFLAGS_SUPPORT > select TRACE_IRQFLAGS > select GENERIC_TRACER > select TRACER_MAX_TRACE