linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Lokesh Vutla <lokeshvutla@ti.com>, Faiz Abbas <faiz_abbas@ti.com>
Subject: Re: [PATCH v2 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN
Date: Mon, 2 Aug 2021 14:59:40 +0200	[thread overview]
Message-ID: <20210802125940.w2djzwuwysco566p@pengutronix.de> (raw)
In-Reply-To: <20210726101012.26983-2-a-govindraju@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

On 26.07.2021 15:40:07, Aswath Govindraju wrote:
> From: Faiz Abbas <faiz_abbas@ti.com>
> 
> Add Support for two MCAN controllers present on the am65x SOC. Both support
> classic CAN messages as well as CAN-FD.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 30 +++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index c93ff1520a0e..6445f2d976e8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -159,6 +159,36 @@
>  		};
>  	};
>  
> +	m_can0: mcan@40528000 {
> +		compatible = "bosch,m_can";
> +		reg = <0x0 0x40528000 0x0 0x400>,
> +		      <0x0 0x40500000 0x0 0x4400>;
> +		reg-names = "m_can", "message_ram";
> +		power-domains = <&k3_pds 102 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 102 0>, <&k3_clks 102 5>;
> +		clock-names = "cclk", "hclk";

The binding says the first should be hclk.

|  clock-names:
|    items:
|      - const: hclk
|      - const: cclk

Please also fix in the other dts files.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-08-02 13:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 10:10 [PATCH v2 0/6] CAN: Add support for CAN in AM65,J721e and AM64 Aswath Govindraju
2021-07-26 10:10 ` [PATCH v2 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN Aswath Govindraju
2021-08-02 12:59   ` Marc Kleine-Budde [this message]
2021-07-26 10:10 ` [PATCH v2 2/6] arm64: dts: ti: am654-base-board: Disable mcan nodes Aswath Govindraju
2021-07-26 10:10 ` [PATCH v2 3/6] arm64: dts: ti: k3-j721e: Add support for MCAN nodes Aswath Govindraju
2021-07-26 10:10 ` [PATCH v2 4/6] arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan nodes Aswath Govindraju
2021-07-26 10:10 ` [PATCH v2 5/6] arm64: dts: ti: k3-am64-main: Add support for MCAN Aswath Govindraju
2021-07-26 10:10 ` [PATCH v2 6/6] arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan nodes in EVM and disable them on SK Aswath Govindraju
2021-07-28  5:19 ` [PATCH v2 0/6] CAN: Add support for CAN in AM65,J721e and AM64 Aswath Govindraju
2021-07-28  7:26   ` Marc Kleine-Budde
2021-08-02 12:45 ` Nishanth Menon
2021-08-05 12:32   ` Aswath Govindraju
2021-08-05 12:40     ` Jan Kiszka
2021-08-05 12:44       ` Aswath Govindraju
2021-08-05 12:49         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802125940.w2djzwuwysco566p@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=a-govindraju@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faiz_abbas@ti.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v2 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).