From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0C027C432BE
	for <linux-kernel@archiver.kernel.org>; Mon,  2 Aug 2021 20:32:38 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id EAD0261104
	for <linux-kernel@archiver.kernel.org>; Mon,  2 Aug 2021 20:32:37 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231401AbhHBUcq (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 2 Aug 2021 16:32:46 -0400
Received: from mail.kernel.org ([198.145.29.99]:56280 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229729AbhHBUcm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Aug 2021 16:32:42 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 16F4160D07;
        Mon,  2 Aug 2021 20:32:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1627936352;
        bh=7Omv5X3Y5yxWtYvKeuj6gzKo2AOy6KsbmDol1EN2zbA=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=cA3Zk9hkCToaUg0zm9Es4aHNDzwrtmj0F9dFDoYejpNrAZL6G4EcwcrDmhLK1ym1w
         kEhalschuUFLdwQqZsTV6EIVz4NVF93syTVMxY5/lb5JZAwSdazHKqcdSsKJ/HGEZf
         /69fKF19AEWyyMpxb7catLPAuqgJwXnS7O7fRk8+m8p9iOwrih7A1fSdqNtgqJ6Xfv
         POAbG8c5k//sbYcTgXZBPKMHZ4jHpr0FHXDdINNJX8WgsrBdE1fT/YIRekkhe1jev+
         Jl4Pg0c7GvnlhakMGitXFndsnWXg9tUd8/iUewyak873rUXmP179OSFh/gSPsD24Se
         3JDssKIJ0X19A==
Date:   Mon, 2 Aug 2021 13:32:30 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     davem@davemloft.net, andrew@lunn.ch, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
Message-ID: <20210802133230.1a17ac4c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210730114709.12385-1-qiangqing.zhang@nxp.com>
References: <20210730114709.12385-1-qiangqing.zhang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
>  		fep->phy_interface = interface;
>  	}
>  
> +	ret = fec_enet_parse_rgmii_delay(fep, np);
> +	if (ret)
> +		goto failed_phy;

You're jumping to the wrong label, it looks like phy_node needs to be
released at this point.