From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2D5C4320A for ; Mon, 2 Aug 2021 13:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07AE660F6D for ; Mon, 2 Aug 2021 13:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234037AbhHBNnv (ORCPT ); Mon, 2 Aug 2021 09:43:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233956AbhHBNnu (ORCPT ); Mon, 2 Aug 2021 09:43:50 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50573C061760; Mon, 2 Aug 2021 06:43:39 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id h9so15524441ejs.4; Mon, 02 Aug 2021 06:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=q3LMLHUiJgMv1kBej5JGB879UzZgEmTMwjmj9nvqpWc=; b=gHbazKLYudEs+w+lX0U7K9hhRGdnhsn/KcpXhThORDMW3TyJSP3iStfdLH4IZcD/KE dWtA8BrrCZn8gGZ4PS8uDQdZIiHbJLYKoGJ6J2h2u2H2ML+69vEb1Ir0m3Vn14v16SkR TKrW5qITrEz9rIvsy5UqEEURLSEredQJhscto4GzmdZ7xQAyEbE8tU+FNVhmh3ML7iUc rq6IVBHpcBMisSS9yeOZO9xmcYujWaH/X3hEFGbBBVQ0fWK+3muiSFTPtUMyJSrxEmiV 4YZ2pNkIB3VO7C1lghjUihRb1VoUWdXDZoIs2GyL/2B9clA6NDLezCKwtqQjDn3iB9rY cPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q3LMLHUiJgMv1kBej5JGB879UzZgEmTMwjmj9nvqpWc=; b=meZrvhM8Kqf/7YFDWcXB3JIy5tKYzqZykHBeKKPo90XNtH5L2OGv2ZQXBCNiP4aSa7 MAqDv+46Rr9r+eialB7hKrkepnwKdLYdwPfFqLuYZx2o4cfJI6pKOMYGrqj1kHGTKLNN n5XobwD9mQF1+5fCtwvasYAR7/Vi+AdE2B61EY1Wk1DhR6XWO6UZ19J5FhGmcAf5/NkO AQATSsL4ie+eGeoNGVCK2a7rrIxBRUDyrgFoEp7qdGS2abri2C7Y6XyoRC84boUuJ1MT AA3+ZqqsCmgBcOzLy8I57S51r+DgQ6lsm0nuiVOn2V7zmL6pH+RDxMlM991FGpJGU+bG GEtw== X-Gm-Message-State: AOAM531pODrNRx7sZSeGwrhQsKdTA0O0+dnL1zXNLJ75m36IvNnL6UgJ dUYjcfmkW935OBRPUEtRNUc= X-Google-Smtp-Source: ABdhPJw6vCmkFlF6kE0P2ErCDImL+4aRsa1VJAzRVkcEAF3Ce6rnneVKlUR57hGKi6X6whoXtcRaRw== X-Received: by 2002:a17:906:314e:: with SMTP id e14mr3596232eje.165.1627911817933; Mon, 02 Aug 2021 06:43:37 -0700 (PDT) Received: from skbuf ([188.25.144.60]) by smtp.gmail.com with ESMTPSA id b2sm6130288edr.16.2021.08.02.06.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 06:43:37 -0700 (PDT) Date: Mon, 2 Aug 2021 16:43:36 +0300 From: Vladimir Oltean To: DENG Qingfang Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Woudstra , =?utf-8?B?UmVuw6k=?= van Dorst , Frank Wunderlich Subject: Re: [RFC net-next v2 3/4] net: dsa: mt7530: set STP state also on filter ID 1 Message-ID: <20210802134336.gv66le6u2z52kfkh@skbuf> References: <20210731191023.1329446-1-dqfext@gmail.com> <20210731191023.1329446-4-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210731191023.1329446-4-dqfext@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 01, 2021 at 03:10:21AM +0800, DENG Qingfang wrote: > As filter ID 1 is used, set STP state also on it. > > Signed-off-by: DENG Qingfang > --- > drivers/net/dsa/mt7530.c | 3 ++- > drivers/net/dsa/mt7530.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 3876e265f844..38d6ce37d692 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -1147,7 +1147,8 @@ mt7530_stp_state_set(struct dsa_switch *ds, int port, u8 state) > break; > } > > - mt7530_rmw(priv, MT7530_SSP_P(port), FID_PST_MASK, stp_state); > + mt7530_rmw(priv, MT7530_SSP_P(port), FID_PST_MASK, > + FID_PST(stp_state)); > } > > static int > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h > index a308886fdebc..294ff1cbd9e0 100644 > --- a/drivers/net/dsa/mt7530.h > +++ b/drivers/net/dsa/mt7530.h > @@ -181,7 +181,7 @@ enum mt7530_vlan_egress_attr { > > /* Register for port STP state control */ > #define MT7530_SSP_P(x) (0x2000 + ((x) * 0x100)) > -#define FID_PST(x) ((x) & 0x3) Shouldn't these macros have _two_ arguments, the FID and the port state? > +#define FID_PST(x) (((x) & 0x3) * 0x5) "* 5": explanation? > #define FID_PST_MASK FID_PST(0x3) > > enum mt7530_stp_state { > -- > 2.25.1 > I don't exactly understand how this patch works, sorry. Are you altering port state only on bridged ports, or also on standalone ports after this patch? Are standalone ports in the proper STP state (FORWARDING)?