From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD25C432BE for ; Mon, 2 Aug 2021 20:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 104E660F9C for ; Mon, 2 Aug 2021 20:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231191AbhHBULH (ORCPT ); Mon, 2 Aug 2021 16:11:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46442 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbhHBULG (ORCPT ); Mon, 2 Aug 2021 16:11:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627935055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LA8evM7BHjBr4jABvi1M9utaaAjmimAJTMztodEqWno=; b=Sdbwc2nyDANJY1mFTAktqUhIeYe1Hs7Q9uW6bdmTOawW+OsHzwxayFV7TqtNuUqjreizyr j5JSnYuDyIG8hmLLiH6bWL9w4EvJjicSw4UpSNJxrIfxK+EzjzDXCRTBlca2ypY62nWf5h CsDI2jPkmvvVZ2z/by52UsefAJR7tZU= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-j0lU5-KKNSK37K6YjT4mVA-1; Mon, 02 Aug 2021 16:10:54 -0400 X-MC-Unique: j0lU5-KKNSK37K6YjT4mVA-1 Received: by mail-ej1-f69.google.com with SMTP id e8-20020a1709060808b02904f7606bd58fso5117534ejd.11 for ; Mon, 02 Aug 2021 13:10:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LA8evM7BHjBr4jABvi1M9utaaAjmimAJTMztodEqWno=; b=ISvAYORaqrWFdBJX47ZBCtEgjTNXtE+2AXhKMFnDximPlnVpGeIq7u+UROeujrn81o x6sFBtNUSqOlhPLdk1oSib2rlpMn4TY3XUbOxe/C5r0Lv0WI1jvHLRN6UyTqXvkntsAP Z/q3dNb1Oq+dUQkV/AbmRtIGoUPuq5AU7E1j8K2LrPpAgYtonpeSGYutyJe3MjY2++Z4 swpileRti4IXHbKz0qeXs3z+5b+02hQeu8PQjDYFdtxV4oWzPz5JAhNmdMWueTEXgP2F tvjtJ3mmelQ9BJzP1dqPFXnqvrT3w4HZXhm3WU8GYwKX5FM22Qpb8ROVijWCmTdErYNm PFeA== X-Gm-Message-State: AOAM531/BeQQT4DKTR/z3oj51CoHyPOw/OvLi8GnvjseY06U7cE3Rj5d RW//ymH2mxIGFQZJd9LcT0m9UR89EcnBfToFyUS4EK++SDYB5I3hW+BHvb2lmRDXaz7LmHb5GxY atC6yQPLFvkvOUxqbll1eGplA X-Received: by 2002:a17:906:4b18:: with SMTP id y24mr16671488eju.42.1627935053630; Mon, 02 Aug 2021 13:10:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQDGepqRHg1s0zF2qekNjn1VPDNh8LoMDbONxjezTZrGQTTG2YxoZ166f6S0JBTqWT6JZH/A== X-Received: by 2002:a17:906:4b18:: with SMTP id y24mr16671470eju.42.1627935053501; Mon, 02 Aug 2021 13:10:53 -0700 (PDT) Received: from redhat.com ([2.55.140.205]) by smtp.gmail.com with ESMTPSA id g8sm6748637edw.89.2021.08.02.13.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 13:10:52 -0700 (PDT) Date: Mon, 2 Aug 2021 16:10:48 -0400 From: "Michael S. Tsirkin" To: fuguancheng Cc: jasowang@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, davem@davemloft.net, kuba@kernel.org, arseny.krasnov@kaspersky.com, andraprs@amazon.com, colin.king@canonical.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] VSOCK DRIVER: Add multi-cid support for guest Message-ID: <20210802160815-mutt-send-email-mst@kernel.org> References: <20210802120720.547894-1-fuguancheng@bytedance.com> <20210802120720.547894-2-fuguancheng@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210802120720.547894-2-fuguancheng@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 02, 2021 at 08:07:17PM +0800, fuguancheng wrote: > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > index c998860d7bbc..a3ea99f6fc7f 100644 > --- a/include/uapi/linux/vhost.h > +++ b/include/uapi/linux/vhost.h > @@ -17,6 +17,13 @@ > > #define VHOST_FILE_UNBIND -1 > > +/* structs used for hypervisors to send cid info. */ > + > +struct multi_cid_message { > + u32 number_cid; > + u64 *cid; > +}; > + > /* ioctls */ > > #define VHOST_VIRTIO 0xAF In this case, a kernel pointer in a UAPI struct is suspicious. So is padding after number_cid. -- MST