From: Guenter Roeck <linux@roeck-us.net>
To: Carlos Alberto Lopez Perez <clopez@igalia.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>, Pali Rohar <pali@kernel.org>
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell Precision 7510 to fan control whitelist
Date: Mon, 2 Aug 2021 15:51:50 -0700 [thread overview]
Message-ID: <20210802225150.GA2134522@roeck-us.net> (raw)
In-Reply-To: <20210802131538.8660-1-clopez@igalia.com>
On Mon, Aug 02, 2021 at 02:15:38PM +0100, Carlos Alberto Lopez Perez wrote:
> This allows manual PWM control without the BIOS fighting back on Dell
> Precision 7510. Meanwhile at it, also sort alphabetically the entries
> of the i8k_whitelist_fan_control struct.
>
> Signed-off-by: Carlos Alberto Lopez Perez <clopez@igalia.com>
> Acked-by: Pali Rohár <pali@kernel.org>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/dell-smm-hwmon.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f2221ca0aa7b..a677c8a4ef29 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1186,14 +1186,6 @@ static const struct i8k_fan_control_data i8k_fan_control_data[] = {
> };
>
> static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
> - {
> - .ident = "Dell Precision 5530",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 5530"),
> - },
> - .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> - },
> {
> .ident = "Dell Latitude 5480",
> .matches = {
> @@ -1218,6 +1210,22 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell Precision 5530",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 5530"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> + {
> + .ident = "Dell Precision 7510",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7510"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> { }
> };
>
prev parent reply other threads:[~2021-08-02 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 13:15 [PATCH] hwmon: (dell-smm) Add Dell Precision 7510 to fan control whitelist Carlos Alberto Lopez Perez
2021-08-02 17:29 ` Pali Rohar
2021-08-02 22:51 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802225150.GA2134522@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clopez@igalia.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).