From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713B6C4338F for ; Tue, 3 Aug 2021 21:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55F2860724 for ; Tue, 3 Aug 2021 21:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbhHCV4g (ORCPT ); Tue, 3 Aug 2021 17:56:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:60750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbhHCV4e (ORCPT ); Tue, 3 Aug 2021 17:56:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CC8860724; Tue, 3 Aug 2021 21:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628027782; bh=CtaBctNlap/TA51MNQzdE8Z4XTDacO9V6XB4566z4OY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=n9acgLJETvuySpQhKuaTGNHHDO022gVq6tFNDIgn/na1HiYPq6L21pOnReGAmMSVO vQhtRlvDOQA1DLxbDVpZRApimRHDcVhTp95NaW/42nxBoQLucTiVkejeKNP/X6Cswv uwsuneTKzo/LrnNWGjOhQ3qILvhJEXuCrB8pabi5wvaWSDqNMF/KnDAVSNWWtgZB5z aXfBQUoP6+rjXWSOwbxoT9cwRQyccd00dkTTYqarsJtlY1GMY/HnXwiID+C8+CBarV GlnW9EHhn9cU6CsADyyLVgfO41M8fn8e65MMllL/BFDu+aQmXezq07OaDNaYb7d5hm jhRNju0zNN3uA== Date: Tue, 3 Aug 2021 16:56:21 -0500 From: Bjorn Helgaas To: Nathan Chancellor Cc: Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Nick Desaulniers , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] PCI: Always initialize dev in pciconfig_read Message-ID: <20210803215621.GA1576408@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210803200836.500658-1-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 03, 2021 at 01:08:36PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/pci/syscall.c:25:6: warning: variable 'dev' is used > uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (!capable(CAP_SYS_ADMIN)) > ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/pci/syscall.c:81:14: note: uninitialized use occurs here > pci_dev_put(dev); > ^~~ > drivers/pci/syscall.c:25:2: note: remove the 'if' if its condition is > always false > if (!capable(CAP_SYS_ADMIN)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/pci/syscall.c:18:21: note: initialize the variable 'dev' to > silence this warning > struct pci_dev *dev; > ^ > = NULL > 1 warning generated. > > pci_dev_put accounts for a NULL pointer so initialize dev to NULL before > the capability check so that there is no use of uninitialized memory. > > Fixes: 61a6199787d9 ("PCI: Return ~0 data on pciconfig_read() CAP_SYS_ADMIN failure") > Signed-off-by: Nathan Chancellor Squashed in locally, thanks! > --- > drivers/pci/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/syscall.c b/drivers/pci/syscall.c > index 525f16caed1d..61a6fe3cde21 100644 > --- a/drivers/pci/syscall.c > +++ b/drivers/pci/syscall.c > @@ -22,6 +22,7 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn, > int err, cfg_ret; > > err = -EPERM; > + dev = NULL; > if (!capable(CAP_SYS_ADMIN)) > goto error; > > > base-commit: 21d8e94253eb09f7c94c4db00dc714efc75b8701 > -- > 2.33.0.rc0 >