From: Kari Argillander <email@example.com> To: "Darrick J. Wong" <firstname.lastname@example.org> Cc: Theodore Ts'o <email@example.com>, Linus Torvalds <firstname.lastname@example.org>, Matthew Wilcox <email@example.com>, "Leonidas P. Papadakos" <firstname.lastname@example.org>, Konstantin Komarov <email@example.com>, firstname.lastname@example.org, Greg Kroah-Hartman <email@example.com>, Hans de Goede <firstname.lastname@example.org>, linux-fsdevel <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org>, Al Viro <email@example.com> Subject: Re: [GIT PULL] vboxsf fixes for 5.14-1 Date: Wed, 4 Aug 2021 09:38:10 +0300 [thread overview] Message-ID: <20210804063810.dvnqgxnaoajy3ehe@kari-VirtualBox> (raw) In-Reply-To: <20210804010351.GM3601466@magnolia> On Tue, Aug 03, 2021 at 06:03:51PM -0700, Darrick J. Wong wrote: > On Tue, Aug 03, 2021 at 08:49:28PM -0400, Theodore Ts'o wrote: > > On Tue, Aug 03, 2021 at 05:10:22PM -0700, Linus Torvalds wrote: > > > The user-space FUSE thing does indeed work reasonably well. > > > > > > It performs horribly badly if you care about things like that, though. > > > > > > In fact, your own numbers kind of show that: > > > > > > ntfs/default: 670 tests, 55 failures, 211 skipped, 34783 seconds > > > ntfs3/default: 664 tests, 67 failures, 206 skipped, 8106 seconds > > > > > > and that's kind of the point of ntfs3. > > > > Sure, although if you run fstress in parallel ntfs3 will lock up, the > > system hard, and it has at least one lockdep deadlock complaints. > > It's not up to me, but personally, I'd feel better if *someone* at > > Paragon Software responded to Darrrick and my queries about their > > quality assurance, and/or made commitments that they would at least > > *try* to fix the problems that about 5 minutes of testing using > > fstests turned up trivially. > > <cough> Yes, my aim was to gauge their interest in actively QAing the > driver's current problems so that it doesn't become one of the shabby > Linux filesystem drivers, like <cough>ntfs. > > Note I didn't even ask for a particular percentage of passing tests, > because I already know that non-Unix filesystems fail the tests that > look for the more Unix-specific behaviors. > > I really only wanted them to tell /us/ what the baseline is. IMHO the > silence from them is a lot more telling. Both generic/013 and > generic/475 are basic "try to create files and read and write data to > them" exercisers; failing those is a red flag. > Konstantin has wrote about these thing see below. On Thu, 20 Aug 2020 10:20:26 +0000, Konstantin Komarov wrote: > xfstests are being one of our standard test suites among others. > Currently we have the 'generic/339' and 'generic/013' test cases > failing, working on it now. Other tests either pass or being skipped > (due to missing features e.g. reflink). Source: https://firstname.lastname@example.org/ Also code tells that xfstests is being used in Paragon. In ntfs3/file.c: /* * Unwritten area * NTFS is not able to store several unwritten areas * Activate 'ntfs_sparse_cluster' to zero new allocated clusters * * Dangerous in case: * 1G of sparsed clusters + 1 cluster of data => * valid_size == 1G + 1 cluster * fallocate(1G) will zero 1G and this can be very long * xfstest 016/086 will fail without 'ntfs_sparse_cluster' */ /*ntfs_sparse_cluster(inode, NULL, vcn, * min(vcn_v - vcn, clen)); */ I'm just bringing this thing up because so many has asked and Konstantin has not responded recently. Hopefully he will soon. Of course is it little bit worrying that example generic/013 still fails after almoust year has passed and Konstantin said he is working on it. And it seems that more tests fails than beginning of review process. > --D > > > I can even give them patches and configsto make it trivially easy for > > them to run fstests using KVM or GCE.... > > > > - Ted
next prev parent reply other threads:[~2021-08-04 6:38 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-13 10:45 Hans de Goede 2021-07-13 19:15 ` Linus Torvalds 2021-07-13 20:14 ` Al Viro 2021-07-13 20:18 ` Al Viro 2021-07-13 20:24 ` Randy Dunlap 2021-07-13 20:32 ` Al Viro 2021-07-13 21:43 ` Randy Dunlap 2021-07-14 10:50 ` Rafał Miłecki 2021-07-14 14:13 ` Christoph Hellwig 2021-07-14 14:51 ` Greg KH 2021-07-14 15:59 ` Rafał Miłecki 2021-07-14 16:05 ` Matthew Wilcox 2021-07-14 16:18 ` Rafał Miłecki 2021-07-15 21:50 ` Neal Gompa 2021-07-16 11:46 ` Leonidas P. Papadakos 2021-07-16 18:07 ` Linus Torvalds 2021-07-30 15:55 ` Konstantin Komarov 2021-07-30 17:23 ` Paragon NTFSv3 (was Re: [GIT PULL] vboxsf fixes for 5.14-1) Linus Torvalds 2021-08-13 16:11 ` Konstantin Komarov 2021-08-15 20:32 ` Stephen Rothwell 2021-08-16 3:00 ` Kari Argillander 2021-09-02 21:55 ` Linus Torvalds 2021-08-03 22:48 ` [GIT PULL] vboxsf fixes for 5.14-1 Theodore Ts'o 2021-08-03 23:44 ` Matthew Wilcox 2021-08-04 0:04 ` Theodore Ts'o 2021-08-04 0:10 ` Linus Torvalds 2021-08-04 0:49 ` Theodore Ts'o 2021-08-04 1:03 ` Darrick J. Wong 2021-08-04 6:38 ` Kari Argillander [this message] 2021-08-04 16:30 ` Theodore Ts'o 2021-08-05 15:48 ` Konstantin Komarov 2021-08-10 7:02 ` Darrick J. Wong 2021-09-02 22:09 ` NTFS testing (was: " Szabolcs Szakacsits 2021-09-03 17:48 ` Eric Biggers 2021-09-03 21:17 ` Szabolcs Szakacsits 2021-07-17 16:47 ` Pali Rohár 2021-07-14 16:13 ` Darrick J. Wong 2021-07-14 16:18 ` Christoph Hellwig 2021-07-14 16:38 ` Gao Xiang 2021-07-14 20:03 ` Eric W. Biederman 2021-07-15 22:14 ` Darrick J. Wong 2021-07-13 19:17 ` pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210804063810.dvnqgxnaoajy3ehe@kari-VirtualBox \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GIT PULL] vboxsf fixes for 5.14-1' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).