From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: cgel.zte@gmail.com
Cc: yong.yiran@zte.com.cn, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] 'linux/tty.h' included in 'hackkit.c' is duplicated. It is also included in the 21th line.
Date: Wed, 4 Aug 2021 11:13:58 +0100 [thread overview]
Message-ID: <20210804101358.GO22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210804093907.618719-1-yong.yiran@zte.com.cn>
On Wed, Aug 04, 2021 at 02:39:07AM -0700, cgel.zte@gmail.com wrote:
> From: yong yiran <yong.yiran@zte.com.cn>
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
Hi,
The commit message and summary(subject) could do with some improvement:
1) I don't think having "It is also included in the 21th line." in the
summary adds value.
2) Maybe the summary should be
"Remove duplicated 'linux/tty.h' include in 'hackkit.c'"
3) the commit message should say something, maybe along the lines of:
"Remove all but the first include of linux/tty.h from hackkit.c."
Thanks.
> ---
> arch/arm/mach-sa1100/hackkit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c
> index 3085f1c2e586..3fe34ee7c0ab 100644
> --- a/arch/arm/mach-sa1100/hackkit.c
> +++ b/arch/arm/mach-sa1100/hackkit.c
> @@ -18,7 +18,6 @@
> #include <linux/serial_core.h>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
> -#include <linux/tty.h>
> #include <linux/gpio.h>
> #include <linux/leds.h>
> #include <linux/platform_device.h>
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2021-08-04 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 9:39 [PATCH linux-next] 'linux/tty.h' included in 'hackkit.c' is duplicated. It is also included in the 21th line cgel.zte
2021-08-04 10:13 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804101358.GO22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=cgel.zte@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yong.yiran@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).