From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix cast between incompatible function type
Date: Wed, 4 Aug 2021 15:49:10 +0300 [thread overview]
Message-ID: <20210804124910.GI1931@kadam> (raw)
In-Reply-To: <20210801233242.20436-1-fmdefrancesco@gmail.com>
On Mon, Aug 02, 2021 at 01:32:41AM +0200, Fabio M. De Francesco wrote:
> Fix sparse warnings of casts between incompatible function
> types from ‘void (*)(void *)’ to ‘void (*)(long unsigned int)’
> [-Wcast-function-type].
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/r8188eu/hal/rtl8188eu_recv.c | 2 +-
> drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_recv.c b/drivers/staging/r8188eu/hal/rtl8188eu_recv.c
> index 2e3f624d0f22..ef722b4a9ddb 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188eu_recv.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188eu_recv.c
> @@ -38,7 +38,7 @@ int rtl8188eu_init_recv_priv(struct adapter *padapter)
> struct recv_buf *precvbuf;
>
> tasklet_init(&precvpriv->recv_tasklet,
> - (void(*)(unsigned long))rtl8188eu_recv_tasklet,
> + (void *)rtl8188eu_recv_tasklet,
The correct fix is to change rtl8188eu_recv_tasklet to take an unsigned
long instead of a pointer. Then you can remove the casting entirely.
The rule here is that you should try avoid casting things to a void
pointer.
regards,
dan carpenter
prev parent reply other threads:[~2021-08-04 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 23:32 [PATCH] staging: r8188eu: Fix cast between incompatible function type Fabio M. De Francesco
2021-08-04 12:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804124910.GI1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).