From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F8BC4320A for ; Wed, 4 Aug 2021 14:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B742F60F14 for ; Wed, 4 Aug 2021 14:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238602AbhHDOD4 (ORCPT ); Wed, 4 Aug 2021 10:03:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238587AbhHDODw (ORCPT ); Wed, 4 Aug 2021 10:03:52 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF88AC061799 for ; Wed, 4 Aug 2021 07:03:38 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id g13so4599020lfj.12 for ; Wed, 04 Aug 2021 07:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ughZXN0i6ciMUaDjjaXdTQDv5YKCIbyqFTwOxdxRMYc=; b=cwWoGqnBtbRPE3rm+p3rv/XNLBT6UskyQZGbimvxIbkwBs9NHfpMNztqOBU1axgWsG k+F67X5sBHfB/LkTVsbBcVP2q59dpESact7KEX5gs+41LKKBw5SglU+AMKmP/VXtN5qf oOtAuvqE0rzvbGC+nI1XTgP/4PMXCt+NQLGsbz48Zlk1S5hT41Hpq/SukRNVayGLyx4d aubveY9oEz/95GNs4EfKHMpq3GIAzIkijo2rW4tK1OUWJ48SI8Vs49cxQFbo/S+Bucxv H4XQKrayIn0ZOhCKjafL1f2R+9oxA8RT/Zmve2xalFVx/569jcVkyshiYm0Swqqjl8oi IOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ughZXN0i6ciMUaDjjaXdTQDv5YKCIbyqFTwOxdxRMYc=; b=NAe3oNm15BZZ3cUNFWiv7Kdd3rfmi17i4IQ8Ep84FrUOkrxQd4aCJXgiElXyVl5PCd c70+Qk1BLk5TpUS0OUpRAaAhwLUyUzA/j8XDCOAcHwJE+3TQomtHY4urRA33QsYSA8Wc 5TWdVqzttuGuOMt3o7GDSh/vhc/sp+kwI9DTGzRtXh6Saps5X2dnDjDe9eNXSb0/fQed r2e/J3HsV0NWl1Z2gSZZ6CSlEpE8YoEmEdJMfCBiKHMByzyS+mqeIxthotRiTean3h1l G7Xnjf+9CDjCVeOx0g9oSXkdcHgk1H20Bw01jHDzciNj3+CiBOflNXJSxlOkt8a1M0dh 0eug== X-Gm-Message-State: AOAM533bUPaqxQ+V0zZK+bgX+f2m5kwXU1Uv3P7XS2FGuOlTqwoDphyt HYziduQBZYEkOUL70akT8Qs9Fg== X-Google-Smtp-Source: ABdhPJwoHv/m0AtQTKnETyKLX66l6MWvksv+9Z7Vx7V6O2e8eYlYGJ7BNGoinJFDdPVshZj0811POg== X-Received: by 2002:a05:6512:b22:: with SMTP id w34mr20234036lfu.596.1628085817256; Wed, 04 Aug 2021 07:03:37 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b15sm207452lff.104.2021.08.04.07.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 07:03:36 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 23CAC102BC1; Wed, 4 Aug 2021 17:03:41 +0300 (+03) Date: Wed, 4 Aug 2021 17:03:41 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , Shakeel Butt , "Kirill A. Shutemov" , Yang Shi , Miaohe Lin , Mike Kravetz , Michal Hocko , Rik van Riel , Christoph Hellwig , Matthew Wilcox , "Eric W. Biederman" , Alexey Gladkov , Chris Wilson , Matthew Auld , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/16] memfd: memfd_create(name, MFD_HUGEPAGE) for shmem huge pages Message-ID: <20210804140341.m3ptxesrxwivqjmk@box.shutemov.name> References: <2862852d-badd-7486-3a8e-c5ea9666d6fb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 12:45:49AM -0700, Hugh Dickins wrote: > Commit 749df87bd7be ("mm/shmem: add hugetlbfs support to memfd_create()") > in 4.14 added the MFD_HUGETLB flag to memfd_create(), to use hugetlbfs > pages instead of tmpfs pages: now add the MFD_HUGEPAGE flag, to use tmpfs > Transparent Huge Pages when they can be allocated (flag named to follow > the precedent of madvise's MADV_HUGEPAGE for THPs). I don't like the interface. THP supposed to be transparent, not yet another hugetlbs. > /sys/kernel/mm/transparent_hugepage/shmem_enabled "always" or "force" > already made this possible: but that is much too blunt an instrument, > affecting all the very different kinds of files on the internal shmem > mount, and was intended just for ease of testing hugepage loads. I wounder if your tried "always" in production? What breaks? Maybe we can make it work with a heuristic? This would speed up adoption. If a tunable needed, I would rather go with fadvise(). It would operate on a couple of bits per struct file and they get translated into VM_HUGEPAGE and VM_NOHUGEPAGE on mmap(). Later if needed fadvise() implementation may be extended to track requested ranges. But initially it can be simple. -- Kirill A. Shutemov