From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0EEC4338F for ; Wed, 4 Aug 2021 14:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F0E660E09 for ; Wed, 4 Aug 2021 14:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238655AbhHDONf (ORCPT ); Wed, 4 Aug 2021 10:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238560AbhHDONe (ORCPT ); Wed, 4 Aug 2021 10:13:34 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94EF7C0613D5 for ; Wed, 4 Aug 2021 07:13:21 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1mBHdx-0000E0-VE; Wed, 04 Aug 2021 16:13:13 +0200 Date: Wed, 4 Aug 2021 16:13:13 +0200 From: Martin Kaiser To: Dan Carpenter Cc: Greg Kroah-Hartman , Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: r8188eu: remove RT_TRACE and DBG_88E prints from usb_intf.c Message-ID: <20210804141313.enaysxjdmspfgy4i@viti.kaiser.cx> References: <20210801173023.1370-1-martin@kaiser.cx> <20210804113234.GG1931@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804113234.GG1931@kadam> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Dan Carpenter (dan.carpenter@oracle.com): > On Sun, Aug 01, 2021 at 07:30:22PM +0200, Martin Kaiser wrote: > > #endif > > - /* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto > > - * suspend influence */ > > - if (usb_autopm_get_interface(pusb_intf) < 0) > > - DBG_88E("can't get autopm:\n"); > > - > > /* alloc dev name after read efuse. */ > > rtw_init_netdev_name(pnetdev, padapter->registrypriv.ifname); > > rtw_macaddr_cfg(padapter->eeprompriv.mac_addr); > This patch accidentally removes the usb_autopm_get_interface() call. Thanks, I didn't notice this. Just sent out v2.