From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435F4C4338F for ; Wed, 4 Aug 2021 14:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28F0560F58 for ; Wed, 4 Aug 2021 14:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239093AbhHDOdR (ORCPT ); Wed, 4 Aug 2021 10:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238967AbhHDOci (ORCPT ); Wed, 4 Aug 2021 10:32:38 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CD3C061798 for ; Wed, 4 Aug 2021 07:32:24 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id zb12so3967397ejb.5 for ; Wed, 04 Aug 2021 07:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wh7D8LABJ00AGBeGW6Pv8KXUbKWQ/bcBiYL57PSEtj0=; b=IXBa7dfqQgn/OsIIUSauszYj1NFKh1InFqi9hf++RU0gs2u3QjN5DHibsmAZeBx9Rg pACokMLMkaD2cplXE0jYtinCxlHilrvUgOqQgYa0DWcGUsQe1GgL/zwDEVZU23uEXT7B Kee5U5GIpfRFZYeJK1jcw359YjSSK6rM2CvkG1Wwwp2L7JODCW6mdYZI9ER1rFJyT7+Q PVaRbwlHoKxuSKcbzEiqIK2026MBnk/N5lDN5cOKzO83l8O8NZz3ZpCTEVPqW6QISNla R3R1VN3lY+/cAzdJ3HkVVAPnxPKuY17+1omTv67YvpA26FX8k6FYRw/L6j/9SwFL0FKk GQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wh7D8LABJ00AGBeGW6Pv8KXUbKWQ/bcBiYL57PSEtj0=; b=GBiCpsx4FNCAtBc8NMqH9fS7Rg1we7AIUGa1Lth3axyU31xSBZnNvP94H0/gjgBd4x HEsyRmmIRqd+j5iV9pCWH7jlRnjfMCy69ZUUY+cpKdJWchM+WrdmRJqItZZKdt4FAlhe kUjHjWnryMskcZUZvCRHu6rzKqPDRCAPXIeUeCBHxBzOVmtTef7SM/njhF57/rSnpTxG iLrMALy8+sos+jZOCtpI3JKQGPnAQ5UJNKpRQxpBJf1VP/K4OgZ9vzjzO8CtDC7lafVS 7zpjR2WSLS5STYC9/KN1mXBu66KuXvUQ49XLCUNBX9EMQL025GAtZ7zE/njLHrDPbJ9l aBvA== X-Gm-Message-State: AOAM530ZlZZ71RJmEmf2UWFUoJD7EaCcbUv2S8cCeWM819IhUl+/bUoS J7I3aCJFRnGGdbUVOmp8Tiplq9B2BU0= X-Google-Smtp-Source: ABdhPJwHghnztlq4JpKkAD3dufINYwXOjofjkAn9AyfpE1CDk2x8QRgditoL1mcEUXKGvsZPh/1aOQ== X-Received: by 2002:a17:906:a298:: with SMTP id i24mr2739803ejz.151.1628087543244; Wed, 04 Aug 2021 07:32:23 -0700 (PDT) Received: from localhost.localdomain (host-82-51-42-96.retail.telecomitalia.it. [82.51.42.96]) by smtp.gmail.com with ESMTPSA id j23sm1016142eds.21.2021.08.04.07.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 07:32:22 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Larry Finger , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH v2] staging: r8188eu: Fix cast between incompatible function type Date: Wed, 4 Aug 2021 16:32:18 +0200 Message-Id: <20210804143218.13665-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix sparse warnings of casts between incompatible function types from ‘void (*)(void *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]. Suggested-by: Dan Carpenter Signed-off-by: Fabio M. De Francesco --- v1 -> v2: According to a suggestion by Dan Carpenter, fix this issue by having functions to take an unsigned long instead of a pointer to void. drivers/staging/r8188eu/hal/rtl8188eu_recv.c | 2 +- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 2 +- drivers/staging/r8188eu/hal/usb_ops_linux.c | 4 ++-- drivers/staging/r8188eu/include/rtl8188e_recv.h | 2 +- drivers/staging/r8188eu/include/rtl8188e_xmit.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_recv.c b/drivers/staging/r8188eu/hal/rtl8188eu_recv.c index 2e3f624d0f22..854377c9f0ab 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_recv.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_recv.c @@ -38,7 +38,7 @@ int rtl8188eu_init_recv_priv(struct adapter *padapter) struct recv_buf *precvbuf; tasklet_init(&precvpriv->recv_tasklet, - (void(*)(unsigned long))rtl8188eu_recv_tasklet, + rtl8188eu_recv_tasklet, (unsigned long)padapter); /* init recv_buf */ diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index e44a01af7f5c..b0c4f5ed8a6a 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -14,7 +14,7 @@ s32 rtl8188eu_init_xmit_priv(struct adapter *adapt) struct xmit_priv *pxmitpriv = &adapt->xmitpriv; tasklet_init(&pxmitpriv->xmit_tasklet, - (void(*)(unsigned long))rtl8188eu_xmit_tasklet, + rtl8188eu_xmit_tasklet, (unsigned long)adapt); return _SUCCESS; } diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 577090db84be..ffd2474a8760 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -459,7 +459,7 @@ static int recvbuf2recvframe(struct adapter *adapt, struct sk_buff *pskb) return _SUCCESS; } -void rtl8188eu_recv_tasklet(void *priv) +void rtl8188eu_recv_tasklet(unsigned long priv) { struct sk_buff *pskb; struct adapter *adapt = (struct adapter *)priv; @@ -649,7 +649,7 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *rmem) return ret; } -void rtl8188eu_xmit_tasklet(void *priv) +void rtl8188eu_xmit_tasklet(unsigned long priv) { int ret = false; struct adapter *adapt = (struct adapter *)priv; diff --git a/drivers/staging/r8188eu/include/rtl8188e_recv.h b/drivers/staging/r8188eu/include/rtl8188e_recv.h index bc1d532592b9..a91daf84d6c3 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_recv.h +++ b/drivers/staging/r8188eu/include/rtl8188e_recv.h @@ -44,7 +44,7 @@ void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf *buf); s32 rtl8188eu_init_recv_priv(struct adapter *padapter); void rtl8188eu_free_recv_priv(struct adapter * padapter); void rtl8188eu_recv_hdl(struct adapter * padapter, struct recv_buf *precvbuf); -void rtl8188eu_recv_tasklet(void *priv); +void rtl8188eu_recv_tasklet(unsigned long priv); void rtl8188e_query_rx_phy_status(struct recv_frame *fr, struct phy_stat *phy); void rtl8188e_process_phy_info(struct adapter * padapter, void *prframe); void update_recvframe_phyinfo_88e(struct recv_frame *fra, struct phy_stat *phy); diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h index e9b71de0d165..8adfa98f99d0 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h @@ -147,7 +147,7 @@ s32 rtl8188eu_hal_xmit(struct adapter *padapter, struct xmit_frame *frame); s32 rtl8188eu_mgnt_xmit(struct adapter *padapter, struct xmit_frame *frame); s32 rtl8188eu_xmit_buf_handler(struct adapter *padapter); #define hal_xmit_handler rtl8188eu_xmit_buf_handler -void rtl8188eu_xmit_tasklet(void *priv); +void rtl8188eu_xmit_tasklet(unsigned long priv); s32 rtl8188eu_xmitframe_complete(struct adapter *padapter, struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf); -- 2.32.0