From: Pavel Skripkin <paskripkin@gmail.com>
To: dmitry.torokhov@gmail.com, aeh@db.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Skripkin <paskripkin@gmail.com>,
syzbot+2d6d691af5ab4b7e66df@syzkaller.appspotmail.com
Subject: [PATCH] input: cm109: fix URB submitted while active
Date: Wed, 4 Aug 2021 17:58:01 +0300 [thread overview]
Message-ID: <20210804145801.2762-1-paskripkin@gmail.com> (raw)
Syzbot reported, that dev->urb_ctl was submitted while active. The
problem was in missing validation check. We should check, that dev->urb_ctl
is not pending before sumbitting it again.
Fail log:
URB 00000000cfeee59c submitted while active
WARNING: CPU: 1 PID: 8459 at drivers/usb/core/urb.c:378 usb_submit_urb+0x1271/0x1540 drivers/usb/core/urb.c:378
...
Call Trace:
<IRQ>
cm109_urb_irq_callback+0x44f/0xaa0 drivers/input/misc/cm109.c:422
__usb_hcd_giveback_urb+0x2b0/0x5c0 drivers/usb/core/hcd.c:1656
usb_hcd_giveback_urb+0x367/0x410 drivers/usb/core/hcd.c:1726
Reported-and-tested-by: syzbot+2d6d691af5ab4b7e66df@syzkaller.appspotmail.com
Fixes: c04148f915e5 ("Input: add driver for USB VoIP phones with CM109 chipset")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
drivers/input/misc/cm109.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/cm109.c b/drivers/input/misc/cm109.c
index f515fae465c3..60bddadbbe3a 100644
--- a/drivers/input/misc/cm109.c
+++ b/drivers/input/misc/cm109.c
@@ -406,7 +406,7 @@ static void cm109_urb_irq_callback(struct urb *urb)
dev->irq_urb_pending = 0;
- if (likely(!dev->shutdown)) {
+ if (likely(!dev->shutdown) && likely(!dev->ctl_urb_pending)) {
if (dev->buzzer_state)
dev->ctl_data->byte[HID_OR0] |= BUZZER_ON;
--
2.32.0
next reply other threads:[~2021-08-04 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 14:58 Pavel Skripkin [this message]
2021-08-18 11:07 ` [PATCH] input: cm109: fix URB submitted while active Pavel Skripkin
2021-09-19 17:30 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804145801.2762-1-paskripkin@gmail.com \
--to=paskripkin@gmail.com \
--cc=aeh@db.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+2d6d691af5ab4b7e66df@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).