From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 603ADC432BE for ; Wed, 4 Aug 2021 20:00:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4988F60FC4 for ; Wed, 4 Aug 2021 20:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240796AbhHDUAm (ORCPT ); Wed, 4 Aug 2021 16:00:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:50740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236868AbhHDUAl (ORCPT ); Wed, 4 Aug 2021 16:00:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DAE9860F94; Wed, 4 Aug 2021 20:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628107228; bh=37fDEXenKcoBvVVce/0Vu1DGtQohA9Ok030wcHA4o3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kA2jAtNlspXOE0DrWlXbvX5l2Q7Fb6p8Q76kWXsVxbZxBr26qvXCuGcSgycoWR8+V CRLDoTSNB292HxlV5yeeOqak0xy8fZaRFG9OYiVwrdCKJp2FDcn6ogxMo9CMdrIsze bsQABALmbqh73GfYIcGZxaT0QKyNI7DgWTsV2P5TJadwZyTnKFUc0fh8sTruNV+s4j a71IHgieMB3UOe+cijpTfz+e0UJXRMF5uxAydM+jtUD03YTJKO68A2uotRWnlEx+e/ FRXuODe7xaOu8Nhf+opgcDVi81MwLtT8XV/5uk9q1WaO33sbbKio76QMPWfWse2rh7 yWPFGyvqT0O8A== Received: by pali.im (Postfix) id 43CE777F; Wed, 4 Aug 2021 22:00:25 +0200 (CEST) Date: Wed, 4 Aug 2021 22:00:25 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andy Shevchenko Cc: Hans de Goede , Mario Limonciello , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Gross Subject: Re: [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a platform driver Message-ID: <20210804200025.iqsvknddoxix7yw7@pali> References: <20210803194039.35083-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210803194039.35083-1-andriy.shevchenko@linux.intel.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 August 2021 22:40:39 Andy Shevchenko wrote: > ACPI core in conjunction with platform driver core provides > an infrastructure to enumerate ACPI devices. Use it in order > to remove a lot of boilerplate code. Are there any other dependences for this patch? And in which kernel version is (or will be) introduced this ACPI infrastructure? > Signed-off-by: Andy Shevchenko > --- > drivers/platform/x86/dell/Kconfig | 2 +- > drivers/platform/x86/dell/dell-smo8800.c | 74 ++++++------------------ > 2 files changed, 20 insertions(+), 56 deletions(-) > > diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig > index 9e7314d90bea..821aba31821c 100644 > --- a/drivers/platform/x86/dell/Kconfig > +++ b/drivers/platform/x86/dell/Kconfig > @@ -140,7 +140,7 @@ config DELL_SMBIOS_SMM > config DELL_SMO8800 > tristate "Dell Latitude freefall driver (ACPI SMO88XX)" > default m > - depends on ACPI > + depends on ACPI || COMPILE_TEST > help > Say Y here if you want to support SMO88XX freefall devices > on Dell Latitude laptops. > diff --git a/drivers/platform/x86/dell/dell-smo8800.c b/drivers/platform/x86/dell/dell-smo8800.c > index 5d9304a7de1b..3385e852104c 100644 > --- a/drivers/platform/x86/dell/dell-smo8800.c > +++ b/drivers/platform/x86/dell/dell-smo8800.c > @@ -10,13 +10,14 @@ > > #define DRIVER_NAME "smo8800" > > -#include > -#include > -#include > +#include > #include > +#include > #include > +#include > +#include > +#include > #include > -#include > > struct smo8800_device { > u32 irq; /* acpi device irq */ > @@ -44,37 +45,6 @@ static irqreturn_t smo8800_interrupt_thread(int irq, void *data) > return IRQ_HANDLED; > } > > -static acpi_status smo8800_get_resource(struct acpi_resource *resource, > - void *context) > -{ > - struct acpi_resource_extended_irq *irq; > - > - if (resource->type != ACPI_RESOURCE_TYPE_EXTENDED_IRQ) > - return AE_OK; > - > - irq = &resource->data.extended_irq; > - if (!irq || !irq->interrupt_count) > - return AE_OK; > - > - *((u32 *)context) = irq->interrupts[0]; > - return AE_CTRL_TERMINATE; > -} > - > -static u32 smo8800_get_irq(struct acpi_device *device) > -{ > - u32 irq = 0; > - acpi_status status; > - > - status = acpi_walk_resources(device->handle, METHOD_NAME__CRS, > - smo8800_get_resource, &irq); > - if (ACPI_FAILURE(status)) { > - dev_err(&device->dev, "acpi_walk_resources failed\n"); > - return 0; > - } > - > - return irq; > -} > - > static ssize_t smo8800_misc_read(struct file *file, char __user *buf, > size_t count, loff_t *pos) > { > @@ -136,7 +106,7 @@ static const struct file_operations smo8800_misc_fops = { > .release = smo8800_misc_release, > }; > > -static int smo8800_add(struct acpi_device *device) > +static int smo8800_probe(struct platform_device *device) > { > int err; > struct smo8800_device *smo8800; > @@ -160,14 +130,12 @@ static int smo8800_add(struct acpi_device *device) > return err; > } > > - device->driver_data = smo8800; > + platform_set_drvdata(device, smo8800); > > - smo8800->irq = smo8800_get_irq(device); > - if (!smo8800->irq) { > - dev_err(&device->dev, "failed to obtain IRQ\n"); > - err = -EINVAL; > + err = platform_get_irq(device, 0); > + if (err < 0) > goto error; > - } > + smo8800->irq = err; > > err = request_threaded_irq(smo8800->irq, smo8800_interrupt_quick, > smo8800_interrupt_thread, > @@ -189,9 +157,9 @@ static int smo8800_add(struct acpi_device *device) > return err; > } > > -static int smo8800_remove(struct acpi_device *device) > +static int smo8800_remove(struct platform_device *device) > { > - struct smo8800_device *smo8800 = device->driver_data; > + struct smo8800_device *smo8800 = platform_get_drvdata(device); > > free_irq(smo8800->irq, smo8800); > misc_deregister(&smo8800->miscdev); > @@ -211,21 +179,17 @@ static const struct acpi_device_id smo8800_ids[] = { > { "SMO8831", 0 }, > { "", 0 }, > }; > - > MODULE_DEVICE_TABLE(acpi, smo8800_ids); > > -static struct acpi_driver smo8800_driver = { > - .name = DRIVER_NAME, > - .class = "Latitude", > - .ids = smo8800_ids, > - .ops = { > - .add = smo8800_add, > - .remove = smo8800_remove, > +static struct platform_driver smo8800_driver = { > + .probe = smo8800_probe, > + .remove = smo8800_remove, > + .driver = { > + .name = DRIVER_NAME, > + .acpi_match_table = smo8800_ids, > }, > - .owner = THIS_MODULE, > }; > - > -module_acpi_driver(smo8800_driver); > +module_platform_driver(smo8800_driver); > > MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO88XX)"); > MODULE_LICENSE("GPL"); > -- > 2.30.2 >