From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816A4C4320E for ; Thu, 5 Aug 2021 09:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62A9C61029 for ; Thu, 5 Aug 2021 09:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239244AbhHEJRk (ORCPT ); Thu, 5 Aug 2021 05:17:40 -0400 Received: from elvis.franken.de ([193.175.24.41]:46893 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232666AbhHEJRh (ORCPT ); Thu, 5 Aug 2021 05:17:37 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mBZV8-0005ti-01; Thu, 05 Aug 2021 11:17:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 503C5C052F; Thu, 5 Aug 2021 11:02:56 +0200 (CEST) Date: Thu, 5 Aug 2021 11:02:56 +0200 From: Thomas Bogendoerfer To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Jiaxun Yang , linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: loongson2ef: don't build serial.o unconditionally Message-ID: <20210805090256.GB5979@alpha.franken.de> References: <20210805000216.31833-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805000216.31833-1-rdunlap@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 05:02:16PM -0700, Randy Dunlap wrote: > LOONGSON_UART_BASE depends on EARLY_PRINTK || SERIAL_8250, but when > neither of these Kconfig symbols is set, the kernel build has errors: > > ../arch/mips/loongson2ef/common/serial.c: In function 'serial_init': > ../arch/mips/loongson2ef/common/serial.c:66:25: error: 'loongson_uart_base' undeclared (first use in this function) > 66 | loongson_uart_base; > ../arch/mips/loongson2ef/common/serial.c:66:25: note: each undeclared identifier is reported only once for each function it appears in > ../arch/mips/loongson2ef/common/serial.c:68:41: error: '_loongson_uart_base' undeclared (first use in this function) > 68 | (void __iomem *)_loongson_uart_base; > > Fix this by building serial.o only when one (or both) of these > Kconfig symbols is enabled. > > Tested with: > (a) EARLY_PRINTK=y, SERIAL_8250 not set; > (b) EARLY_PRINTK=y, SERIAL_8250=y; > (c) EARLY_PRINTK=y, SERIAL_8250=m. > (d) EARLY_PRINTK not set, SERIAL_8250=y; > (e) EARLY_PRINTK not set, SERIAL_8250=m; > (f) EARLY_PRINTK not set, SERIAL_8250 not set. > > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Jiaxun Yang > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > --- > arch/mips/loongson2ef/common/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]