From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F116AC4320A for ; Thu, 5 Aug 2021 09:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6F1961029 for ; Thu, 5 Aug 2021 09:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239132AbhHEJHS (ORCPT ); Thu, 5 Aug 2021 05:07:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43805 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239010AbhHEJHQ (ORCPT ); Thu, 5 Aug 2021 05:07:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628154422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KYnPAindt7gqrNcKUm5J79oEdrV+LI995OyYx3zHpCI=; b=C0haqXC85luvlxWQg0bM6Cg30vZZRKzlrRweSOw2SsNpNvtz6hvOhJWLUmcQPN5QAY72rL /t8MCbG9wggeRfpEtX5riB2xltwUIXQDDpBPIiZfytJDfg1ciRVUDYjzfI9WPuqsWXBpCo aQ/8vbenLvO27rpbAncxw7OEfck1wDY= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-dOXYKKWRN6unVeuw-e_wSA-1; Thu, 05 Aug 2021 05:07:01 -0400 X-MC-Unique: dOXYKKWRN6unVeuw-e_wSA-1 Received: by mail-ej1-f70.google.com with SMTP id a17-20020a1709062b11b02905882d7951afso1818932ejg.4 for ; Thu, 05 Aug 2021 02:07:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KYnPAindt7gqrNcKUm5J79oEdrV+LI995OyYx3zHpCI=; b=b+pNqNI+lVMjWgy04rNbT/86SKZq4l9ZYWoyBa889uWZnswRseWHle2aQxxAM8osMi ztJU9HAD9pNIL7dG//MTOWRRGnddLJJ9kbxpqXJJhyLf1rfSh+E0HG6fyW2ARFtoFPXi HtfrL9GDMHSH+DzUMUhiYXqxVGDgEPtUHP2/jk9OWmNJoAGQEx41nS9z8MRlSR6AN9fs 4yEE/r4c9K+tlFar1fSy35cmiNPHXGl8FldN+1XrBmxi0QXCcOytv0Z85nKMKlH5A53I pEy6nbnjN+dn3ljE6qy2+HUozDQX2LM0V6xcCGlztsQTP6jNflucNTZqo4DnDSWrckB/ ugKQ== X-Gm-Message-State: AOAM530qS6y1/gXb8/gPcgpMERAEVjoDrtP2PtpCUUzOPP/UBYnqwy7d tba0c4aOp+waRBmj6slpwAzzYSed3BP4dR4PDJrvsBLE0/PWAkbhmUdET0zNKXrB1KgwHGvrbsL q569xEJWpL00cfgtOTIJ+jU1t X-Received: by 2002:a05:6402:6cb:: with SMTP id n11mr5231283edy.112.1628154420098; Thu, 05 Aug 2021 02:07:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAbJ7jQEOwJQWtXjn6en2nBVwYWl56AzaGjrhqay1J4fO2ol2L+YJReWWqxkCDxYEG9cHRUg== X-Received: by 2002:a05:6402:6cb:: with SMTP id n11mr5231265edy.112.1628154419930; Thu, 05 Aug 2021 02:06:59 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id b25sm2018211edv.9.2021.08.05.02.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 02:06:59 -0700 (PDT) Date: Thu, 5 Aug 2021 11:06:57 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Colin Ian King , Andra Paraschiv , Norbert Slusarek , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "oxffffaa@gmail.com" Subject: Re: [RFC PATCH v1 0/7] virtio/vsock: introduce MSG_EOR flag for SEQPACKET Message-ID: <20210805090657.y2sz3pzhruuolncq@steredhat> References: <20210726163137.2589102-1-arseny.krasnov@kaspersky.com> <20210804125737.kbgc6mg2v5lw25wu@steredhat> <8e44442c-4cac-dcbc-a88d-17d9878e7d32@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <8e44442c-4cac-dcbc-a88d-17d9878e7d32@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 05, 2021 at 11:33:12AM +0300, Arseny Krasnov wrote: > >On 04.08.2021 15:57, Stefano Garzarella wrote: >> Caution: This is an external email. Be cautious while opening links or attachments. >> >> >> >> Hi Arseny, >> >> On Mon, Jul 26, 2021 at 07:31:33PM +0300, Arseny Krasnov wrote: >>> This patchset implements support of MSG_EOR bit for SEQPACKET >>> AF_VSOCK sockets over virtio transport. >>> Idea is to distinguish concepts of 'messages' and 'records'. >>> Message is result of sending calls: 'write()', 'send()', 'sendmsg()' >>> etc. It has fixed maximum length, and it bounds are visible using >>> return from receive calls: 'read()', 'recv()', 'recvmsg()' etc. >>> Current implementation based on message definition above. >> Okay, so the implementation we merged is wrong right? >> Should we disable the feature bit in stable kernels that contain it? Or >> maybe we can backport the fixes... > >Hi, > >No, this is correct and it is message boundary based. Idea of this >patchset is to add extra boundaries marker which i think could be >useful when we want to send data in seqpacket mode which length >is bigger than maximum message length(this is limited by transport). >Of course we can fragment big piece of data too small messages, but >this >requires to carry fragmentation info in data protocol. So In this case >when we want to maintain boundaries receiver calls recvmsg() until >MSG_EOR found. >But when receiver knows, that data is fit in maximum datagram length, >it doesn't care about checking MSG_EOR just calling recv() or >read()(e.g. >message based mode). I'm not sure we should maintain boundaries of multiple send(), from POSIX standard [1]: SOCK_SEQPACKET Provides sequenced, reliable, bidirectional, connection-mode transmission paths for records. A record can be sent using one or more output operations and received using one or more input operations, but a single operation never transfers part of more than one record. Record boundaries are visible to the receiver via the MSG_EOR flag. From my understanding a record could be sent with multiple send() and received, for example, with a single recvmsg(). The only boundary should be the MSG_EOR flag set by the user on the last send() of a record. From send() description [2]: MSG_EOR Terminates a record (if supported by the protocol). From recvmsg() description [3]: MSG_EOR End-of-record was received (if supported by the protocol). Thanks, Stefano [1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/socket.html [2] https://pubs.opengroup.org/onlinepubs/9699919799/functions/send.html [3] https://pubs.opengroup.org/onlinepubs/9699919799/functions/recvmsg.html