From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP)
Date: Thu, 5 Aug 2021 14:53:53 +0100 [thread overview]
Message-ID: <20210805135353.GB22410@lpieralisi> (raw)
In-Reply-To: <20210623140103.47818-2-andriy.shevchenko@linux.intel.com>
On Wed, Jun 23, 2021 at 05:01:03PM +0300, Andy Shevchenko wrote:
> The "depends on" is no-op in the selectable options.
Same as in patch one, spell out what "depends on" you are referring
to - please make this log more descriptive.
Thanks,
Lorenzo
>
> Clean up the users of PCIE_DW_EP and introduce idiom
>
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
>
> for all of them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/controller/dwc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 9bfd41eadd5e..ca5de4e40fbe 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -12,7 +12,6 @@ config PCIE_DW_HOST
>
> config PCIE_DW_EP
> bool
> - depends on PCI_ENDPOINT
> select PCIE_DW
>
> config PCI_DRA7XX
> @@ -37,8 +36,8 @@ config PCI_DRA7XX_HOST
> config PCI_DRA7XX_EP
> bool "TI DRA7xx PCIe controller Endpoint Mode"
> depends on SOC_DRA7XX || COMPILE_TEST
> - depends on PCI_ENDPOINT
> depends on OF && HAS_IOMEM && TI_PIPE3
> + depends on PCI_ENDPOINT
> select PCIE_DW_EP
> select PCI_DRA7XX
> help
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-08-05 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:01 [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
2021-06-23 14:01 ` [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP) Andy Shevchenko
2021-08-05 13:53 ` Lorenzo Pieralisi [this message]
2021-07-12 14:00 ` [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
2021-08-05 13:52 ` Lorenzo Pieralisi
2021-08-05 16:35 ` Andy Shevchenko
2021-08-10 16:59 ` Lorenzo Pieralisi
2021-10-05 9:36 ` Lorenzo Pieralisi
2021-10-05 12:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805135353.GB22410@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).