linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] power: supply: sc27xx: Delete superfluous error message
@ 2021-08-05 12:52 Tang Bin
  2021-08-05 15:59 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-08-05 12:52 UTC (permalink / raw)
  To: sre, orsonzhai, baolin.wang7, zhang.lyra; +Cc: linux-pm, linux-kernel, Tang Bin

In the function sc27xx_fgu_probe(), when get irq failed,
platform_get_irq() logs an error message, so remove
redundant message here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/power/supply/sc27xx_fuel_gauge.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/supply/sc27xx_fuel_gauge.c b/drivers/power/supply/sc27xx_fuel_gauge.c
index 9c627618c..5e7f7a19e 100644
--- a/drivers/power/supply/sc27xx_fuel_gauge.c
+++ b/drivers/power/supply/sc27xx_fuel_gauge.c
@@ -1229,10 +1229,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "no irq resource specified\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	ret = devm_request_threaded_irq(data->dev, irq, NULL,
 					sc27xx_fgu_interrupt,
-- 
2.20.1.windows.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: supply: sc27xx: Delete superfluous error message
  2021-08-05 12:52 [PATCH] power: supply: sc27xx: Delete superfluous error message Tang Bin
@ 2021-08-05 15:59 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2021-08-05 15:59 UTC (permalink / raw)
  To: Tang Bin; +Cc: orsonzhai, baolin.wang7, zhang.lyra, linux-pm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

Hi,

On Thu, Aug 05, 2021 at 08:52:33PM +0800, Tang Bin wrote:
> In the function sc27xx_fgu_probe(), when get irq failed,
> platform_get_irq() logs an error message, so remove
> redundant message here.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---

Thanks, queued.

--Sebastian

>  drivers/power/supply/sc27xx_fuel_gauge.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/sc27xx_fuel_gauge.c b/drivers/power/supply/sc27xx_fuel_gauge.c
> index 9c627618c..5e7f7a19e 100644
> --- a/drivers/power/supply/sc27xx_fuel_gauge.c
> +++ b/drivers/power/supply/sc27xx_fuel_gauge.c
> @@ -1229,10 +1229,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
>  	}
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "no irq resource specified\n");
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	ret = devm_request_threaded_irq(data->dev, irq, NULL,
>  					sc27xx_fgu_interrupt,
> -- 
> 2.20.1.windows.1
> 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-05 15:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 12:52 [PATCH] power: supply: sc27xx: Delete superfluous error message Tang Bin
2021-08-05 15:59 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).