From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-remoteproc@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
ohad@wizery.com
Subject: Re: [PATCH v3 2/2] remoteproc: meson-mx-ao-arc: Add a driver for the AO ARC remote procesor
Date: Thu, 5 Aug 2021 10:15:06 -0600 [thread overview]
Message-ID: <20210805161506.GA3205691@p14s> (raw)
In-Reply-To: <CAFBinCB0-bAa7Y+YhscczarGrGuio37F8vRyfW6U2DiiDAvr-g@mail.gmail.com>
On Wed, Aug 04, 2021 at 11:03:57PM +0200, Martin Blumenstingl wrote:
> Hi Mathieu,
>
> thanks for taking the time to look into this!
>
> (I will address any of your comments that I am not mentioning in this
> email anymore. Thanks a lot for the suggestions!)
>
> On Wed, Jul 28, 2021 at 7:58 PM Mathieu Poirier
> <mathieu.poirier@linaro.org> wrote:
> [...]
> > > + writel(FIELD_PREP(AO_REMAP_REG0_REMAP_AHB_SRAM_BITS_17_14_FOR_ARM_CPU,
> > > + priv->sram_pa >> 14),
> > Indentation problem
> The idea here is to align priv->sram_pa with AO_REMAP_REG0... which
> are both arguments to FIELD_PREP
Right, this is what I would have expected. When I applied the patch on my side
"priv->sram_pa ..." was aligned wiht the 'M' of "AO_REMAP_ ...".
> Maybe using something like this will make that easier to read:
> tmp = FIELD_PREP(AO_REMAP_REG0_REMAP_AHB_SRAM_BITS_17_14_FOR_ARM_CPU,
> priv->sram_pa >> 14);
> writel(tmp, priv->remap_base + AO_REMAP_REG0);
I think the main problem is that
AO_REMAP_REG0_REMAP_AHB_SRAM_BITS_17_14_FOR_ARM_CPU is simply too long. I
suggest making is shorter and add a comment to describe exactly what it does.
>
> What do you think: leave it as is or use a separate variable?
>
> [...]
> > > + usleep_range(10, 100);
> >
> > I've seen this kind of mysterious timeouts in other patchset based vendor trees.
> > You likely don't know why it is needed so I won't ask.
> unfortunately this is also the case here
>
> [...]
> > > + priv->arc_reset = devm_reset_control_get_exclusive(dev, NULL);
> > > + if (IS_ERR(priv->arc_reset)) {
> >
> > Function __reset_control_get() in __devm_reset_control_get() can return NULL so
> > this should be IS_ERR_OR_NULL().
> The logic in there is: return optional ? NULL : ERR_PTR(-...);
Ok, so you meant to do that. And I just checked reset_control_reset() and it does
account for a NULL parameter. I'm good with this one but add a comment to
make sure future readers don't think you've omitted to properly deal with the
NULL return value.
> I am requesting a mandatory reset line here, so reset core will never
> return NULL
> See also [0]
Indeed, I've read that too. Nonetheless __reset_control_get() can return NULL
by way of __reset_control_get_from_lookup().
>
> For this reason I am not planning to change this
>
> [...]
> > This driver is squeaky clean. With the above:
> >
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> awesome, thank you!
>
>
> Best regards,
> Martin
>
>
> [0] https://elixir.bootlin.com/linux/v5.14-rc4/source/include/linux/reset.h#L227
next prev parent reply other threads:[~2021-08-05 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 23:48 [PATCH v3 0/2] Amlogic Meson Always-On ARC remote-processor support Martin Blumenstingl
2021-07-17 23:48 ` [PATCH v3 1/2] dt-bindings: remoteproc: Add the documentation for Meson AO ARC rproc Martin Blumenstingl
2021-07-17 23:48 ` [PATCH v3 2/2] remoteproc: meson-mx-ao-arc: Add a driver for the AO ARC remote procesor Martin Blumenstingl
2021-07-28 17:58 ` Mathieu Poirier
2021-08-04 21:03 ` Martin Blumenstingl
2021-08-05 16:15 ` Mathieu Poirier [this message]
2021-08-08 20:36 ` Martin Blumenstingl
2021-08-10 13:36 ` Mathieu Poirier
2021-08-23 15:29 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805161506.GA3205691@p14s \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).