From: Andrew Morton <akpm@linux-foundation.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: Shakeel Butt <shakeelb@google.com>,
SeongJae Park <sjpark@amazon.de>,
Jonathan.Cameron@huawei.com, amit@kernel.org,
Jonathan Corbet <corbet@lwn.net>,
David Hildenbrand <david@redhat.com>,
dwmw@amazon.com, foersleo@amazon.de,
Greg Thelen <gthelen@google.com>,
jgowans@amazon.com, mheyne@amazon.de,
David Rientjes <rientjes@google.com>,
sieberf@amazon.com, Vlastimil Babka <vbabka@suse.cz>,
linux-damon@amazon.com, Linux MM <linux-mm@kvack.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Wei Xu <weixugc@google.com>, Paul Turner <pjt@google.com>,
Yu Zhao <yuzhao@google.com>, Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v34 00/13] Introduce Data Access MONitor (DAMON)
Date: Thu, 5 Aug 2021 17:03:44 -0700 [thread overview]
Message-ID: <20210805170344.afbf5f1ceb00eb212082ca7b@linux-foundation.org> (raw)
In-Reply-To: <20210728083643.5873-1-sjpark@amazon.de>
On Wed, 28 Jul 2021 08:36:43 +0000 SeongJae Park <sj38.park@gmail.com> wrote:
> > DAMON does not expose stable APIs at the moment, so these can
> > be changed later if needed. I think it is ok to merge DAMON for some
> > exposure. However I do want to make this clear that the solution space
> > is not complete. The solution of system level monitoring is still
> > needed which can be a future extension to DAMON or more generalized
> > Multigen LRU.
>
> Agreed. We have lots more works to do. Some of those are already posted as
> RFC patchsets[1,2,3,4]. I promise I will happily do the works. But, how dare
> could only I get all the fun? I'd like to do that together with others in this
> great community. One major purpose of this patchset is thus providing a
> flexible framework for such collaboration. The virtual address space
> monitoring, which this patchset provides in addition to the framework, is also
> for real-world usages, though.
>
> Now all the patches have at least one 'Reviewed-by:' or 'Acked-by:' tags. We
> didn't find serious problems since v26[5], which was posted about four months
> ago. so I'm thinking this patchset has passed the minimum qualification. If
> you think there are more things to be done before this patchset is merged in
> the -mm tree or mainline, please let me know. If not, Andrew, I'd like you to
> consider merging this patchset into '-mm' tree.
Shall take a look. With some trepidation.
1-2 years from now someone will pop up with a massive patchset
implementing some monitoring scheme and we'll say "why didn't you use
DAMON" and they'll say "it's unsuitable for <reasons>".
I would like to see more thought/design go into how DAMON could be
modified to address Shakeel's other three requirements. At least to
the point where we can confidently say "yes, we will be able to do
this". Are you able to drive this discussion along please?
next prev parent reply other threads:[~2021-08-06 0:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 8:14 [PATCH v34 00/13] Introduce Data Access MONitor (DAMON) SeongJae Park
2021-07-16 8:14 ` [PATCH v34 01/13] mm: " SeongJae Park
2021-07-16 8:14 ` [PATCH v34 02/13] mm/damon/core: Implement region-based sampling SeongJae Park
2021-07-16 8:14 ` [PATCH v34 03/13] mm/damon: Adaptively adjust regions SeongJae Park
2021-07-16 8:14 ` [PATCH v34 04/13] mm/idle_page_tracking: Make PG_idle reusable SeongJae Park
2021-07-16 8:14 ` [PATCH v34 05/13] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2021-08-26 14:09 ` David Hildenbrand
2021-08-26 17:29 ` SeongJae Park
2021-08-26 21:42 ` David Hildenbrand
2021-08-27 11:06 ` SeongJae Park
2021-07-16 8:14 ` [PATCH v34 06/13] mm/damon: Add a tracepoint SeongJae Park
2021-07-16 8:14 ` [PATCH v34 07/13] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2021-08-06 0:43 ` Andrew Morton
2021-08-06 11:46 ` SeongJae Park
2021-08-06 0:43 ` Andrew Morton
2021-08-06 11:47 ` SeongJae Park
2021-07-16 8:14 ` [PATCH v34 08/13] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2021-07-16 8:14 ` [PATCH v34 09/13] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2021-07-16 8:14 ` [PATCH v34 10/13] Documentation: Add documents for DAMON SeongJae Park
2021-07-16 8:14 ` [PATCH v34 11/13] mm/damon: Add kunit tests SeongJae Park
2021-07-16 8:14 ` [PATCH v34 12/13] mm/damon: Add user space selftests SeongJae Park
2021-07-16 8:14 ` [PATCH v34 13/13] MAINTAINERS: Update for DAMON SeongJae Park
2021-07-27 21:30 ` [PATCH v34 00/13] Introduce Data Access MONitor (DAMON) Shakeel Butt
2021-07-28 8:36 ` SeongJae Park
2021-08-02 8:24 ` SeongJae Park
2021-08-04 7:41 ` SeongJae Park
2021-08-06 0:03 ` Andrew Morton [this message]
2021-08-06 11:48 ` SeongJae Park
2021-08-09 14:07 ` SeongJae Park
2021-08-06 0:43 ` Andrew Morton
2021-08-06 11:48 ` SeongJae Park
2021-08-07 18:28 ` Andrew Morton
2021-07-23 7:02 Dongjoo Seo
2021-07-23 7:08 ` Greg KH
2021-07-23 7:16 ` Dongjoo Seo
2021-07-23 7:30 ` Greg KH
2021-07-23 7:51 ` Dongjoo Seo
2021-07-23 8:30 ` SeongJae Park
2021-07-23 8:40 ` SeongJae Park
2021-07-26 13:32 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805170344.afbf5f1ceb00eb212082ca7b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=amit@kernel.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=foersleo@amazon.de \
--cc=gthelen@google.com \
--cc=jgowans@amazon.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mheyne@amazon.de \
--cc=pjt@google.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=sieberf@amazon.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).