archive mirror
 help / color / mirror / Atom feed
From: DENG Qingfang <>
To: Vladimir Oltean <>
Cc: Sean Wang <>,
	Landen Chao <>,
	Andrew Lunn <>,
	Vivien Didelot <>,
	Florian Fainelli <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,
	Matthias Brugger <>,,,,
Subject: Re: [PATCH net-next] net: dsa: mt7530: drop untagged frames on VLAN-aware ports without PVID
Date: Fri,  6 Aug 2021 10:34:23 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20210806001740.cayorz3vlfrvk75l@skbuf>

On Fri, Aug 06, 2021 at 03:17:40AM +0300, Vladimir Oltean wrote:
> Good catch with this condition, sja1105 and ocelot are buggy in this
> regard, it seems, probably others too. Need to fix them. Although
> honestly I would probably rather spend the time patching the bridge
> already to not accept duplicate VLAN entries from user space, just with
> different flags, it's just too complex to handle the overwrites everywhere...
> Plus, bridge accepting duplicate VLANs means we cannot refcount them on
> DSA and CPU ports at the cross-chip level, which in turn means we can
> never delete them from those ports.
> Anyhow, enough rambling.
> Reviewed-by: Vladimir Oltean <>

Please allow me to send a v2. This sets the CPU port's PVID to 0
on boot, which causes some undefined behaviour..

      reply	other threads:[~2021-08-06  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 17:23 [PATCH net-next] net: dsa: mt7530: drop untagged frames on VLAN-aware ports without PVID DENG Qingfang
2021-08-06  0:17 ` Vladimir Oltean
2021-08-06  2:34   ` DENG Qingfang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).