From: Herbert Xu <herbert@gondor.apana.org.au>
To: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>
Cc: davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+20191dc583eff8602d2d@syzkaller.appspotmail.com
Subject: Re: [PATCH] crypto: add missing kernel_fpu_end() call
Date: Fri, 6 Aug 2021 16:23:20 +0800 [thread overview]
Message-ID: <20210806082320.GA12731@gondor.apana.org.au> (raw)
In-Reply-To: <20210730134155.1005358-1-chouhan.shreyansh630@gmail.com>
On Fri, Jul 30, 2021 at 07:11:55PM +0530, Shreyansh Chouhan wrote:
> xts_crypt() code doesn't call kernel_fpu_end() after calling
> kernel_fpu_begin() if walk.nbytes is 0. Add a call to kernel_fpu_end()
> for this case.
>
> Reported-by: syzbot+20191dc583eff8602d2d@syzkaller.appspotmail.com
> Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
> ---
> arch/x86/crypto/aesni-intel_glue.c | 3 +++
> 1 file changed, 3 insertions(+)
Ard?
> diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c
> index 2144e54a6c89..bd55a0cd7bde 100644
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -894,6 +894,9 @@ static int xts_crypt(struct skcipher_request *req, bool encrypt)
> kernel_fpu_begin();
> }
>
> + if (walk.nbytes == 0)
> + kernel_fpu_end();
> +
> if (unlikely(tail > 0 && !err)) {
> struct scatterlist sg_src[2], sg_dst[2];
> struct scatterlist *src, *dst;
> --
> 2.31.1
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-08-06 8:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 13:41 Shreyansh Chouhan
2021-08-06 8:23 ` Herbert Xu [this message]
2021-08-06 9:05 ` Ard Biesheuvel
2021-08-06 9:07 ` Ard Biesheuvel
2021-08-06 10:36 ` Shreyansh Chouhan
2021-08-09 14:10 ` [PATCH] crypto: xts_crypt() return if walk.nbytes is 0 Shreyansh Chouhan
2021-08-17 14:18 ` Ard Biesheuvel
2021-08-20 8:31 ` Herbert Xu
2021-08-20 11:14 ` Ard Biesheuvel
2021-08-20 12:53 ` Herbert Xu
2021-08-22 3:45 ` [PATCH v2] " Shreyansh Chouhan
2021-08-27 8:38 ` Herbert Xu
2021-08-22 3:48 ` [PATCH] " Shreyansh Chouhan
2021-08-22 13:23 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806082320.GA12731@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=chouhan.shreyansh630@gmail.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=syzbot+20191dc583eff8602d2d@syzkaller.appspotmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--subject='Re: [PATCH] crypto: add missing kernel_fpu_end() call' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).