From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dario Binacchi <dariobin@libero.it>
Cc: linux-kernel@vger.kernel.org,
Gianluca Falavigna <gianluca.falavigna@inwind.it>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 4/4] can: c_can: cache frames to operate as a true FIFO
Date: Fri, 6 Aug 2021 11:36:58 +0200 [thread overview]
Message-ID: <20210806093658.rvzw7zycrmyp4msp@pengutronix.de> (raw)
In-Reply-To: <20210805201900.23146-5-dariobin@libero.it>
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
On 05.08.2021 22:19:00, Dario Binacchi wrote:
> As reported by a comment in the c_can_start_xmit() this was not a FIFO.
> C/D_CAN controller sends out the buffers prioritized so that the lowest
> buffer number wins.
>
> What did c_can_start_xmit() do if head was less tail in the tx ring ? It
> waited until all the frames queued in the FIFO was actually transmitted
> by the controller before accepting a new CAN frame to transmit, even if
> the FIFO was not full, to ensure that the messages were transmitted in
> the order in which they were loaded.
>
> By storing the frames in the FIFO without requiring its transmission, we
> will be able to use the full size of the FIFO even in cases such as the
> one described above. The transmission interrupt will trigger their
> transmission only when all the messages previously loaded but stored in
> less priority positions of the buffers have been transmitted.
>
> Suggested-by: Gianluca Falavigna <gianluca.falavigna@inwind.it>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
My review from
https://lore.kernel.org/linux-can/20210806092523.hij5ejjq6wecbgfr@pengutronix.de/
applies here, too.
Please use IF_RX in c_can_do_tx(), remove the spin_lock and test. After
applying your series, I'll send a patch that changes IF_RX into IF_NAPI
to avoid any further confusion.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-08-06 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 20:18 [PATCH v2 0/4] can: c_can: cache frames to operate as a true FIFO Dario Binacchi
2021-08-05 20:18 ` [PATCH v2 1/4] can: c_can: remove struct c_can_priv::priv field Dario Binacchi
2021-08-05 20:18 ` [PATCH v2 2/4] can: c_can: exit c_can_do_tx() early if no frames have been sent Dario Binacchi
2021-08-05 20:18 ` [PATCH v2 3/4] can: c_can: support tx ring algorithm Dario Binacchi
2021-08-05 20:19 ` [PATCH v2 4/4] can: c_can: cache frames to operate as a true FIFO Dario Binacchi
2021-08-06 9:36 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806093658.rvzw7zycrmyp4msp@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=dariobin@libero.it \
--cc=davem@davemloft.net \
--cc=gianluca.falavigna@inwind.it \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).