From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3640AC4338F for ; Fri, 6 Aug 2021 20:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18F3960F25 for ; Fri, 6 Aug 2021 20:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244482AbhHFUD1 (ORCPT ); Fri, 6 Aug 2021 16:03:27 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50239 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244463AbhHFUD0 (ORCPT ); Fri, 6 Aug 2021 16:03:26 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 93F4E1BF204; Fri, 6 Aug 2021 20:03:09 +0000 (UTC) From: Miquel Raynal To: Daniel Palmer , miquel.raynal@bootlin.com, richard@nod.at Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mtd: spinand: core: Properly fill the OOB area. Date: Fri, 6 Aug 2021 22:03:08 +0200 Message-Id: <20210806200309.393655-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210617110842.2358461-1-daniel@0x0f.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'df12a75a2be915e7c419707bc71fba0fa7548d81' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-06-17 at 11:08:42 UTC, Daniel Palmer wrote: > The comment in spinand_write_to_cache_op() says that > spinand_ondie_ecc_prepare_io_req() should 0xff fill the OOB > area but it doesn't. > > This causes the OOB area to get filled with zeros > and anytime the first page in a block the bad block marker > is cleared and it becomes a bad block on the next boot. > > This was observed on Longsys FORSEE branded parts and > might be specific to these parts. > > Signed-off-by: Daniel Palmer Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel