From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B92C4320A for ; Fri, 6 Aug 2021 19:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36C136113B for ; Fri, 6 Aug 2021 19:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243454AbhHFTCG convert rfc822-to-8bit (ORCPT ); Fri, 6 Aug 2021 15:02:06 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:56483 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232601AbhHFTCF (ORCPT ); Fri, 6 Aug 2021 15:02:05 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6F22E40008; Fri, 6 Aug 2021 19:01:47 +0000 (UTC) Date: Fri, 6 Aug 2021 21:01:46 +0200 From: Miquel Raynal To: Apurva Nandan Cc: Richard Weinberger , Vignesh Raghavendra , Mark Brown , Patrice Chotard , Boris Brezillon , , , , Pratyush Yadav Subject: Re: [PATCH 08/13] mtd: spinand: Reject 8D-8D-8D op_templates if octal_dtr_enale() is missing in manufacturer_op Message-ID: <20210806210146.3358a85b@xps13> In-Reply-To: <20210713130538.646-9-a-nandan@ti.com> References: <20210713130538.646-1-a-nandan@ti.com> <20210713130538.646-9-a-nandan@ti.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Apurva, Apurva Nandan wrote on Tue, 13 Jul 2021 13:05:33 +0000: > The SPI NAND core doesn't know how to switch the flash to Octal DTR > mode (i.e. which operations to perform). If the manufacturer hasn't > implemented the octal_dtr_enable() manufacturer_op, the SPI NAND core > wouldn't be able to switch to 8D-8D-8D mode and will also not be able > to run in 1S-1S-1S mode due to already selected 8D-8D-8D read/write > cache op_templates. > > So, avoid choosing a Octal DTR SPI op_template for read_cache, > write_cache and update_cache operations, if the manufacturer_op > octal_dtr_enable() is missing. After looking at your previous commit I don't see why this patch would be needed. octal_dtr_enable() only updates the mode when it succeeds so I don't think this patch is really needed. > > Signed-off-by: Apurva Nandan > --- > drivers/mtd/nand/spi/core.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 19d8affac058..8711e887b795 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -1028,6 +1028,8 @@ static int spinand_manufacturer_match(struct spinand_device *spinand, > if (id[0] != manufacturer->id) > continue; > > + spinand->manufacturer = manufacturer; > + > ret = spinand_match_and_init(spinand, > manufacturer->chips, > manufacturer->nchips, > @@ -1035,7 +1037,6 @@ static int spinand_manufacturer_match(struct spinand_device *spinand, > if (ret < 0) > continue; > > - spinand->manufacturer = manufacturer; > return 0; > } > return -ENOTSUPP; > @@ -1097,6 +1098,10 @@ spinand_select_op_variant(struct spinand_device *spinand, > unsigned int nbytes; > int ret; > > + if (spinand_op_is_octal_dtr(&op) && > + !spinand->manufacturer->ops->octal_dtr_enable) > + continue; > + > nbytes = nanddev_per_page_oobsize(nand) + > nanddev_page_size(nand); > Thanks, Miquèl