From: Len Baker <len.baker@gmx.com>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: Len Baker <len.baker@gmx.com>, Kees Cook <keescook@chromium.org>,
David Laight <David.Laight@ACULAB.COM>,
Robin Murphy <robin.murphy@arm.com>,
linux-hardening@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/3] drivers/soc: Remove all strcpy() uses
Date: Sun, 8 Aug 2021 14:50:09 +0200 [thread overview]
Message-ID: <20210808125012.4715-1-len.baker@gmx.com> (raw)
strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors. So use strscpy() or memcpy() as a safe
replacement.
This is a task of the KSPP [1].
Changelog v1 -> v2
- Change the "area_name_size" variable for a shorter name (Geert
Uytterhoeven).
- Add the "Reviewed-by: Geert Uytterhoeven" tag.
- Use the memcpy function instead of strscpy function when the
size of the destination buffer cannot be obtained with "sizeof"
(David Laight, Robin Murphy).
Changelog v2 -> v3
- Remove the "Reviewed-by: Geert Uytterhoeven" tag since the code
has changed after the v1 review (use of memcpy instead of
strscpy).
Changelog v3 -> v4
- Split the changes in 3 commits (Bjorn Andersson).
- Don't break a long line (Bjorn Andersson).
- Reword the commit when used the memcpy function (Bjorn Andersson)
The previous version can be found here [2].
[1] https://github.com/KSPP/linux/issues/88
[2] https://lore.kernel.org/linux-hardening/20210801131958.6144-1-len.baker@gmx.com/
Len Baker (3):
drivers/soc/qcom: Prefer strscpy over strcpy
drivers/soc/renesas: Prefer memcpy over strcpy
drivers/soc/ti: Prefer strscpy over strcpy
drivers/soc/qcom/pdr_interface.c | 12 ++++++------
drivers/soc/renesas/r8a779a0-sysc.c | 6 ++++--
drivers/soc/renesas/rcar-sysc.c | 6 ++++--
drivers/soc/ti/knav_dma.c | 2 +-
4 files changed, 15 insertions(+), 11 deletions(-)
--
2.25.1
next reply other threads:[~2021-08-08 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 12:50 Len Baker [this message]
2021-08-08 12:50 ` [PATCH v4 1/3] drivers/soc/qcom: Prefer strscpy over strcpy Len Baker
2021-08-08 12:50 ` [PATCH v4 2/3] drivers/soc/renesas: Prefer memcpy " Len Baker
2021-08-08 15:35 ` Bernd Petrovitsch
2021-08-08 17:06 ` Christophe JAILLET
2021-08-10 15:59 ` Len Baker
2021-08-11 9:38 ` Geert Uytterhoeven
2021-08-08 12:50 ` [PATCH v4 3/3] drivers/soc/ti: Prefer strscpy " Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808125012.4715-1-len.baker@gmx.com \
--to=len.baker@gmx.com \
--cc=David.Laight@ACULAB.COM \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=geert+renesas@glider.be \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robin.murphy@arm.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).