From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Igor Skalkin <igor.skalkin@opensynergy.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Peter Hilber <peter.hilber@opensynergy.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: fix boolconv.cocci warnings
Date: Sun, 8 Aug 2021 16:07:41 +0100 [thread overview]
Message-ID: <20210808150741.GW6592@e120937-lin> (raw)
In-Reply-To: <20210807173127.GA43248@a24dbc127934>
On Sun, Aug 08, 2021 at 01:31:27AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> drivers/firmware/arm_scmi/virtio.c:225:40-45: WARNING: conversion to bool not needed here
>
> Remove unneeded conversion to bool
>
> Semantic patch information:
> Relational and logical operators evaluate to bool,
> explicit conversion is overly verbose and unneeded.
>
> Generated by: scripts/coccinelle/misc/boolconv.cocci
>
> CC: Igor Skalkin <igor.skalkin@opensynergy.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git for-next/scmi
> head: 1e7cbfaa66d39e78bd24df0c78b55df68176b59e
> commit: 46abe13b5e3db187e52cd0de06c07bbce010726c [23/24] firmware: arm_scmi: Add virtio transport
> :::::: branch date: 2 days ago
> :::::: commit date: 2 days ago
>
> virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/firmware/arm_scmi/virtio.c
> +++ b/drivers/firmware/arm_scmi/virtio.c
> @@ -222,7 +222,7 @@ static bool virtio_chan_available(struct
> return false;
> }
>
> - return vioch && !vioch->cinfo ? true : false;
> + return vioch && !vioch->cinfo;
> }
>
> static int virtio_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,o
Hi Sudeep,
this seems obviously right, would you pick it up as it is on top of
for-next/scmi when you have time ?
Thanks,
Cristian
next prev parent reply other threads:[~2021-08-08 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 17:31 [skn:for-next/scmi 23/24] drivers/firmware/arm_scmi/virtio.c:225:40-45: WARNING: conversion to bool not needed here kernel test robot
2021-08-07 17:31 ` [PATCH] firmware: arm_scmi: fix boolconv.cocci warnings kernel test robot
2021-08-08 15:07 ` Cristian Marussi [this message]
2021-08-09 5:08 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808150741.GW6592@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=igor.skalkin@opensynergy.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peter.hilber@opensynergy.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).