From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D110C4338F for ; Sun, 8 Aug 2021 15:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5022760F35 for ; Sun, 8 Aug 2021 15:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbhHHPEG (ORCPT ); Sun, 8 Aug 2021 11:04:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:46892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231137AbhHHPEB (ORCPT ); Sun, 8 Aug 2021 11:04:01 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 895416054E; Sun, 8 Aug 2021 15:03:39 +0000 (UTC) Date: Sun, 8 Aug 2021 16:06:28 +0100 From: Jonathan Cameron To: Puranjay Mohan Cc: Michael.Hennerich@analog.com, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, lars@metafoo.de, Dragos.Bogdan@analog.com, Darius.Berghe@analog.com, robh+dt@kernel.org Subject: Re: [PATCH v8 1/3] dt-bindings: iio: accel: Add DT binding doc for ADXL355 Message-ID: <20210808160628.7b031948@jic23-huawei> In-Reply-To: <20210804140309.31468-2-puranjay12@gmail.com> References: <20210804140309.31468-1-puranjay12@gmail.com> <20210804140309.31468-2-puranjay12@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Aug 2021 19:33:07 +0530 Puranjay Mohan wrote: > Add devicetree binding document for ADXL355, a 3-Axis MEMS Accelerometer. > > Signed-off-by: Puranjay Mohan Looks good to me. I'll pick this up once Rob and anyone else interested has had time to take a look assuming they don't ask for any changes. Thanks, Jonathan > --- > .../bindings/iio/accel/adi,adxl355.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml > new file mode 100644 > index 000000000..5da3fd5ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/adi,adxl355.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADXL355 3-Axis, Low noise MEMS Accelerometer > + > +maintainers: > + - Puranjay Mohan > + > +description: | > + Analog Devices ADXL355 3-Axis, Low noise MEMS Accelerometer that supports > + both I2C & SPI interfaces > + https://www.analog.com/en/products/adxl355.html > + > +properties: > + compatible: > + enum: > + - adi,adxl355 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 3 > + description: | > + Type should be IRQ_TYPE_LEVEL_HIGH. > + Three configurable interrupt lines exist. > + > + interrupt-names: > + description: Specify which interrupt line is in use. > + items: > + enum: > + - INT1 > + - INT2 > + - DRDY > + minItems: 1 > + maxItems: 3 > + > + vdd-supply: > + description: Regulator that provides power to the sensor > + > + vddio-supply: > + description: Regulator that provides power to the bus > + > + spi-max-frequency: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* Example for a I2C device node */ > + accelerometer@1d { > + compatible = "adi,adxl355"; > + reg = <0x1d>; > + interrupt-parent = <&gpio>; > + interrupts = <25 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "DRDY"; > + }; > + }; > + - | > + #include > + #include > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + accelerometer@0 { > + compatible = "adi,adxl355"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + interrupt-parent = <&gpio>; > + interrupts = <25 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "DRDY"; > + }; > + };