linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com,
	suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	ardb@kernel.org, qwandor@google.com, tabba@google.com,
	dbrazdil@google.com, kernel-team@android.com, qperret@google.com
Subject: [PATCH v4 16/21] KVM: arm64: Enable retrieving protections attributes of PTEs
Date: Mon,  9 Aug 2021 16:24:43 +0100	[thread overview]
Message-ID: <20210809152448.1810400-17-qperret@google.com> (raw)
In-Reply-To: <20210809152448.1810400-1-qperret@google.com>

Introduce helper functions in the KVM stage-2 and stage-1 page-table
manipulation library allowing to retrieve the enum kvm_pgtable_prot of a
PTE. This will be useful to implement custom walkers outside of
pgtable.c.

Signed-off-by: Quentin Perret <qperret@google.com>
---
 arch/arm64/include/asm/kvm_pgtable.h | 20 +++++++++++++++
 arch/arm64/kvm/hyp/pgtable.c         | 37 ++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+)

diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h
index ff9d52f8073a..f1651e0153ad 100644
--- a/arch/arm64/include/asm/kvm_pgtable.h
+++ b/arch/arm64/include/asm/kvm_pgtable.h
@@ -506,4 +506,24 @@ int kvm_pgtable_walk(struct kvm_pgtable *pgt, u64 addr, u64 size,
  */
 int kvm_pgtable_get_leaf(struct kvm_pgtable *pgt, u64 addr,
 			 kvm_pte_t *ptep, u32 *level);
+
+/**
+ * kvm_pgtable_stage2_pte_prot() - Retrieve the protection attributes of a
+ *				   stage-2 Page-Table Entry.
+ * @pte:	Page-table entry
+ *
+ * Return: protection attributes of the page-table entry in the enum
+ *	   kvm_pgtable_prot format.
+ */
+enum kvm_pgtable_prot kvm_pgtable_stage2_pte_prot(kvm_pte_t pte);
+
+/**
+ * kvm_pgtable_hyp_pte_prot() - Retrieve the protection attributes of a stage-1
+ *				Page-Table Entry.
+ * @pte:	Page-table entry
+ *
+ * Return: protection attributes of the page-table entry in the enum
+ *	   kvm_pgtable_prot format.
+ */
+enum kvm_pgtable_prot kvm_pgtable_hyp_pte_prot(kvm_pte_t pte);
 #endif	/* __ARM64_KVM_PGTABLE_H__ */
diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c
index cff744136044..f8ceebe4982e 100644
--- a/arch/arm64/kvm/hyp/pgtable.c
+++ b/arch/arm64/kvm/hyp/pgtable.c
@@ -363,6 +363,26 @@ static int hyp_set_prot_attr(enum kvm_pgtable_prot prot, kvm_pte_t *ptep)
 	return 0;
 }
 
+enum kvm_pgtable_prot kvm_pgtable_hyp_pte_prot(kvm_pte_t pte)
+{
+	enum kvm_pgtable_prot prot = pte & KVM_PTE_LEAF_ATTR_HI_SW;
+	u32 ap;
+
+	if (!kvm_pte_valid(pte))
+		return prot;
+
+	if (!(pte & KVM_PTE_LEAF_ATTR_HI_S1_XN))
+		prot |= KVM_PGTABLE_PROT_X;
+
+	ap = FIELD_GET(KVM_PTE_LEAF_ATTR_LO_S1_AP, pte);
+	if (ap == KVM_PTE_LEAF_ATTR_LO_S1_AP_RO)
+		prot |= KVM_PGTABLE_PROT_R;
+	else if (ap == KVM_PTE_LEAF_ATTR_LO_S1_AP_RW)
+		prot |= KVM_PGTABLE_PROT_RW;
+
+	return prot;
+}
+
 static bool hyp_pte_needs_update(kvm_pte_t old, kvm_pte_t new)
 {
 	/*
@@ -565,6 +585,23 @@ static int stage2_set_prot_attr(struct kvm_pgtable *pgt, enum kvm_pgtable_prot p
 	return 0;
 }
 
+enum kvm_pgtable_prot kvm_pgtable_stage2_pte_prot(kvm_pte_t pte)
+{
+	enum kvm_pgtable_prot prot = pte & KVM_PTE_LEAF_ATTR_HI_SW;
+
+	if (!kvm_pte_valid(pte))
+		return prot;
+
+	if (pte & KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R)
+		prot |= KVM_PGTABLE_PROT_R;
+	if (pte & KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W)
+		prot |= KVM_PGTABLE_PROT_W;
+	if (!(pte & KVM_PTE_LEAF_ATTR_HI_S2_XN))
+		prot |= KVM_PGTABLE_PROT_X;
+
+	return prot;
+}
+
 static bool stage2_pte_needs_update(kvm_pte_t old, kvm_pte_t new)
 {
 	if (!kvm_pte_valid(old) || !kvm_pte_valid(new))
-- 
2.32.0.605.g8dce9f2422-goog


  parent reply	other threads:[~2021-08-09 15:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 15:24 [PATCH v4 00/21] Track shared pages at EL2 in protected mode Quentin Perret
2021-08-09 15:24 ` [PATCH v4 01/21] KVM: arm64: Add hyp_spin_is_locked() for basic locking assertions at EL2 Quentin Perret
2021-08-09 15:24 ` [PATCH v4 02/21] KVM: arm64: Introduce hyp_assert_lock_held() Quentin Perret
2021-08-09 15:24 ` [PATCH v4 03/21] KVM: arm64: Provide the host_stage2_try() helper macro Quentin Perret
2021-08-09 15:24 ` [PATCH v4 04/21] KVM: arm64: Introduce helper to retrieve a PTE and its level Quentin Perret
2021-08-17 13:53   ` Andrew Walbran
2021-08-09 15:24 ` [PATCH v4 05/21] KVM: arm64: Expose page-table helpers Quentin Perret
2021-08-10  4:56   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 06/21] KVM: arm64: Optimize host memory aborts Quentin Perret
2021-08-09 15:24 ` [PATCH v4 07/21] KVM: arm64: Rename KVM_PTE_LEAF_ATTR_S2_IGNORED Quentin Perret
2021-08-09 15:24 ` [PATCH v4 08/21] KVM: arm64: Don't overwrite software bits with owner id Quentin Perret
2021-08-09 15:24 ` [PATCH v4 09/21] KVM: arm64: Tolerate re-creating hyp mappings to set software bits Quentin Perret
2021-08-09 15:24 ` [PATCH v4 10/21] KVM: arm64: Enable forcing page-level stage-2 mappings Quentin Perret
2021-08-10  4:33   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 11/21] KVM: arm64: Allow populating software bits Quentin Perret
2021-08-10  4:56   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 12/21] KVM: arm64: Add helpers to tag shared pages in SW bits Quentin Perret
2021-08-09 15:24 ` [PATCH v4 13/21] KVM: arm64: Expose host stage-2 manipulation helpers Quentin Perret
2021-08-10  4:36   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 14/21] KVM: arm64: Expose pkvm_hyp_id Quentin Perret
2021-08-10  4:57   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 15/21] KVM: arm64: Introduce addr_is_memory() Quentin Perret
2021-08-10  4:37   ` Fuad Tabba
2021-08-09 15:24 ` Quentin Perret [this message]
2021-08-10  4:38   ` [PATCH v4 16/21] KVM: arm64: Enable retrieving protections attributes of PTEs Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 17/21] KVM: arm64: Mark host bss and rodata section as shared Quentin Perret
2021-08-10  4:40   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 18/21] KVM: arm64: Remove __pkvm_mark_hyp Quentin Perret
2021-08-10  4:55   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 19/21] KVM: arm64: Refactor protected nVHE stage-1 locking Quentin Perret
2021-08-10  4:41   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 20/21] KVM: arm64: Restrict EL2 stage-1 changes in protected mode Quentin Perret
2021-08-10  4:43   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 21/21] KVM: arm64: Make __pkvm_create_mappings static Quentin Perret
2021-08-10  4:55   ` Fuad Tabba
2021-08-11 11:25 ` [PATCH v4 00/21] Track shared pages at EL2 in protected mode Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809152448.1810400-17-qperret@google.com \
    --to=qperret@google.com \
    --cc=alexandru.elisei@arm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dbrazdil@google.com \
    --cc=james.morse@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=qwandor@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).