linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the net-next tree
@ 2021-08-09 10:20 Stephen Rothwell
  2021-08-09 13:21 ` Arnd Bergmann
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-08-09 10:20 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Arnd Bergmann, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/cirrus/cs89x0.c: In function 'net_open':
drivers/net/ethernet/cirrus/cs89x0.c:897:20: error: implicit declaration of function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
  897 |     (unsigned long)isa_virt_to_bus(lp->dma_buff));
      |                    ^~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: in definition of macro '__dynamic_func_call'
  134 |   func(&id, ##__VA_ARGS__);  \
      |               ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:2: note: in expansion of macro '_dynamic_func_call'
  162 |  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
      |  ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:570:2: note: in expansion of macro 'dynamic_pr_debug'
  570 |  dynamic_pr_debug(fmt, ##__VA_ARGS__)
      |  ^~~~~~~~~~~~~~~~
drivers/net/ethernet/cirrus/cs89x0.c:86:3: note: in expansion of macro 'pr_debug'
   86 |   pr_##level(fmt, ##__VA_ARGS__);   \
      |   ^~~
drivers/net/ethernet/cirrus/cs89x0.c:894:3: note: in expansion of macro 'cs89_dbg'
  894 |   cs89_dbg(1, debug, "%s: dma %lx %lx\n",
      |   ^~~~~~~~

Caused by commit

  47fd22f2b847 ("cs89x0: rework driver configuration")

I have removed the COMPILE_TEST from NET_VENDOR_CIRRUS for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2024-03-01  1:11 Stephen Rothwell
  2024-03-01  9:09 ` Eric Dumazet
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2024-03-01  1:11 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Paolo Abeni, Networking
  Cc: Eric Dumazet, Jiri Pirko, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from <command-line>:
In function 'tcp_struct_check',
    inlined from 'tcp_init' at net/ipv4/tcp.c:4700:2:
include/linux/compiler_types.h:442:45: error: call to '__compiletime_assert_940' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct tcp_sock, __cacheline_group_end__tcp_sock_write_rx) - offsetofend(struct tcp_sock, __cacheline_group_begin__tcp_sock_write_rx) > 99
  442 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
include/linux/compiler_types.h:423:25: note: in definition of macro '__compiletime_assert'
  423 |                         prefix ## suffix();                             \
      |                         ^~~~~~
include/linux/compiler_types.h:442:9: note: in expansion of macro '_compiletime_assert'
  442 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
      |         ^~~~~~~~~~~~~~~~
include/linux/cache.h:108:9: note: in expansion of macro 'BUILD_BUG_ON'
  108 |         BUILD_BUG_ON(offsetof(TYPE, __cacheline_group_end__##GROUP) - \
      |         ^~~~~~~~~~~~
net/ipv4/tcp.c:4687:9: note: in expansion of macro 'CACHELINE_ASSERT_GROUP_SIZE'
 4687 |         CACHELINE_ASSERT_GROUP_SIZE(struct tcp_sock, tcp_sock_write_rx, 99);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  99123622050f ("tcp: remove some holes in struct tcp_sock")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2023-12-21  2:09 Stephen Rothwell
  2023-12-21  2:18 ` Christian Marangi
  2024-01-04 21:15 ` Jakub Kicinski
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2023-12-21  2:09 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Paolo Abeni, Andrew Morton
  Cc: Networking, Mathis Marion, Christian Marangi, Robert Marko,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 3174 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/phy/aquantia/aquantia_firmware.c: In function 'aqr_fw_load_memory':
drivers/net/phy/aquantia/aquantia_firmware.c:135:23: error: implicit declaration of function 'crc_ccitt_false'; did you mean 'crc_ccitt_byte'? [-Werror=implicit-function-declaration]
  135 |                 crc = crc_ccitt_false(crc, crc_data, sizeof(crc_data));
      |                       ^~~~~~~~~~~~~~~
      |                       crc_ccitt_byte

Caused by commit

  e93984ebc1c8 ("net: phy: aquantia: add firmware load support")

interacting with commit

  56ded2dd1a43 ("lib: crc_ccitt_false() is identical to crc_itu_t()")

from the mm tree.

I have applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 21 Dec 2023 12:49:11 +1100
Subject: [PATCH] fix up for "net: phy: aquantia: add firmware load support"

interacting with commit

  56ded2dd1a43 ("lib: crc_ccitt_false() is identical to crc_itu_t()")

from the mm tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/phy/aquantia/Kconfig             | 2 +-
 drivers/net/phy/aquantia/aquantia_firmware.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/phy/aquantia/Kconfig b/drivers/net/phy/aquantia/Kconfig
index a35de4b9b554..1a65678583cf 100644
--- a/drivers/net/phy/aquantia/Kconfig
+++ b/drivers/net/phy/aquantia/Kconfig
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config AQUANTIA_PHY
 	tristate "Aquantia PHYs"
-	select CRC_CCITT
+	select CRC_ITU_T
 	help
 	  Currently supports the Aquantia AQ1202, AQ2104, AQR105, AQR405
diff --git a/drivers/net/phy/aquantia/aquantia_firmware.c b/drivers/net/phy/aquantia/aquantia_firmware.c
index ff34d00d5a0e..0c9640ef153b 100644
--- a/drivers/net/phy/aquantia/aquantia_firmware.c
+++ b/drivers/net/phy/aquantia/aquantia_firmware.c
@@ -3,7 +3,7 @@
 #include <linux/bitfield.h>
 #include <linux/of.h>
 #include <linux/firmware.h>
-#include <linux/crc-ccitt.h>
+#include <linux/crc-itu-t.h>
 #include <linux/nvmem-consumer.h>
 
 #include <asm/unaligned.h>
@@ -132,7 +132,7 @@ static int aqr_fw_load_memory(struct phy_device *phydev, u32 addr,
 		crc_data[3] = word;
 
 		/* ...calculate CRC as we load data... */
-		crc = crc_ccitt_false(crc, crc_data, sizeof(crc_data));
+		crc = crc_itu_t(crc, crc_data, sizeof(crc_data));
 	}
 	/* ...gets CRC from MAILBOX after we have loaded the entire section... */
 	up_crc = phy_read_mmd(phydev, MDIO_MMD_VEND1, VEND1_GLOBAL_MAILBOX_INTERFACE2);
@@ -164,7 +164,7 @@ static int aqr_fw_boot(struct phy_device *phydev, const u8 *data, size_t size,
 		phydev_err(phydev, "bad firmware CRC in firmware\n");
 		return ret;
 	}
-	calculated_crc = crc_ccitt_false(0, data, size - sizeof(u16));
+	calculated_crc = crc_itu_t(0, data, size - sizeof(u16));
 	if (read_crc != calculated_crc) {
 		phydev_err(phydev, "bad firmware CRC: file 0x%04x calculated 0x%04x\n",
 			   read_crc, calculated_crc);
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2023-06-26  1:28 Stephen Rothwell
  2023-06-26  7:48 ` David Howells
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2023-06-26  1:28 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: David Howells, Jakub Kicinski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (native perf)
failed like this:

In file included from builtin-trace.c:907:
trace/beauty/msg_flags.c: In function 'syscall_arg__scnprintf_msg_flags':
trace/beauty/msg_flags.c:28:21: error: 'MSG_SPLICE_PAGES' undeclared (first use in this function)
   28 |         if (flags & MSG_##n) { \
      |                     ^~~~
trace/beauty/msg_flags.c:50:9: note: in expansion of macro 'P_MSG_FLAG'
   50 |         P_MSG_FLAG(SPLICE_PAGES);
      |         ^~~~~~~~~~
trace/beauty/msg_flags.c:28:21: note: each undeclared identifier is reported only once for each function it appears in
   28 |         if (flags & MSG_##n) { \
      |                     ^~~~
trace/beauty/msg_flags.c:50:9: note: in expansion of macro 'P_MSG_FLAG'
   50 |         P_MSG_FLAG(SPLICE_PAGES);
      |         ^~~~~~~~~~

Caused by commit

  b848b26c6672 ("net: Kill MSG_SENDPAGE_NOTLAST")

There is no MSG_SPLICE_PAGES in tools/perf/trace/beauty/include/linux/socket.h

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2023-06-13  6:46 Stephen Rothwell
  2023-06-14  9:01 ` Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 394+ messages in thread
From: Stephen Rothwell @ 2023-06-13  6:46 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Eric Dumazet, Jakub Kicinski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

drivers/net/ethernet/sun/sunvnet_common.c: In function 'vnet_handle_offloads':
drivers/net/ethernet/sun/sunvnet_common.c:1277:16: error: implicit declaration of function 'skb_gso_segment'; did you mean 'skb_gso_reset'? [-Werror=implicit-function-declaration]
 1277 |         segs = skb_gso_segment(skb, dev->features & ~NETIF_F_TSO);
      |                ^~~~~~~~~~~~~~~
      |                skb_gso_reset
drivers/net/ethernet/sun/sunvnet_common.c:1277:14: warning: assignment to 'struct sk_buff *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
 1277 |         segs = skb_gso_segment(skb, dev->features & ~NETIF_F_TSO);
      |              ^

Caused by commit

  d457a0e329b0 ("net: move gso declarations and functions to their own files")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 13 Jun 2023 16:38:10 +1000
Subject: [PATCH] Fix a sparc64 use of the gso functions

This was missed when they were moved.

Fixes: d457a0e329b0 ("net: move gso declarations and functions to their own files")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/sun/sunvnet_common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c
index a6211b95ed17..3525d5c0d694 100644
--- a/drivers/net/ethernet/sun/sunvnet_common.c
+++ b/drivers/net/ethernet/sun/sunvnet_common.c
@@ -25,6 +25,7 @@
 #endif
 
 #include <net/ip.h>
+#include <net/gso.h>
 #include <net/icmp.h>
 #include <net/route.h>
 
-- 
2.39.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2023-02-21  1:40 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2023-02-21  1:40 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: D. Wythe, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 3224 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/notifier.h:14,
                 from arch/x86/include/asm/uprobes.h:13,
                 from include/linux/uprobes.h:49,
                 from include/linux/mm_types.h:16,
                 from include/linux/buildid.h:5,
                 from include/linux/module.h:14,
                 from net/smc/af_smc.c:22:
net/smc/af_smc.c: In function 'smcr_serv_conf_first_link':
net/smc/af_smc.c:1842:20: error: passing argument 1 of 'mutex_lock_nested' from incompatible pointer type [-Werror=incompatible-pointer-types]
 1842 |         mutex_lock(&link->lgr->llc_conf_mutex);
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                    |
      |                    struct rw_semaphore *
include/linux/mutex.h:187:44: note: in definition of macro 'mutex_lock'
  187 | #define mutex_lock(lock) mutex_lock_nested(lock, 0)
      |                                            ^~~~
include/linux/mutex.h:178:45: note: expected 'struct mutex *' but argument is of type 'struct rw_semaphore *'
  178 | extern void mutex_lock_nested(struct mutex *lock, unsigned int subclass);
      |                               ~~~~~~~~~~~~~~^~~~
net/smc/af_smc.c:1845:22: error: passing argument 1 of 'mutex_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
 1845 |         mutex_unlock(&link->lgr->llc_conf_mutex);
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                      |
      |                      struct rw_semaphore *
include/linux/mutex.h:218:40: note: expected 'struct mutex *' but argument is of type 'struct rw_semaphore *'
  218 | extern void mutex_unlock(struct mutex *lock);
      |                          ~~~~~~~~~~~~~~^~~~

Caused by commit

  b5dd4d698171 ("net/smc: llc_conf_mutex refactor, replace it with rw_semaphore")

interacting with commit

  e40b801b3603 ("net/smc: fix potential panic dues to unprotected smc_llc_srv_add_link()")

from the net tree.

I applied the following merge resolution patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 21 Feb 2023 12:30:46 +1100
Subject: [PATCH] fix up for "net/smc: llc_conf_mutex refactor, replace it with rw_semaphore"

interacting with "net/smc: fix potential panic dues to unprotected smc_llc_srv_add_link()"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/smc/af_smc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 0f6a61e44e93..a4cccdfdc00a 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1839,10 +1839,10 @@ static int smcr_serv_conf_first_link(struct smc_sock *smc)
 	smc_llc_link_active(link);
 	smcr_lgr_set_type(link->lgr, SMC_LGR_SINGLE);
 
-	mutex_lock(&link->lgr->llc_conf_mutex);
+	down_write(&link->lgr->llc_conf_mutex);
 	/* initial contact - try to establish second link */
 	smc_llc_srv_add_link(link, NULL);
-	mutex_unlock(&link->lgr->llc_conf_mutex);
+	up_write(&link->lgr->llc_conf_mutex);
 	return 0;
 }
 
-- 
2.39.1


-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2023-01-23 23:02 Stephen Rothwell
  2023-01-24  9:57 ` Matthieu Baerts
  2023-01-24 17:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2023-01-23 23:02 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Vladimir Oltean, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2511 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from net/ethtool/netlink.c:6:
net/ethtool/netlink.h:177:20: error: redefinition of 'ethnl_update_bool'
  177 | static inline void ethnl_update_bool(bool *dst, const struct nlattr *attr,
      |                    ^~~~~~~~~~~~~~~~~
net/ethtool/netlink.h:125:20: note: previous definition of 'ethnl_update_bool' with type 'void(bool *, const struct nlattr *, bool *)' {aka 'void(_Bool *, const struct nlattr *, _Bool *)'}
  125 | static inline void ethnl_update_bool(bool *dst, const struct nlattr *attr,
      |                    ^~~~~~~~~~~~~~~~~

Caused by commit

  dc0b98a1758f ("ethtool: Add and use ethnl_update_bool.")

merging badly with commit

  7c494a7749a7 ("net: ethtool: netlink: introduce ethnl_update_bool()")

from the net tree.

I applied the following merge fix up.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 24 Jan 2023 09:58:16 +1100
Subject: [PATCH] fix up for "ethtool: Add and use ethnl_update_bool."

interacting with "net: ethtool: netlink: introduce ethnl_update_bool()"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ethtool/netlink.h | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/net/ethtool/netlink.h b/net/ethtool/netlink.h
index 4992fab0d06b..b01f7cd542c4 100644
--- a/net/ethtool/netlink.h
+++ b/net/ethtool/netlink.h
@@ -111,32 +111,6 @@ static inline void ethnl_update_u8(u8 *dst, const struct nlattr *attr,
 	*mod = true;
 }
 
-/**
- * ethnl_update_bool() - update bool from NLA_U8 attribute
- * @dst:  value to update
- * @attr: netlink attribute with new value or null
- * @mod:  pointer to bool for modification tracking
- *
- * Use the u8 value from NLA_U8 netlink attribute @attr to set bool variable
- * pointed to by @dst to false (if zero) or 1 (if not); do nothing if @attr is
- * null. Bool pointed to by @mod is set to true if this function changed the
- * logical value of *dst, otherwise it is left as is.
- */
-static inline void ethnl_update_bool(bool *dst, const struct nlattr *attr,
-				     bool *mod)
-{
-	u8 val;
-
-	if (!attr)
-		return;
-	val = !!nla_get_u8(attr);
-	if (*dst == val)
-		return;
-
-	*dst = val;
-	*mod = true;
-}
-
 /**
  * ethnl_update_bool32() - update u32 used as bool from NLA_U8 attribute
  * @dst:  value to update
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-11-27 23:15 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2022-11-27 23:15 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Xu Panda, Yang Yang, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_cmdline_opt':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7591:28: error: too many arguments to function 'sysfs_streq'
 7591 |                 } else if (sysfs_streq(opt, "pause:", 6)) {
      |                            ^~~~~~~~~~~
In file included from include/linux/bitmap.h:11,
                 from include/linux/cpumask.h:12,
                 from include/linux/smp.h:13,
                 from include/linux/lockdep.h:14,
                 from include/linux/mutex.h:17,
                 from include/linux/notifier.h:14,
                 from include/linux/clk.h:14,
                 from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17:
include/linux/string.h:185:13: note: declared here
  185 | extern bool sysfs_streq(const char *s1, const char *s2);
      |             ^~~~~~~~~~~

Caused by commit

  f72cd76b05ea ("net: stmmac: use sysfs_streq() instead of strncmp()")

I have used the net-next tree from next-20221125 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-11-16  6:33 Stephen Rothwell
  2022-11-16  8:47 ` Jamie Bainbridge
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-11-16  6:33 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Jakub Kicinski, Jamie Bainbridge, Linux Kernel Mailing List,
	Linux Next Mailing List, Eric Dumazet, Stephen Hemminger

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
pseries_le_defconfig) failed like this:


Caused by commit

  d9282e48c608 ("tcp: Add listening address to SYN flood message")

CONFIG_IPV6 is not set for this build.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-07-07  1:00 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2022-07-07  1:00 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Ratheesh Kannoth, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:14:
drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:15120:28: error: 'npc_mkex_default' defined but not used [-Werror=unused-variable]
15120 | static struct npc_mcam_kex npc_mkex_default = {
      |                            ^~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:15000:30: error: 'npc_lt_defaults' defined but not used [-Werror=unused-variable]
15000 | static struct npc_lt_def_cfg npc_lt_defaults = {
      |                              ^~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:14901:31: error: 'npc_kpu_profiles' defined but not used [-Werror=unused-variable]
14901 | static struct npc_kpu_profile npc_kpu_profiles[] = {
      |                               ^~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:483:38: error: 'ikpu_action_entries' defined but not used [-Werror=unused-variable]
  483 | static struct npc_kpu_profile_action ikpu_action_entries[] = {
      |                                      ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  c6238bc0614d ("octeontx2-af: Drop rules for NPC MCAM")

I do wonder why static structs are declared in a header file ...

I have used the net-next tree from next-20220706 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-06-19 23:34 Stephen Rothwell
  2022-06-19 23:48 ` Kuniyuki Iwashima
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-06-19 23:34 UTC (permalink / raw)
  To: David Miller
  Cc: Networking, Eric Dumazet, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/ipv4/raw.c: In function 'raw_icmp_error':
net/ipv4/raw.c:266:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  266 |         struct hlist_nulls_head *hlist;
      |         ^~~~~~
cc1: all warnings being treated as errors

Introduced by commit

  ba44f8182ec2 ("raw: use more conventional iterators")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 20 Jun 2022 09:21:01 +1000
Subject: [PATCH] raw: fix build error

The linux-next x86_64 allmodconfig build produced this error:

net/ipv4/raw.c: In function 'raw_icmp_error':
net/ipv4/raw.c:266:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  266 |         struct hlist_nulls_head *hlist;
      |         ^~~~~~
cc1: all warnings being treated as errors

Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ipv4/raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index d28bf0b901a2..b3b255db9021 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -262,7 +262,7 @@ static void raw_err(struct sock *sk, struct sk_buff *skb, u32 info)
 
 void raw_icmp_error(struct sk_buff *skb, int protocol, u32 info)
 {
-	struct net *net = dev_net(skb->dev);;
+	struct net *net = dev_net(skb->dev);
 	struct hlist_nulls_head *hlist;
 	struct hlist_nulls_node *hnode;
 	int dif = skb->dev->ifindex;
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-05-20  4:59 Stephen Rothwell
  2022-05-20  5:20 ` Jakub Kicinski
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-05-20  4:59 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Felix Fietkau, Lorenzo Bianconi, Pablo Neira Ayuso,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2563 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/mediatek/mtk_ppe_offload.c: In function 'mtk_flow_get_wdma_info':
drivers/net/ethernet/mediatek/mtk_ppe_offload.c:93:26: error: initialization of 'unsigned char' from 'const u8 *' {aka 'const unsigned char *'} makes integer from pointer without a cast [-Werror=int-conversion]
   93 |                 .daddr = addr,
      |                          ^~~~
drivers/net/ethernet/mediatek/mtk_ppe_offload.c:93:26: note: (near initialization for 'ctx.daddr[0]')
drivers/net/ethernet/mediatek/mtk_ppe_offload.c:91:42: error: missing braces around initializer [-Werror=missing-braces]
   91 |         struct net_device_path_ctx ctx = {
      |                                          ^
   92 |                 .dev = dev,
   93 |                 .daddr = addr,
      |                          {
   94 |         };
      |         }

Caused by commit

  cf2df74e202d ("net: fix dev_fill_forward_path with pppoe + bridge")

from Linus' tree interacting with commit

  a333215e10cb ("net: ethernet: mtk_eth_soc: implement flow offloading to WED devices")

from the net-next tree.

I have applied the following merge fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 May 2022 14:49:44 +1000
Subject: [PATCH] fis up for "net: fix dev_fill_forward_path with pppoe + bridge"

interacting with commit a333215e10cb "net: ethernet: mtk_eth_soc: implement flow offloading to WED devices"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
index 1fe31058b0f2..d4a0126082f2 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
@@ -90,7 +90,6 @@ mtk_flow_get_wdma_info(struct net_device *dev, const u8 *addr, struct mtk_wdma_i
 {
 	struct net_device_path_ctx ctx = {
 		.dev = dev,
-		.daddr = addr,
 	};
 	struct net_device_path path = {};
 
@@ -100,6 +99,7 @@ mtk_flow_get_wdma_info(struct net_device *dev, const u8 *addr, struct mtk_wdma_i
 	if (!dev->netdev_ops->ndo_fill_forward_path)
 		return -1;
 
+	memcpy(ctx.daddr, addr, sizeof(ctx.daddr));
 	if (dev->netdev_ops->ndo_fill_forward_path(&ctx, &path))
 		return -1;
 
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-05-10  3:05 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2022-05-10  3:05 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Taehee Yoo, Martin Habets, Paolo Abeni,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2380 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/sfc/ptp.c:2191:35: error: 'efx_copy_channel' undeclared here (not in a function); did you mean 'efx_ptp_channel'?
 2191 |         .copy                   = efx_copy_channel,
      |                                   ^~~~~~~~~~~~~~~~
      |                                   efx_ptp_channel

Caused by commit

  54fccfdd7c66 ("sfc: efx_default_channel_type APIs can be static")

interacting with commit

  49e6123c65da ("net: sfc: fix memory leak due to ptp channel")

from the net tree.

I have added the following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 May 2022 12:56:18 +1000
Subject: [PATCH] fix up for "net: sfc: fix memory leak due to ptp channel"

This is a partial revert of

  54fccfdd7c66 ("sfc: efx_default_channel_type APIs can be static")

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/sfc/efx_channels.c | 1 -
 drivers/net/ethernet/sfc/efx_channels.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c
index ec913f62790b..79df636d6df8 100644
--- a/drivers/net/ethernet/sfc/efx_channels.c
+++ b/drivers/net/ethernet/sfc/efx_channels.c
@@ -598,7 +598,6 @@ void efx_fini_channels(struct efx_nic *efx)
 /* Allocate and initialise a channel structure, copying parameters
  * (but not resources) from an old channel structure.
  */
-static
 struct efx_channel *efx_copy_channel(const struct efx_channel *old_channel)
 {
 	struct efx_rx_queue *rx_queue;
diff --git a/drivers/net/ethernet/sfc/efx_channels.h b/drivers/net/ethernet/sfc/efx_channels.h
index 64abb99a56b8..46b702648721 100644
--- a/drivers/net/ethernet/sfc/efx_channels.h
+++ b/drivers/net/ethernet/sfc/efx_channels.h
@@ -39,6 +39,7 @@ int efx_set_channels(struct efx_nic *efx);
 void efx_remove_channel(struct efx_channel *channel);
 void efx_remove_channels(struct efx_nic *efx);
 void efx_fini_channels(struct efx_nic *efx);
+struct efx_channel *efx_copy_channel(const struct efx_channel *old_channel);
 void efx_start_channels(struct efx_nic *efx);
 void efx_stop_channels(struct efx_nic *efx);
 
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-03-21  7:39 Stephen Rothwell
  2022-03-21 21:45 ` Jakub Kicinski
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-03-21  7:39 UTC (permalink / raw)
  To: David Miller, Networking, Kees Cook
  Cc: Maxim Mikityanskiy, Saeed Mahameed, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 3426 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/string.h:253,
                 from include/linux/bitmap.h:11,
                 from include/linux/cpumask.h:12,
                 from arch/x86/include/asm/cpumask.h:5,
                 from arch/x86/include/asm/msr.h:11,
                 from arch/x86/include/asm/processor.h:22,
                 from arch/x86/include/asm/timex.h:5,
                 from include/linux/timex.h:65,
                 from include/linux/time32.h:13,
                 from include/linux/time.h:60,
                 from include/linux/ktime.h:24,
                 from include/linux/timer.h:6,
                 from include/linux/netdevice.h:24,
                 from include/trace/events/xdp.h:8,
                 from include/linux/bpf_trace.h:5,
                 from drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:33:
In function 'fortify_memset_chk',
    inlined from 'mlx5e_xmit_xdp_frame' at drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:438:3:
include/linux/fortify-string.h:242:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
  242 |                         __write_overflow_field(p_size_field, size);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  9ded70fa1d81 ("net/mlx5e: Don't prefill WQEs in XDP SQ in the multi buffer mode")

exposed by the kspp tree.

I have applied the following fix patch for today (a better one is
probably possible).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 21 Mar 2022 18:29:24 +1100
Subject: [PATCH] fxup for "net/mlx5e: Don't prefill WQEs in XDP SQ in the multi buffer mode"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 3 +--
 include/linux/mlx5/qp.h                          | 5 +++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
index f35b62ce4c07..8f321a6c0809 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
@@ -435,8 +435,7 @@ mlx5e_xmit_xdp_frame(struct mlx5e_xdpsq *sq, struct mlx5e_xmit_data *xdptxd,
 		u8 num_pkts = 1 + num_frags;
 		int i;
 
-		memset(&cseg->signature, 0, sizeof(*cseg) -
-		       sizeof(cseg->opmod_idx_opcode) - sizeof(cseg->qpn_ds));
+		memset(&cseg->trailer, 0, sizeof(cseg->trailer));
 		memset(eseg, 0, sizeof(*eseg) - sizeof(eseg->trailer));
 
 		eseg->inline_hdr.sz = cpu_to_be16(inline_hdr_sz);
diff --git a/include/linux/mlx5/qp.h b/include/linux/mlx5/qp.h
index 61e48d459b23..8bda3ba5b109 100644
--- a/include/linux/mlx5/qp.h
+++ b/include/linux/mlx5/qp.h
@@ -202,6 +202,9 @@ struct mlx5_wqe_fmr_seg {
 struct mlx5_wqe_ctrl_seg {
 	__be32			opmod_idx_opcode;
 	__be32			qpn_ds;
+
+	struct_group(trailer,
+
 	u8			signature;
 	u8			rsvd[2];
 	u8			fm_ce_se;
@@ -211,6 +214,8 @@ struct mlx5_wqe_ctrl_seg {
 		__be32		umr_mkey;
 		__be32		tis_tir_num;
 	};
+
+	); /* end of trailer group */
 };
 
 #define MLX5_WQE_CTRL_DS_MASK 0x3f
-- 
2.34.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-03-15 11:44 Stephen Rothwell
  2022-03-15 13:14 ` Vladimir Oltean
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-03-15 11:44 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Vladimir Oltean, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm64
defconfig) failed like this:

drivers/net/ethernet/mscc/ocelot.c: In function 'ocelot_port_set_default_prio':
drivers/net/ethernet/mscc/ocelot.c:2920:21: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
 2920 |         if (prio >= IEEE_8021QAZ_MAX_TCS)
      |                     ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mscc/ocelot.c:2920:21: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/mscc/ocelot.c: In function 'ocelot_port_add_dscp_prio':
drivers/net/ethernet/mscc/ocelot.c:2962:21: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
 2962 |         if (prio >= IEEE_8021QAZ_MAX_TCS)
      |                     ^~~~~~~~~~~~~~~~~~~~

Caused by commit

  978777d0fb06 ("net: dsa: felix: configure default-prio and dscp priorities")

I have applied the following fix up patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 15 Mar 2022 22:34:25 +1100
Subject: [PATCH] fixup for "net: dsa: felix: configure default-prio and dscp priorities"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mscc/ocelot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 41dbb1e326c4..7c4bd3f8e7ec 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -7,6 +7,7 @@
 #include <linux/dsa/ocelot.h>
 #include <linux/if_bridge.h>
 #include <linux/ptp_classify.h>
+#include <net/dcbnl.h>
 #include <soc/mscc/ocelot_vcap.h>
 #include "ocelot.h"
 #include "ocelot_vcap.h"
-- 
2.34.1



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-03-07 10:45 Stephen Rothwell
  2022-03-07 17:18 ` Dimitris Michailidis
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-03-07 10:45 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Dimitris Michailidis, Dimitris Michailidis,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allmodconfig) failed like this:

ERROR: modpost: ".local_memory_node" [drivers/net/ethernet/fungible/funeth/funeth.ko] undefined!

Caused by commits

  ee6373ddf3a9 ("net/funeth: probing and netdev ops")
  db37bc177dae ("net/funeth: add the data path")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-03-07 10:36 Stephen Rothwell
  2022-03-07 20:53 ` Maciej Fijalkowski
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-03-07 10:36 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Daniel Borkmann, Maciej Fijalkowski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm64
allmodconfig) failed like this:

drivers/net/ethernet/intel/ice/ice_xsk.c: In function 'ice_xmit_pkt_batch':
drivers/net/ethernet/intel/ice/ice_xsk.c:801:0: error: ignoring #pragma GCC unroll [-Werror=unknown-pragmas]
  loop_unrolled_for(i = 0; i < PKTS_PER_BATCH; i++) {
 ^
cc1: all warnings being treated as errors

Caused by commit

  126cdfe1007a ("ice: xsk: Improve AF_XDP ZC Tx and use batching API")

This build was done with gcc v5.4.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-03-02  0:56 Stephen Rothwell
  2022-03-02  1:15 ` Jakub Kicinski
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2022-03-02  0:56 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Dust Li, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:


Caused by commit

  12bbb0d163a9 ("net/smc: add sysctl for autocorking")

( or maybe commit

  dcd2cf5f2fc0 ("net/smc: add autocorking support")
)

I have used the net-next tree from next-20220301 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2022-02-09 23:59 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2022-02-09 23:59 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Hariprasad Kelam, Sunil Kovvuri Goutham, Sunil Kumar Kori,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/bitmap.h:9,
                 from include/linux/cpumask.h:12,
                 from arch/x86/include/asm/cpumask.h:5,
                 from arch/x86/include/asm/msr.h:11,
                 from arch/x86/include/asm/processor.h:22,
                 from arch/x86/include/asm/timex.h:5,
                 from include/linux/timex.h:65,
                 from include/linux/time32.h:13,
                 from include/linux/time.h:60,
                 from include/linux/skbuff.h:15,
                 from include/linux/if_ether.h:19,
                 from include/linux/etherdevice.h:20,
                 from drivers/net/ethernet/marvell/octeontx2/af/mbox.h:11,
                 from drivers/net/ethernet/marvell/octeontx2/af/cgx.h:11,
                 from drivers/net/ethernet/marvell/octeontx2/af/rpm.c:8:
drivers/net/ethernet/marvell/octeontx2/af/rpm.c: In function 'rpm_cfg_pfc_quanta_thresh':
include/linux/find.h:40:23: error: array subscript 'long unsigned int[0]' is partly outside array bounds of 'u16[1]' {aka 'short unsigned int[1]'} [-Werror=array-bounds]
   40 |                 val = *addr & GENMASK(size - 1, offset);
      |                       ^~~~~
drivers/net/ethernet/marvell/octeontx2/af/rpm.c:144:68: note: while referencing 'pfc_en'
  144 | static void rpm_cfg_pfc_quanta_thresh(rpm_t *rpm, int lmac_id, u16 pfc_en,
      |                                                                ~~~~^~~~~~

Caused by commit

  1121f6b02e7a ("octeontx2-af: Priority flow control configuration support")

I have used the net-next tree frm next-20220209 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-28  1:56 Stephen Rothwell
  2021-10-28  7:45 ` Saeed Mahameed
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-28  1:56 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Aharon Landau, Leon Romanovsky, Leon Romanovsky, Ben Ben-Ishay,
	Saeed Mahameed, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 5206 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.h:11,
                 from drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:48,
                 from drivers/net/ethernet/mellanox/mlx5/core/main.c:59:
drivers/net/ethernet/mellanox/mlx5/core/en.h:646:24: error: field 'mkey' has incomplete type
  646 |  struct mlx5_core_mkey mkey;
      |                        ^~~~
In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.h:11,
                 from drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:48,
                 from drivers/net/ethernet/mellanox/mlx5/core/eq.c:18:
drivers/net/ethernet/mellanox/mlx5/core/en.h:646:24: error: field 'mkey' has incomplete type
  646 |  struct mlx5_core_mkey mkey;
      |                        ^~~~
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c: In function 'mlx5e_build_shampo_hd_umr':
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c:547:45: error: request for member 'key' in something not a structure or union
  547 |  u32 lkey = rq->mdev->mlx5e_res.hw_objs.mkey.key;
      |                                             ^

Caused by commits

  e5ca8fb08ab2 ("net/mlx5e: Add control path for SHAMPO feature")
  64509b052525 ("net/mlx5e: Add data path for SHAMPO feature")

interacting with commit

  83fec3f12a59 ("RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key")

from the rmda tree.

I have applied the following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Oct 2021 12:36:29 +1100
Subject: [PATCH] fixup for "RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/en.h      |  2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 11 +++++------
 drivers/net/ethernet/mellanox/mlx5/core/en_rx.c   |  2 +-
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
index 5083a8a7eceb..f0ac6b0d9653 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
@@ -643,7 +643,7 @@ struct mlx5e_rq_frags_info {
 };
 
 struct mlx5e_shampo_hd {
-	struct mlx5_core_mkey mkey;
+	u32 mkey;
 	struct mlx5e_dma_info *info;
 	struct page *last_page;
 	u16 hd_per_wq;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 43b7a1e6a482..9febe4a916df 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -323,8 +323,7 @@ static int mlx5e_create_umr_mtt_mkey(struct mlx5_core_dev *mdev,
 }
 
 static int mlx5e_create_umr_klm_mkey(struct mlx5_core_dev *mdev,
-				     u64 nentries,
-				     struct mlx5_core_mkey *umr_mkey)
+				     u64 nentries, u32 *umr_mkey)
 {
 	int inlen;
 	void *mkc;
@@ -518,7 +517,7 @@ static int mlx5_rq_shampo_alloc(struct mlx5_core_dev *mdev,
 		goto err_hw_gro_data;
 	}
 	rq->mpwqe.shampo->key =
-		cpu_to_be32(rq->mpwqe.shampo->mkey.key);
+		cpu_to_be32(rq->mpwqe.shampo->mkey);
 	rq->mpwqe.shampo->hd_per_wqe =
 		mlx5e_shampo_hd_per_wqe(mdev, params, rqp);
 	wq_size = BIT(MLX5_GET(wq, wqc, log_wq_sz));
@@ -529,7 +528,7 @@ static int mlx5_rq_shampo_alloc(struct mlx5_core_dev *mdev,
 err_hw_gro_data:
 	mlx5e_rq_shampo_hd_info_free(rq);
 err_shampo_info:
-	mlx5_core_destroy_mkey(mdev, &rq->mpwqe.shampo->mkey);
+	mlx5_core_destroy_mkey(mdev, rq->mpwqe.shampo->mkey);
 err_shampo_hd:
 	mlx5e_rq_shampo_hd_free(rq);
 out:
@@ -543,7 +542,7 @@ static void mlx5e_rq_free_shampo(struct mlx5e_rq *rq)
 
 	kvfree(rq->hw_gro_data);
 	mlx5e_rq_shampo_hd_info_free(rq);
-	mlx5_core_destroy_mkey(rq->mdev, &rq->mpwqe.shampo->mkey);
+	mlx5_core_destroy_mkey(rq->mdev, rq->mpwqe.shampo->mkey);
 	mlx5e_rq_shampo_hd_free(rq);
 }
 
@@ -819,7 +818,7 @@ int mlx5e_create_rq(struct mlx5e_rq *rq, struct mlx5e_rq_param *param)
 	if (test_bit(MLX5E_RQ_STATE_SHAMPO, &rq->state)) {
 		MLX5_SET(wq, wq, log_headers_buffer_entry_num,
 			 order_base_2(rq->mpwqe.shampo->hd_per_wq));
-		MLX5_SET(wq, wq, headers_mkey, rq->mpwqe.shampo->mkey.key);
+		MLX5_SET(wq, wq, headers_mkey, rq->mpwqe.shampo->mkey);
 	}
 
 	mlx5_fill_page_frag_array(&rq->wq_ctrl.buf,
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
index fe979edd96dc..f63c8ff3ef3f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
@@ -544,7 +544,7 @@ static int mlx5e_build_shampo_hd_umr(struct mlx5e_rq *rq,
 {
 	struct mlx5e_shampo_hd *shampo = rq->mpwqe.shampo;
 	u16 entries, pi, i, header_offset, err, wqe_bbs, new_entries;
-	u32 lkey = rq->mdev->mlx5e_res.hw_objs.mkey.key;
+	u32 lkey = rq->mdev->mlx5e_res.hw_objs.mkey;
 	struct page *page = shampo->last_page;
 	u64 addr = shampo->last_addr;
 	struct mlx5e_dma_info *dma_info;
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-22  0:24 Stephen Rothwell
  2021-10-22 16:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-22  0:24 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Maor Gottlieb, Maor Dickman, Saeed Mahameed,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:71:10: fatal error: lag.h: No such file or directory
   71 | #include "lag.h"
      |          ^~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:13:10: fatal error: lag.h: No such file or directory
   13 | #include "lag.h"
      |          ^~~~~~~

Caused by commit

  3d677735d3b7 ("net/mlx5: Lag, move lag files into directory")

interacting with commit

  14fe2471c628 ("net/mlx5: Lag, change multipath and bonding to be mutually exclusive")

from the net tree.

I have applied the following merge fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 22 Oct 2021 11:10:06 +1100
Subject: [PATCH] fixup for "net/mlx5: Lag, move lag files into directory"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++--
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
index b7461c17d601..d7e613d0139a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
@@ -10,8 +10,8 @@
 #include "en_tc.h"
 #include "rep/tc.h"
 #include "rep/neigh.h"
-#include "lag.h"
-#include "lag_mp.h"
+#include "lag/lag.h"
+#include "lag/mp.h"
 
 struct mlx5e_tc_tun_route_attr {
 	struct net_device *out_dev;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 57369925a788..3af3da214a5b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -68,8 +68,8 @@
 #include "lib/fs_chains.h"
 #include "diag/en_tc_tracepoint.h"
 #include <asm/div64.h>
-#include "lag.h"
-#include "lag_mp.h"
+#include "lag/lag.h"
+#include "lag/mp.h"
 
 #define nic_chains(priv) ((priv)->fs.tc.chains)
 #define MLX5_MH_ACT_SZ MLX5_UN_SZ_BYTES(set_add_copy_action_in_auto)
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-11  6:34 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-11  6:34 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Jakub Kicinski, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

drivers/net/ethernet/sun/ldmvsw.c: In function 'vsw_alloc_netdev':
drivers/net/ethernet/sun/ldmvsw.c:243:2: error: expected ';' before 'sprintf'
  sprintf(dev->name, "vif%d.%d", (int)handle, (int)port_id);
  ^~~~~~~

Caused by commit

  a7639279c93c ("ethernet: sun: remove direct netdev->dev_addr writes")

I have applied the following fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 11 Oct 2021 17:24:43 +1100
Subject: [PATCH] ethernet: sun: fix for "remove direct netdev->dev_addr writes"

Fix for this build problem:

drivers/net/ethernet/sun/ldmvsw.c: In function 'vsw_alloc_netdev':
drivers/net/ethernet/sun/ldmvsw.c:243:2: error: expected ';' before 'sprintf'
  sprintf(dev->name, "vif%d.%d", (int)handle, (int)port_id);
  ^~~~~~~

Fixes: a7639279c93c ("ethernet: sun: remove direct netdev->dev_addr writes")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/sun/ldmvsw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c
index 074c5407c86b..6b59b14e74b1 100644
--- a/drivers/net/ethernet/sun/ldmvsw.c
+++ b/drivers/net/ethernet/sun/ldmvsw.c
@@ -238,7 +238,7 @@ static struct net_device *vsw_alloc_netdev(u8 hwaddr[],
 	dev->needed_tailroom = 8;
 
 	eth_hw_addr_set(dev, hwaddr);
-	ether_addr_copy(dev->perm_addr, dev->dev_addr)
+	ether_addr_copy(dev->perm_addr, dev->dev_addr);
 
 	sprintf(dev->name, "vif%d.%d", (int)handle, (int)port_id);
 
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-08  5:21 Stephen Rothwell
  2021-10-08  5:52 ` Kalle Valo
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-08  5:21 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Jouni Malinen, Kalle Valo, Pradeep Kumar Chitrapu,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (xtensa,
m68k allmodconfig) failed like this:

In file included from <command-line>:0:0:
In function 'ath11k_peer_assoc_h_smps',
    inlined from 'ath11k_peer_assoc_prepare' at drivers/net/wireless/ath/ath11k/mac.c:2362:2:
include/linux/compiler_types.h:317:38: error: call to '__compiletime_assert_650' declared with attribute error: FIELD_GET: type of reg too small for mask
  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                      ^
include/linux/compiler_types.h:298:4: note: in definition of macro '__compiletime_assert'
    prefix ## suffix();    \
    ^
include/linux/compiler_types.h:317:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
  ^
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^
include/linux/bitfield.h:52:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   BUILD_BUG_ON_MSG((_mask) > (typeof(_reg))~0ull,  \
   ^
include/linux/bitfield.h:108:3: note: in expansion of macro '__BF_FIELD_CHECK'
   __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET: "); \
   ^
drivers/net/wireless/ath/ath11k/mac.c:2079:10: note: in expansion of macro 'FIELD_GET'
   smps = FIELD_GET(IEEE80211_HE_6GHZ_CAP_SM_PS,
          ^

Caused by commit

  6f4d70308e5e ("ath11k: support SMPS configuration for 6 GHz")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-06  1:23 Stephen Rothwell
  2021-10-06  1:52 ` Jakub Kicinski
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-06  1:23 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Jakub Kicinski, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2078 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/toshiba/ps3_gelic_net.c: In function 'gelic_net_setup_netdev':
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1480:26: error: passing argument 2 of 'eth_hw_addr_set' from incompatible pointer type [-Werror=incompatible-pointer-types]
 1480 |  eth_hw_addr_set(netdev, &v1);
      |                          ^~~
      |                          |
      |                          u64 * {aka long long unsigned int *}
In file included from drivers/net/ethernet/toshiba/ps3_gelic_net.c:23:
include/linux/etherdevice.h:309:70: note: expected 'const u8 *' {aka 'const unsigned char *'} but argument is of type 'u64 *' {aka 'long long unsigned int *'}
  309 | static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
      |                                                            ~~~~~~~~~~^~~~

Caused by commit

  a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 6 Oct 2021 12:19:08 +1100
Subject: [PATCH] ethernet: fix up ps3_gelic_net.c for "ethernet: use
 eth_hw_addr_set()"

Fixes: a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index 1425623b868e..3dbfb1b20649 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1477,7 +1477,7 @@ int gelic_net_setup_netdev(struct net_device *netdev, struct gelic_card *card)
 			 __func__, status);
 		return -EINVAL;
 	}
-	eth_hw_addr_set(netdev, &v1);
+	eth_hw_addr_set(netdev, (u8 *)&v1);
 
 	if (card->vlan_required) {
 		netdev->hard_header_len += VLAN_HLEN;
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-05  0:56 Stephen Rothwell
  2021-10-05  1:24 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-05  0:56 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Jakub Kicinski, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_setup_single_port':
drivers/net/ethernet/ibm/ehea/ehea_main.c:2989:23: error: passing argument 2 of 'eth_hw_addr_set' from incompatible pointer type [-Werror=incompatible-pointer-types]
 2989 |  eth_hw_addr_set(dev, &port->mac_addr);
      |                       ^~~~~~~~~~~~~~~
      |                       |
      |                       u64 * {aka long long unsigned int *}
In file included from include/linux/if_vlan.h:11,
                 from include/linux/filter.h:19,
                 from include/net/sock.h:59,
                 from include/linux/tcp.h:19,
                 from drivers/net/ethernet/ibm/ehea/ehea_main.c:20:
include/linux/etherdevice.h:309:70: note: expected 'const u8 *' {aka 'const unsigned char *'} but argument is of type 'u64 *' {aka 'long long unsigned int *'}
  309 | static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
      |                                                            ~~~~~~~~~~^~~~
cc1: some warnings being treated as errors

Caused by commit

  a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")

I have used the net-next tree from next-20211001 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-10-01  6:18 Stephen Rothwell
  2021-10-01 13:40 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-10-01  6:18 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Eric Dumazet, Wei Wang, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 3133 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

net/core/sock.c: In function 'sock_setsockopt':
net/core/sock.c:1417:7: error: 'SO_RESERVE_MEM' undeclared (first use in this function); did you mean 'IORESOURCE_MEM'?
  case SO_RESERVE_MEM:
       ^~~~~~~~~~~~~~
       IORESOURCE_MEM
net/core/sock.c:1417:7: note: each undeclared identifier is reported only once for each function it appears in
net/core/sock.c: In function 'sock_getsockopt':
net/core/sock.c:1817:7: error: 'SO_RESERVE_MEM' undeclared (first use in this function); did you mean 'IORESOURCE_MEM'?
  case SO_RESERVE_MEM:
       ^~~~~~~~~~~~~~
       IORESOURCE_MEM

Caused by commit

  2bb2f5fb21b0 ("net: add new socket option SO_RESERVE_MEM")

arch/sparc/include/uapi/socket.h does not include uapi/asm/socket.h and
some other architectures do not as well.

I have added the following patch for today (I searched for SO_BUF_LOCK
and, of these architectures, I have only compile tested sparc64 and
sparc):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 1 Oct 2021 15:51:50 +1000
Subject: [PATCH] fix up for "net: add new socket option SO_RESERVE_MEM"

Some architectures do not include uapi/asm/socket.h

Fixes: 2bb2f5fb21b0 ("net: add new socket option SO_RESERVE_MEM")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/alpha/include/uapi/asm/socket.h  | 2 ++
 arch/mips/include/uapi/asm/socket.h   | 2 ++
 arch/parisc/include/uapi/asm/socket.h | 2 ++
 arch/sparc/include/uapi/asm/socket.h  | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/arch/alpha/include/uapi/asm/socket.h b/arch/alpha/include/uapi/asm/socket.h
index 1dd9baf4a6c2..284d28755b8d 100644
--- a/arch/alpha/include/uapi/asm/socket.h
+++ b/arch/alpha/include/uapi/asm/socket.h
@@ -131,6 +131,8 @@
 
 #define SO_BUF_LOCK		72
 
+#define SO_RESERVE_MEM		73
+
 #if !defined(__KERNEL__)
 
 #if __BITS_PER_LONG == 64
diff --git a/arch/mips/include/uapi/asm/socket.h b/arch/mips/include/uapi/asm/socket.h
index 1eaf6a1ca561..24e0efb360f6 100644
--- a/arch/mips/include/uapi/asm/socket.h
+++ b/arch/mips/include/uapi/asm/socket.h
@@ -142,6 +142,8 @@
 
 #define SO_BUF_LOCK		72
 
+#define SO_RESERVE_MEM		73
+
 #if !defined(__KERNEL__)
 
 #if __BITS_PER_LONG == 64
diff --git a/arch/parisc/include/uapi/asm/socket.h b/arch/parisc/include/uapi/asm/socket.h
index 8baaad52d799..845ddc63c882 100644
--- a/arch/parisc/include/uapi/asm/socket.h
+++ b/arch/parisc/include/uapi/asm/socket.h
@@ -123,6 +123,8 @@
 
 #define SO_BUF_LOCK		0x4046
 
+#define SO_RESERVE_MEM		0x4047
+
 #if !defined(__KERNEL__)
 
 #if __BITS_PER_LONG == 64
diff --git a/arch/sparc/include/uapi/asm/socket.h b/arch/sparc/include/uapi/asm/socket.h
index e80ee8641ac3..9e9ceee6358f 100644
--- a/arch/sparc/include/uapi/asm/socket.h
+++ b/arch/sparc/include/uapi/asm/socket.h
@@ -124,6 +124,8 @@
 
 #define SO_BUF_LOCK              0x0051
 
+#define SO_RESERVE_MEM           0x0052
+
 #if !defined(__KERNEL__)
 
 
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-09-14  2:15 Stephen Rothwell
  2021-09-16  9:03 ` Masahiro Yamada
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-09-14  2:15 UTC (permalink / raw)
  To: David Miller, Networking, Masahiro Yamada
  Cc: Alexey Dobriyan, M Chetan Kumar, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/net/wwan/iosm/iosm_ipc_task_queue.c:6:
drivers/net/wwan/iosm/iosm_ipc_imem.h:10:10: fatal error: stdbool.h: No such file or directory
   10 | #include <stdbool.h>
      |          ^~~~~~~~~~~
In file included from drivers/net/wwan/iosm/iosm_ipc_protocol.h:9,
                 from drivers/net/wwan/iosm/iosm_ipc_mux.h:9,
                 from drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.h:9,
                 from drivers/net/wwan/iosm/iosm_ipc_imem_ops.c:8:
drivers/net/wwan/iosm/iosm_ipc_imem.h:10:10: fatal error: stdbool.h: No such file or directory
   10 | #include <stdbool.h>
      |          ^~~~~~~~~~~
In file included from drivers/net/wwan/iosm/iosm_ipc_protocol.h:9,
                 from drivers/net/wwan/iosm/iosm_ipc_mux.h:9,
                 from drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.h:9,
                 from drivers/net/wwan/iosm/iosm_ipc_imem.c:8:
drivers/net/wwan/iosm/iosm_ipc_imem.h:10:10: fatal error: stdbool.h: No such file or directory
   10 | #include <stdbool.h>
      |          ^~~~~~~~~~~

Caused by commit

  13bb8429ca98 ("net: wwan: iosm: firmware flashing and coredump collection")

interacting with commit

  0666a64a1f48 ("isystem: delete global -isystem compile option")

from the kbuild tree.

I have reverted the kbuild tree commit for today.  Please provide a
merge resolution patch.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-09-01  6:38 Stephen Rothwell
  2021-09-01  6:54 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-09-01  6:38 UTC (permalink / raw)
  To: David Miller, Networking, Linus Torvalds
  Cc: Konrad Rzeszutek Wilk, Maurizio Lombardi,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (X86_64
allnoconfig) failed like this:

arch/x86/kernel/setup.c: In function 'setup_arch':
arch/x86/kernel/setup.c:916:6: error: implicit declaration of function 'acpi_mps_check' [-Werror=implicit-function-declaration]
  916 |  if (acpi_mps_check()) {
      |      ^~~~~~~~~~~~~~
arch/x86/kernel/setup.c:1110:2: error: implicit declaration of function 'acpi_table_upgrade' [-Werror=implicit-function-declaration]
 1110 |  acpi_table_upgrade();
      |  ^~~~~~~~~~~~~~~~~~
arch/x86/kernel/setup.c:1112:2: error: implicit declaration of function 'acpi_boot_table_init' [-Werror=implicit-function-declaration]
 1112 |  acpi_boot_table_init();
      |  ^~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/setup.c:1120:2: error: implicit declaration of function 'early_acpi_boot_init'; did you mean 'early_cpu_init'? [-Werror=implicit-function-declaration]
 1120 |  early_acpi_boot_init();
      |  ^~~~~~~~~~~~~~~~~~~~
      |  early_cpu_init
arch/x86/kernel/setup.c:1162:2: error: implicit declaration of function 'acpi_boot_init' [-Werror=implicit-function-declaration]
 1162 |  acpi_boot_init();
      |  ^~~~~~~~~~~~~~

Caused by commit

  342f43af70db ("iscsi_ibft: fix crash due to KASLR physical memory remapping")

Unfortunately that commit has now been merged into Linus' tree as well.

I have added the following fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 1 Sep 2021 16:31:32 +1000
Subject: [PATCH] x86: include acpi.h when using acpi functions

The removal of the include of linux/acpi.h from include/linux/iscsi_ibft.h
by commit

  342f43af70db ("iscsi_ibft: fix crash due to KASLR physical memory remapping")

exposed this build failure.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/kernel/setup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 63b20536c8d2..da0a4b64880f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -13,6 +13,7 @@
 #include <linux/init_ohci1394_dma.h>
 #include <linux/initrd.h>
 #include <linux/iscsi_ibft.h>
+#include <linux/acpi.h>
 #include <linux/memblock.h>
 #include <linux/panic_notifier.h>
 #include <linux/pci.h>
-- 
2.32.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-08-27  2:22 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2021-08-27  2:22 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Loic Poulain, Jakub Kicinski, Kalle Valo,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1915 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/wwan/mhi_wwan_mbim.c: In function 'mhi_mbim_probe':
drivers/net/wwan/mhi_wwan_mbim.c:612:8: error: too many arguments to function 'mhi_prepare_for_transfer'
  612 |  err = mhi_prepare_for_transfer(mhi_dev, 0);
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wwan/mhi_wwan_mbim.c:18:
include/linux/mhi.h:725:5: note: declared here
  725 | int mhi_prepare_for_transfer(struct mhi_device *mhi_dev);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commits

  aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")
  ab996c420508 ("wwan: mhi: Fix build.")
  a85b99ab6abb ("Revert "wwan: mhi: Fix build."")
  0ca8d3ca4561 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")

interacting with commit

  9ebc2758d0bb ("Revert "net: really fix the build..."")

from Linus' tree.

I have applied the following merge fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 27 Aug 2021 12:02:29 +1000
Subject: [PATCH] fix for commit 9ebc2758d0bb "Revert "net: really fix the build...""

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/wwan/mhi_wwan_mbim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
index 377529bbf124..71bf9b4f769f 100644
--- a/drivers/net/wwan/mhi_wwan_mbim.c
+++ b/drivers/net/wwan/mhi_wwan_mbim.c
@@ -609,7 +609,7 @@ static int mhi_mbim_probe(struct mhi_device *mhi_dev, const struct mhi_device_id
 	INIT_DELAYED_WORK(&mbim->rx_refill, mhi_net_rx_refill_work);
 
 	/* Start MHI channels */
-	err = mhi_prepare_for_transfer(mhi_dev, 0);
+	err = mhi_prepare_for_transfer(mhi_dev);
 	if (err)
 		return err;
 
-- 
2.32.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-08-23  2:09 Stephen Rothwell
  2021-08-23  6:34 ` Heiner Kallweit
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-08-23  2:09 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Heiner Kallweit, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/broadcom/bnx2.c: In function 'bnx2_read_vpd_fw_ver':
drivers/net/ethernet/broadcom/bnx2.c:8055:6: error: implicit declaration of function 'pci_vpd_find_ro_info_keyword'; did you mean 'pci_vpd_find_info_keyword'? [-Werror=implicit-function-declaration]
 8055 |  j = pci_vpd_find_ro_info_keyword(data, BNX2_VPD_LEN,
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |      pci_vpd_find_info_keyword

Caused by commit

  ddc122aac91f ("bnx2: Search VPD with pci_vpd_find_ro_info_keyword()")

I have used the net-next tree from next-20210820 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-08-05 12:01 Mark Brown
  2021-08-05 12:12 ` David Miller
  2021-08-05 12:34 ` Loic Poulain
  0 siblings, 2 replies; 394+ messages in thread
From: Mark Brown @ 2021-08-05 12:01 UTC (permalink / raw)
  To: Loic Poulain, David S . Miller
  Cc: netdev, Linux Kernel Mailing List, Linux Next Mailing List

Hi all,

After merging the mac80211-next tree, today's linux-next build
(x86 allmodconfig) failed like this:

/tmp/next/build/drivers/net/wwan/mhi_wwan_mbim.c: In function 'mhi_mbim_probe':
/tmp/next/build/drivers/net/wwan/mhi_wwan_mbim.c:611:8: error: too few arguments to function 'mhi_prepare_for_transfer'
  err = mhi_prepare_for_transfer(mhi_dev);
        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/next/build/drivers/net/wwan/mhi_wwan_mbim.c:18:
/tmp/next/build/include/linux/mhi.h:726:5: note: declared here
 int mhi_prepare_for_transfer(struct mhi_device *mhi_dev,
     ^~~~~~~~~~~~~~~~~~~~~~~~


Caused by commit

   aa730a9905b7b079ef2ff ("net: wwan: Add MHI MBIM network driver")

That API has been modified in ce78ffa3ef16810 ("net: really fix the
build...") in the net tree.  I've used the net-next tree from yesterday.

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-07-21  1:26 Stephen Rothwell
  2021-07-21 10:30 ` Vladimir Oltean
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-07-21  1:26 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Vladimir Oltean, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 3076 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/net/dsa.h:23,
                 from net/ethernet/eth.c:59:
include/net/switchdev.h:410:1: error: expected identifier or '(' before '{' token
  410 | {
      | ^
include/net/switchdev.h:399:1: warning: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined [-Wunused-function]
  399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/net/dsa.h:23,
                 from net/core/flow_dissector.c:8:
include/net/switchdev.h:410:1: error: expected identifier or '(' before '{' token
  410 | {
      | ^
include/net/switchdev.h:399:1: warning: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined [-Wunused-function]
  399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/net/dsa.h:23,
                 from net/core/dev.c:102:
include/net/switchdev.h:410:1: error: expected identifier or '(' before '{' token
  410 | {
      | ^
include/net/switchdev.h:399:1: warning: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined [-Wunused-function]
  399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/net/vxlan.h:9,
                 from drivers/net/ethernet/emulex/benet/be_main.c:22:
include/net/switchdev.h:410:1: error: expected identifier or '(' before '{' token
  410 | {
      | ^
include/net/switchdev.h:399:1: warning: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined [-Wunused-function]
  399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/net/vxlan.h:9,
                 from drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:37:
include/net/switchdev.h:410:1: error: expected identifier or '(' before '{' token
  410 | {
      | ^
include/net/switchdev.h:399:1: warning: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined [-Wunused-function]
  399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/net/vxlan.h:9,
                 from drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:50:
include/net/switchdev.h:410:1: error: expected identifier or '(' before '{' token
  410 | {
      | ^
include/net/switchdev.h:399:1: warning: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined [-Wunused-function]
  399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  8ca07176ab00 ("net: switchdev: introduce a fanout helper for SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE")

I have used the net-next tree from next-20210720 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-06-23 22:29 Stephen Rothwell
  2021-06-23 22:46 ` Marcin Wojtas
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-06-23 22:29 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Marcin Wojtas

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

Hi all,

Today's linux-next build (x86_64 modules_install) failed like this:

depmod: ../tools/depmod.c:1792: depmod_report_cycles_from_root: Assertion `is < stack_size' failed.

Caused by commit

62a6ef6a996f ("net: mdiobus: Introduce fwnode_mdbiobus_register()")

(I bisected to there and tested the commit before.)

The actual build is an x86_64 allmodconfig, followed by a
modules_install.  This happens in my cross build environment as well as
a native build.

$ gcc --version
gcc (Debian 10.2.1-6) 10.2.1 20210110
$ ld --version
GNU ld (GNU Binutils for Debian) 2.35.2
$ /sbin/depmod --version
kmod version 28
-ZSTD +XZ -ZLIB +LIBCRYPTO -EXPERIMENTAL

I have no idea why that commit should caused this failure.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-05-14  3:40 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2021-05-14  3:40 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linus Lüssing, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
pseries_le_defconfig) failed like this:

net/bridge/br_multicast.c: In function '__br_multicast_enable_port':
net/bridge/br_multicast.c:1743:3: error: implicit declaration of function 'br_ip6_multicast_add_router'; did you mean 'br_ip4_multicast_add_router'? [-Werror=implicit-function-declaration]
 1743 |   br_ip6_multicast_add_router(br, port);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   br_ip4_multicast_add_router
net/bridge/br_multicast.c: At top level:
net/bridge/br_multicast.c:2804:13: warning: conflicting types for 'br_ip6_multicast_add_router'
 2804 | static void br_ip6_multicast_add_router(struct net_bridge *br,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
net/bridge/br_multicast.c:2804:13: error: static declaration of 'br_ip6_multicast_add_router' follows non-static declaration
net/bridge/br_multicast.c:1743:3: note: previous implicit declaration of 'br_ip6_multicast_add_router' was here
 1743 |   br_ip6_multicast_add_router(br, port);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  a3c02e769efe ("net: bridge: mcast: split multicast router state for IPv4 and IPv6")

# CONFIG_IPV6 is not set

I have reverted that commit for today (along with commit

  3b85f9ba3480 ("net: bridge: mcast: export multicast router presence adjacent to a port")

in case it depends on a3c02e769efe).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-05-11 23:52 Stephen Rothwell
  2021-05-11 23:54 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-05-11 23:52 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/usb/class/cdc-wdm.c: In function 'wdm_wwan_port_stop':
drivers/usb/class/cdc-wdm.c:858:2: error: implicit declaration of function 'kill_urbs' [-Werror=implicit-function-declaration]
  858 |  kill_urbs(desc);
      |  ^~~~~~~~~

Caused by commit

  cac6fb015f71 ("usb: class: cdc-wdm: WWAN framework integration")

kill_urbs() was removed by commit

  18abf8743674 ("cdc-wdm: untangle a circular dependency between callback and softint")

Which is included in v5.13-rc1.

I have used the net-next tree from next-20210511 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-04-12  5:04 Stephen Rothwell
  2021-04-12  9:02 ` Florian Westphal
  2021-04-12 13:25 ` Pablo Neira Ayuso
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2021-04-12  5:04 UTC (permalink / raw)
  To: David Miller, Networking, Pablo Neira Ayuso, NetFilter
  Cc: Florian Westphal, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 7391 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/asm-generic/bug.h:20,
                 from arch/x86/include/asm/bug.h:93,
                 from include/linux/bug.h:5,
                 from include/linux/mmdebug.h:5,
                 from include/linux/gfp.h:5,
                 from include/linux/umh.h:4,
                 from include/linux/kmod.h:9,
                 from net/bridge/netfilter/ebtables.c:14:
net/bridge/netfilter/ebtables.c: In function '__ebt_find_table':
net/bridge/netfilter/ebtables.c:1248:33: error: 'struct netns_xt' has no member named 'tables'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |                                 ^
include/linux/kernel.h:708:26: note: in definition of macro 'container_of'
  708 |  void *__mptr = (void *)(ptr);     \
      |                          ^~~
include/linux/list.h:522:2: note: in expansion of macro 'list_entry'
  522 |  list_entry((ptr)->next, type, member)
      |  ^~~~~~~~~~
include/linux/list.h:628:13: note: in expansion of macro 'list_first_entry'
  628 |  for (pos = list_first_entry(head, typeof(*pos), member); \
      |             ^~~~~~~~~~~~~~~~
net/bridge/netfilter/ebtables.c:1248:2: note: in expansion of macro 'list_for_each_entry'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |  ^~~~~~~~~~~~~~~~~~~
In file included from <command-line>:
net/bridge/netfilter/ebtables.c:1248:33: error: 'struct netns_xt' has no member named 'tables'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |                                 ^
include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert'
  300 |   if (!(condition))     \
      |         ^~~~~~~~~
include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert'
  320 |  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |  ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  709 |  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
      |  ^~~~~~~~~~~~~~~~
include/linux/kernel.h:709:20: note: in expansion of macro '__same_type'
  709 |  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
      |                    ^~~~~~~~~~~
include/linux/list.h:511:2: note: in expansion of macro 'container_of'
  511 |  container_of(ptr, type, member)
      |  ^~~~~~~~~~~~
include/linux/list.h:522:2: note: in expansion of macro 'list_entry'
  522 |  list_entry((ptr)->next, type, member)
      |  ^~~~~~~~~~
include/linux/list.h:628:13: note: in expansion of macro 'list_first_entry'
  628 |  for (pos = list_first_entry(head, typeof(*pos), member); \
      |             ^~~~~~~~~~~~~~~~
net/bridge/netfilter/ebtables.c:1248:2: note: in expansion of macro 'list_for_each_entry'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |  ^~~~~~~~~~~~~~~~~~~
net/bridge/netfilter/ebtables.c:1248:33: error: 'struct netns_xt' has no member named 'tables'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |                                 ^
include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert'
  300 |   if (!(condition))     \
      |         ^~~~~~~~~
include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert'
  320 |  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |  ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  709 |  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
      |  ^~~~~~~~~~~~~~~~
include/linux/kernel.h:710:6: note: in expansion of macro '__same_type'
  710 |     !__same_type(*(ptr), void),   \
      |      ^~~~~~~~~~~
include/linux/list.h:511:2: note: in expansion of macro 'container_of'
  511 |  container_of(ptr, type, member)
      |  ^~~~~~~~~~~~
include/linux/list.h:522:2: note: in expansion of macro 'list_entry'
  522 |  list_entry((ptr)->next, type, member)
      |  ^~~~~~~~~~
include/linux/list.h:628:13: note: in expansion of macro 'list_first_entry'
  628 |  for (pos = list_first_entry(head, typeof(*pos), member); \
      |             ^~~~~~~~~~~~~~~~
net/bridge/netfilter/ebtables.c:1248:2: note: in expansion of macro 'list_for_each_entry'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |  ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/preempt.h:11,
                 from include/linux/spinlock.h:51,
                 from include/linux/mmzone.h:8,
                 from include/linux/gfp.h:6,
                 from include/linux/umh.h:4,
                 from include/linux/kmod.h:9,
                 from net/bridge/netfilter/ebtables.c:14:
net/bridge/netfilter/ebtables.c:1248:33: error: 'struct netns_xt' has no member named 'tables'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |                                 ^
include/linux/list.h:619:20: note: in definition of macro 'list_entry_is_head'
  619 |  (&pos->member == (head))
      |                    ^~~~
net/bridge/netfilter/ebtables.c:1248:2: note: in expansion of macro 'list_for_each_entry'
 1248 |  list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
      |  ^~~~~~~~~~~~~~~~~~~

Caused by commit

  5b53951cfc85 ("netfilter: ebtables: use net_generic infra")

interacting with commit

  7ee3c61dcd28 ("netfilter: bridge: add pre_exit hooks for ebtable unregistration")

from the netfilter tree.

I have applied the following merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 12 Apr 2021 14:58:20 +1000
Subject: [PATCH] merger fix for "netfilter: bridge: add pre_exit hooks for
 ebtable unregistration"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/bridge/netfilter/ebtables.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index bbc46149bbb2..96d789c8d1c7 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -1241,11 +1241,12 @@ int ebt_register_table(struct net *net, const struct ebt_table *input_table,
 
 static struct ebt_table *__ebt_find_table(struct net *net, const char *name)
 {
+	struct ebt_pernet *ebt_net = net_generic(net, ebt_pernet_id);
 	struct ebt_table *t;
 
 	mutex_lock(&ebt_mutex);
 
-	list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
+	list_for_each_entry(t, &ebt_net->tables, list) {
 		if (strcmp(t->name, name) == 0) {
 			mutex_unlock(&ebt_mutex);
 			return t;
-- 
2.30.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2021-02-04  1:33 Stephen Rothwell
  2021-02-04  3:52 ` Brian Vazquez
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2021-02-04  1:33 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Brian Vazquez, Jakub Kicinski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: modpost: "ip6_dst_check" [vmlinux] is a static EXPORT_SYMBOL
ERROR: modpost: "ipv4_dst_check" [vmlinux] is a static EXPORT_SYMBOL
ERROR: modpost: "ipv4_mtu" [vmlinux] is a static EXPORT_SYMBOL
ERROR: modpost: "ip6_mtu" [vmlinux] is a static EXPORT_SYMBOL

Caused by commits

  f67fbeaebdc0 ("net: use indirect call helpers for dst_mtu")
  bbd807dfbf20 ("net: indirect call helpers for ipv4/ipv6 dst_check functions")

I have used the net-next tree from next-20210203 fot today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-12-14  2:14 Stephen Rothwell
  2020-12-16  1:03 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2020-12-14  2:14 UTC (permalink / raw)
  To: David Miller, Networking, Jakub Kicinski, Steve French
  Cc: Samuel Cabrero, Francis Laniel, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/cifs/cifs_swn.c: In function 'cifs_swn_notify':
fs/cifs/cifs_swn.c:450:4: error: implicit declaration of function 'nla_strlcpy'; did you mean 'nla_strscpy'? [-Werror=implicit-function-declaration]
  450 |    nla_strlcpy(name, info->attrs[CIFS_GENL_ATTR_SWN_RESOURCE_NAME],
      |    ^~~~~~~~~~~
      |    nla_strscpy

Caused by commit

  872f69034194 ("treewide: rename nla_strlcpy to nla_strscpy.")

interacting with commit

  27228d73f4d2 ("cifs: Set witness notification handler for messages from userspace daemon")

from the cifs tree.

I have applied the following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 14 Dec 2020 13:09:27 +1100
Subject: [PATCH] fixup for "treewide: rename nla_strlcpy to nla_strscpy."

conflicting with

"cifs: Set witness notification handler for messages from userspace daemon"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/cifs/cifs_swn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/cifs_swn.c b/fs/cifs/cifs_swn.c
index 642c9eedc8ab..d762d442dfa5 100644
--- a/fs/cifs/cifs_swn.c
+++ b/fs/cifs/cifs_swn.c
@@ -447,7 +447,7 @@ int cifs_swn_notify(struct sk_buff *skb, struct genl_info *info)
 		int state;
 
 		if (info->attrs[CIFS_GENL_ATTR_SWN_RESOURCE_NAME]) {
-			nla_strlcpy(name, info->attrs[CIFS_GENL_ATTR_SWN_RESOURCE_NAME],
+			nla_strscpy(name, info->attrs[CIFS_GENL_ATTR_SWN_RESOURCE_NAME],
 					sizeof(name));
 		} else {
 			cifs_dbg(FYI, "%s: missing resource name attribute\n", __func__);
-- 
2.29.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-12-02  1:38 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2020-12-02  1:38 UTC (permalink / raw)
  To: David Miller, Networking, Jakub Kicinski
  Cc: Björn Töpel, Daniel Borkmann, Jesper Dangaard Brouer,
	Lorenzo Bianconi, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/core/xdp.c: In function 'xdp_return_frame_bulk':
net/core/xdp.c:417:3: error: too few arguments to function '__xdp_return'
  417 |   __xdp_return(xdpf->data, &xdpf->mem, false);
      |   ^~~~~~~~~~~~
net/core/xdp.c:340:13: note: declared here
  340 | static void __xdp_return(void *data, struct xdp_mem_info *mem, bool napi_direct,
      |             ^~~~~~~~~~~~

Caused by commit

  8965398713d8 ("net: xdp: Introduce bulking for xdp tx return path")

interacting with commit

  ed1182dc004d ("xdp: Handle MEM_TYPE_XSK_BUFF_POOL correctly in xdp_return_buff()")

from the bpf tree.

I applied the following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 2 Dec 2020 12:33:14 +1100
Subject: [PATCH] fix up for "xdp: Handle MEM_TYPE_XSK_BUFF_POOL correctly in
 xdp_return_buff()"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/core/xdp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/xdp.c b/net/core/xdp.c
index f2cdacd81d43..3100f9711eae 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -414,7 +414,7 @@ void xdp_return_frame_bulk(struct xdp_frame *xdpf,
 	struct xdp_mem_allocator *xa;
 
 	if (mem->type != MEM_TYPE_PAGE_POOL) {
-		__xdp_return(xdpf->data, &xdpf->mem, false);
+		__xdp_return(xdpf->data, &xdpf->mem, false, NULL);
 		return;
 	}
 
-- 
2.29.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-10-06  3:58 Stephen Rothwell
  2020-10-06  5:13 ` Christoph Hellwig
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2020-10-06  3:58 UTC (permalink / raw)
  To: David Miller, Networking, Christoph Hellwig
  Cc: Linux Kernel Mailing List, Linux Next Mailing List,
	Daniel Borkmann, Magnus Karlsson

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/xdp/xsk_buff_pool.c:7:10: fatal error: linux/dma-noncoherent.h: No such file or directory
    7 | #include <linux/dma-noncoherent.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")

interacting with commit

  a3cf77774abf ("dma-mapping: merge <linux/dma-noncoherent.h> into <linux/dma-map-ops.h>")

from the dma-mapping tree.

I have applied teh following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 6 Oct 2020 14:53:30 +1100
Subject: [PATCH] xsk: fix up for "dma-mapping: merge <linux/dma-noncoherent.h>
 into <linux/dma-map-ops.h>"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/xdp/xsk_buff_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
index e63fadd000db..dbed16648607 100644
--- a/net/xdp/xsk_buff_pool.c
+++ b/net/xdp/xsk_buff_pool.c
@@ -4,7 +4,7 @@
 #include <net/xdp_sock.h>
 #include <net/xdp_sock_drv.h>
 #include <linux/dma-direct.h>
-#include <linux/dma-noncoherent.h>
+#include <linux/dma-map-ops.h>
 #include <linux/swiotlb.h>
 
 #include "xsk_queue.h"
-- 
2.28.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-09-29  3:04 Stephen Rothwell
  2020-09-30 22:09 ` Stephen Rothwell
  2020-10-02  1:40 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2020-09-29  3:04 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Vadym Kochan, Taehee Yoo, Linux Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 4112 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/marvell/prestera/prestera_main.c: In function 'prestera_port_dev_lower_find':
drivers/net/ethernet/marvell/prestera/prestera_main.c:504:33: error: passing argument 2 of 'netdev_walk_all_lower_dev' from incompatible pointer type [-Werror=incompatible-pointer-types]
  504 |  netdev_walk_all_lower_dev(dev, prestera_lower_dev_walk, &port);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~
      |                                 |
      |                                 int (*)(struct net_device *, void *)
In file included from include/linux/etherdevice.h:21,
                 from drivers/net/ethernet/marvell/prestera/prestera_main.c:4:
include/linux/netdevice.h:4571:16: note: expected 'int (*)(struct net_device *, struct netdev_nested_priv *)' but argument is of type 'int (*)(struct net_device *, void *)'
 4571 |          int (*fn)(struct net_device *lower_dev,
      |          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 4572 |      struct netdev_nested_priv *priv),
      |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_main.c:504:58: error: passing argument 3 of 'netdev_walk_all_lower_dev' from incompatible pointer type [-Werror=incompatible-pointer-types]
  504 |  netdev_walk_all_lower_dev(dev, prestera_lower_dev_walk, &port);
      |                                                          ^~~~~
      |                                                          |
      |                                                          struct prestera_port **
In file included from include/linux/etherdevice.h:21,
                 from drivers/net/ethernet/marvell/prestera/prestera_main.c:4:
include/linux/netdevice.h:4573:37: note: expected 'struct netdev_nested_priv *' but argument is of type 'struct prestera_port **'
 4573 |          struct netdev_nested_priv *priv);
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors

Caused by commit

  eff7423365a6 ("net: core: introduce struct netdev_nested_priv for nested interface infrastructure")

interacting with commit

  e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation")

also in the net-next tree.

I applied the following fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 Sep 2020 12:57:59 +1000
Subject: [PATCH] fix up for "net: core: introduce struct netdev_nested_priv for nested interface infrastructure"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 9bd57b89d1d0..633d8770be35 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -482,9 +482,10 @@ bool prestera_netdev_check(const struct net_device *dev)
 	return dev->netdev_ops == &prestera_netdev_ops;
 }
 
-static int prestera_lower_dev_walk(struct net_device *dev, void *data)
+static int prestera_lower_dev_walk(struct net_device *dev,
+				   struct netdev_nested_priv *priv)
 {
-	struct prestera_port **pport = data;
+	struct prestera_port **pport = (struct prestera_port **)priv->data;
 
 	if (prestera_netdev_check(dev)) {
 		*pport = netdev_priv(dev);
@@ -497,11 +498,13 @@ static int prestera_lower_dev_walk(struct net_device *dev, void *data)
 struct prestera_port *prestera_port_dev_lower_find(struct net_device *dev)
 {
 	struct prestera_port *port = NULL;
+	struct netdev_nested_priv priv;
 
 	if (prestera_netdev_check(dev))
 		return netdev_priv(dev);
 
-	netdev_walk_all_lower_dev(dev, prestera_lower_dev_walk, &port);
+	priv.data = (void *)&port;
+	netdev_walk_all_lower_dev(dev, prestera_lower_dev_walk, &priv);
 
 	return port;
 }
-- 
2.28.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-08-05 12:31 Stephen Rothwell
  2020-08-05 13:06 ` Stefano Brivio
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2020-08-05 12:31 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Stefano Brivio, heiko.carstens

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (s390 defconfig)
failed like this:

net/ipv4/ip_tunnel_core.c:335:2: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]

Caused by commit

  4cb47a8644cc ("tunnels: PMTU discovery support for directly bridged IP packets")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-07-29 11:27 Stephen Rothwell
  2020-07-29 18:13 ` Brian Vazquez
  2020-08-17  7:20 ` Sven Joachim
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2020-07-29 11:27 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Brian Vazquez

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (i386 defconfig)
failed like this:

x86_64-linux-gnu-ld: net/core/fib_rules.o: in function `fib_rules_lookup':
fib_rules.c:(.text+0x5c6): undefined reference to `fib6_rule_match'
x86_64-linux-gnu-ld: fib_rules.c:(.text+0x5d8): undefined reference to `fib6_rule_match'
x86_64-linux-gnu-ld: fib_rules.c:(.text+0x64d): undefined reference to `fib6_rule_action'
x86_64-linux-gnu-ld: fib_rules.c:(.text+0x662): undefined reference to `fib6_rule_action'
x86_64-linux-gnu-ld: fib_rules.c:(.text+0x67a): undefined reference to `fib6_rule_suppress'
x86_64-linux-gnu-ld: fib_rules.c:(.text+0x68d): undefined reference to `fib6_rule_suppress'

Caused by commit

  b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")

# CONFIG_IPV6_MULTIPLE_TABLES is not set

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-07-13  1:54 Stephen Rothwell
  2020-07-13  7:29 ` Nikolay Aleksandrov
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2020-07-13  1:54 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Nikolay Aleksandrov

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/bridge/br_netlink_tunnel.c: In function '__vlan_tunnel_handle_range':
net/bridge/br_netlink_tunnel.c:271:26: error: implicit declaration of function 'br_vlan_can_enter_range'; did you mean 'br_vlan_valid_range'? [-Werror=implicit-function-declaration]
  271 |  if (v && curr_change && br_vlan_can_enter_range(v, *v_end)) {
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
      |                          br_vlan_valid_range

Caused by commit

  94339443686b ("net: bridge: notify on vlan tunnel changes done via the old api")

CONFIG_BRIDGE_VLAN_FILTERING is not set for this build.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-01-16  7:53 Stephen Rothwell
  2020-01-20  9:03 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2020-01-16  7:53 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Niu Xilei

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc
defconfig) failed like this:

ERROR: "__umoddi3" [net/core/pktgen.ko] undefined!

Caused by commit

  7786a1af2a6b ("pktgen: Allow configuration of IPv6 source address range")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2020-01-09 23:57 Stephen Rothwell
  2020-01-10  2:30 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2020-01-09 23:57 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Petr Machata

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c: In function '__mlxsw_sp_qdisc_ets_graft':
drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:770:7: error: 'p' undeclared (first use in this function); did you mean 'up'?
  770 |  if (!p->child_handle) {
      |       ^
      |       up

Caused by commit

  345457a6e2cd ("Merge remote-tracking branch 'net-next/master'")

i.e. an incorrect automatic merge between commit

  3971a535b839 ("mlxsw: spectrum_qdisc: Ignore grafting of invisible FIFO")

from Linus' tree and commit

  7917f52ae188 ("mlxsw: spectrum_qdisc: Generalize PRIO offload to support ETS")

from the net-next tree.

I have applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 10 Jan 2020 10:52:33 +1100
Subject: [PATCH] mlxws: fix up for "mlxsw: spectrum_qdisc: Ignore grafting of invisible FIFO"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
index 17b29e2d19ed..54807b4930fe 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
@@ -767,7 +767,7 @@ __mlxsw_sp_qdisc_ets_graft(struct mlxsw_sp_port *mlxsw_sp_port,
 	    mlxsw_sp_port->tclass_qdiscs[tclass_num].handle == child_handle)
 		return 0;
 
-	if (!p->child_handle) {
+	if (!child_handle) {
 		/* This is an invisible FIFO replacing the original Qdisc.
 		 * Ignore it--the original Qdisc's destroy will follow.
 		 */
-- 
2.24.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-12-18 22:32 Stephen Rothwell
  2019-12-18 22:38 ` Jose Abreu
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-12-18 22:32 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jose Abreu

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arm-linux-gnueabi-ld: drivers/net/ethernet/stmicro/stmmac/stmmac_tc.o: in function `tc_setup_taprio':
stmmac_tc.c:(.text+0x4e8): undefined reference to `__aeabi_uldivmod'
arm-linux-gnueabi-ld: stmmac_tc.c:(.text+0x508): undefined reference to `__aeabi_uldivmod'

Caused by commit

  b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API")

I have used the net-nest tree from next-20191218 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-11-05  8:53 Stephen Rothwell
  2019-11-05 13:50 ` Andrew Lunn
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-11-05  8:53 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andrew Lunn

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powepc
ppc44x_defconfig) failed like this:


Caused by commit

  0c65b2b90d13 ("net: of_get_phy_mode: Change API to solve int/unit warnings")

I applied the following patch, but there is probably a nicer and more
complete way to fix this.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 5 Nov 2019 19:49:55 +1100
Subject: [PATCH] fix up for "net: of_get_phy_mode: Change API to solve int/unit warnings"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/ibm/emac/core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index 2e40425d8a34..8cb682754bd4 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -2850,6 +2850,7 @@ static int emac_init_config(struct emac_instance *dev)
 	struct device_node *np = dev->ofdev->dev.of_node;
 	const void *p;
 	int err;
+	phy_interface_t phy_mode;
 
 	/* Read config from device-tree */
 	if (emac_read_uint_prop(np, "mal-device", &dev->mal_ph, 1))
@@ -2898,9 +2899,11 @@ static int emac_init_config(struct emac_instance *dev)
 		dev->mal_burst_size = 256;
 
 	/* PHY mode needs some decoding */
-	err = of_get_phy_mode(np, &dev->phy_mode);
+	err = of_get_phy_mode(np, &phy_mode);
 	if (err)
 		dev->phy_mode = PHY_INTERFACE_MODE_NA;
+	else
+		dev->phy_mode = phy_mode;
 
 	/* Check EMAC version */
 	if (of_device_is_compatible(np, "ibm,emac4sync")) {
-- 
2.23.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-09-04  6:00 Stephen Rothwell
  2019-09-04  6:18 ` Masahiro Yamada
  2019-09-04  8:18 ` Andrii Nakryiko
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2019-09-04  6:00 UTC (permalink / raw)
  To: David Miller, Networking, Masahiro Yamada
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Andrii Nakryiko, Daniel Borkmann

[-- Attachment #1: Type: text/plain, Size: 2107 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

scripts/link-vmlinux.sh: 74: Bad substitution

Caused by commit

  341dfcf8d78e ("btf: expose BTF info through sysfs")

interacting with commit

  1267f9d3047d ("kbuild: add $(BASH) to run scripts with bash-extension")

from the kbuild tree.

The change in the net-next tree turned link-vmlinux.sh into a bash script
(I think).

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 4 Sep 2019 15:43:41 +1000
Subject: [PATCH] link-vmlinux.sh is now a bash script

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 Makefile                | 4 ++--
 scripts/link-vmlinux.sh | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index ac97fb282d99..523d12c5cebe 100644
--- a/Makefile
+++ b/Makefile
@@ -1087,7 +1087,7 @@ ARCH_POSTLINK := $(wildcard $(srctree)/arch/$(SRCARCH)/Makefile.postlink)
 
 # Final link of vmlinux with optional arch pass after final link
 cmd_link-vmlinux =                                                 \
-	$(CONFIG_SHELL) $< $(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) ;    \
+	$(BASH) $< $(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) ;    \
 	$(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
 
 vmlinux: scripts/link-vmlinux.sh autoksyms_recursive $(vmlinux-deps) FORCE
@@ -1403,7 +1403,7 @@ clean: rm-files := $(CLEAN_FILES)
 PHONY += archclean vmlinuxclean
 
 vmlinuxclean:
-	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean
+	$(Q)$(BASH) $(srctree)/scripts/link-vmlinux.sh clean
 	$(Q)$(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) clean)
 
 clean: archclean vmlinuxclean
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index f7edb75f9806..ea1f8673869d 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 #
 # link vmlinux
-- 
2.23.0.rc1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-08-29 10:05 Stephen Rothwell
  2019-08-30 21:35 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-08-29 10:05 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Voon Weifeng,
	Ong Boon Leong

[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powepc
allmodconfig) failed like this:

ld: drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o: in function `.stmmac_pci_remove':
stmmac_pci.c:(.text.stmmac_pci_remove+0x68): undefined reference to `.clk_unregister_fixed_rate'
ld: drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o: in function `.intel_mgbe_common_data':
stmmac_pci.c:(.text.intel_mgbe_common_data+0x2a8): undefined reference to `.clk_register_fixed_rate'

Caused by commit

  190f73ab4c43 ("net: stmmac: setup higher frequency clk support for EHL & TGL")

CONFIG_COMMON_CLK is not set for this build.

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 29 Aug 2019 19:49:27 +1000
Subject: [PATCH] net: stmmac: depend on COMMON_CLK

Fixes: 190f73ab4c43 ("net: stmmac: setup higher frequency clk support for EHL & TGL")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index 2325b40dff6e..338e25a6374e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -200,6 +200,7 @@ endif
 config STMMAC_PCI
 	tristate "STMMAC PCI bus support"
 	depends on STMMAC_ETH && PCI
+	depends on COMMON_CLK
 	---help---
 	  This selects the platform specific bus support for the stmmac driver.
 	  This driver was tested on XLINX XC2V3000 FF1152AMT0221
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-07-25  9:37 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2019-07-25  9:37 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox (Oracle)

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (mips
cavium_octeon_defconfig) failed like this:

drivers/staging/octeon/ethernet-tx.c:287:23: error: implicit declaration of function 'skb_drag_size'; did you mean 'skb_frag_size'? [-Werror=implicit-function-declaration]

Caused by commit

  92493a2f8a8d ("Build fixes for skb_frag_size conversion")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* Re: Re: linux-next: build failure after merge of the net-next tree
  2019-07-11  8:00   ` Bernard Metzler
@ 2019-07-11 11:52 Jason Gunthorpe
  0 siblings, 0 replies; 394+ messages in thread
From: Jason Gunthorpe @ 2019-07-11 11:52 UTC (permalink / raw)
  To: Bernard Metzler
  Cc: Leon Romanovsky, Stephen Rothwell, Doug Ledford, David Miller,
	Networking, Linux Next Mailing List, Linux Kernel Mailing List

On Thu, Jul 11, 2019 at 08:00:49AM +0000, Bernard Metzler wrote:

> That listen will not sleep. The socket is just marked
> listening. 

Eh? siw_listen_address() calls siw_cep_alloc() which does:

	struct siw_cep *cep = kzalloc(sizeof(*cep), GFP_KERNEL);

Which is sleeping. Many other cases too.

Jason

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-07-09  3:56 Stephen Rothwell
  2019-07-09  6:43 ` Leon Romanovsky
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-07-09  3:56 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Bernard Metzler

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/sw/siw/siw_cm.c: In function 'siw_create_listen':
drivers/infiniband/sw/siw/siw_cm.c:1978:3: error: implicit declaration of function 'for_ifa'; did you mean 'fork_idle'? [-Werror=implicit-function-declaration]
   for_ifa(in_dev)
   ^~~~~~~
   fork_idle
drivers/infiniband/sw/siw/siw_cm.c:1978:18: error: expected ';' before '{' token
   for_ifa(in_dev)
                  ^
                  ;
   {
   ~

Caused by commit

  6c52fdc244b5 ("rdma/siw: connection management")

from the rdma tree.  I don't know why this didn't fail after I mereged
that tree.

I have marked that driver as depending on BROKEN for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-06-20  9:13 Stephen Rothwell
  2019-06-24  3:12 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-06-20  9:13 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yash Shah

[-- Attachment #1: Type: text/plain, Size: 3234 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/cadence/macb_main.c:48:16: error: field 'hw' has incomplete type
  struct clk_hw hw;
                ^~
drivers/net/ethernet/cadence/macb_main.c:4003:21: error: variable 'fu540_c000_ops' has initializer but incomplete type
 static const struct clk_ops fu540_c000_ops = {
                     ^~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4004:3: error: 'const struct clk_ops' has no member named 'recalc_rate'
  .recalc_rate = fu540_macb_tx_recalc_rate,
   ^~~~~~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4004:17: warning: excess elements in struct initializer
  .recalc_rate = fu540_macb_tx_recalc_rate,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4004:17: note: (near initialization for 'fu540_c000_ops')
drivers/net/ethernet/cadence/macb_main.c:4005:3: error: 'const struct clk_ops' has no member named 'round_rate'
  .round_rate = fu540_macb_tx_round_rate,
   ^~~~~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4005:16: warning: excess elements in struct initializer
  .round_rate = fu540_macb_tx_round_rate,
                ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4005:16: note: (near initialization for 'fu540_c000_ops')
drivers/net/ethernet/cadence/macb_main.c:4006:3: error: 'const struct clk_ops' has no member named 'set_rate'
  .set_rate = fu540_macb_tx_set_rate,
   ^~~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4006:14: warning: excess elements in struct initializer
  .set_rate = fu540_macb_tx_set_rate,
              ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/cadence/macb_main.c:4006:14: note: (near initialization for 'fu540_c000_ops')
drivers/net/ethernet/cadence/macb_main.c: In function 'fu540_c000_clk_init':
drivers/net/ethernet/cadence/macb_main.c:4013:23: error: storage size of 'init' isn't known
  struct clk_init_data init;
                       ^~~~
drivers/net/ethernet/cadence/macb_main.c:4032:12: error: implicit declaration of function 'clk_register'; did you mean 'sock_register'? [-Werror=implicit-function-declaration]
  *tx_clk = clk_register(NULL, &mgmt->hw);
            ^~~~~~~~~~~~
            sock_register
drivers/net/ethernet/cadence/macb_main.c:4013:23: warning: unused variable 'init' [-Wunused-variable]
  struct clk_init_data init;
                       ^~~~
drivers/net/ethernet/cadence/macb_main.c: In function 'macb_probe':
drivers/net/ethernet/cadence/macb_main.c:4366:2: error: implicit declaration of function 'clk_unregister'; did you mean 'sock_unregister'? [-Werror=implicit-function-declaration]
  clk_unregister(tx_clk);
  ^~~~~~~~~~~~~~
  sock_unregister
drivers/net/ethernet/cadence/macb_main.c: At top level:
drivers/net/ethernet/cadence/macb_main.c:4003:29: error: storage size of 'fu540_c000_ops' isn't known
 static const struct clk_ops fu540_c000_ops = {
                             ^~~~~~~~~~~~~~

Caused by commit

  c218ad559020 ("macb: Add support for SiFive FU540-C000")

CONFIG_COMMON_CLK is not set for this build.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-06-19  3:23 Stephen Rothwell
  2019-06-19  4:02 ` Masahiro Yamada
  2019-06-19 14:13 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2019-06-19  3:23 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Kevin Darbyshire-Bryant, Masahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from usr/include/linux/tc_act/tc_ctinfo.hdrtest.c:1:
./usr/include/linux/tc_act/tc_ctinfo.h:30:21: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration]
  CTINFO_MODE_DSCP = BIT(0),
                     ^~~
./usr/include/linux/tc_act/tc_ctinfo.h:30:2: error: enumerator value for 'CTINFO_MODE_DSCP' is not an integer constant
  CTINFO_MODE_DSCP = BIT(0),
  ^~~~~~~~~~~~~~~~
./usr/include/linux/tc_act/tc_ctinfo.h:32:1: error: enumerator value for 'CTINFO_MODE_CPMARK' is not an integer constant
 };
 ^

Caused by commit

  24ec483cec98 ("net: sched: Introduce act_ctinfo action")

Presumably exposed by commit

  b91976b7c0e3 ("kbuild: compile-test UAPI headers to ensure they are self-contained")

from the kbuild tree.

I have applied the following (obvious) patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 19 Jun 2019 13:15:22 +1000
Subject: [PATCH] net: sched: don't use BIT() in uapi headers

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/uapi/linux/tc_act/tc_ctinfo.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/tc_act/tc_ctinfo.h b/include/uapi/linux/tc_act/tc_ctinfo.h
index da803e05a89b..6166c62dd7dd 100644
--- a/include/uapi/linux/tc_act/tc_ctinfo.h
+++ b/include/uapi/linux/tc_act/tc_ctinfo.h
@@ -27,8 +27,8 @@ enum {
 #define TCA_CTINFO_MAX (__TCA_CTINFO_MAX - 1)
 
 enum {
-	CTINFO_MODE_DSCP	= BIT(0),
-	CTINFO_MODE_CPMARK	= BIT(1)
+	CTINFO_MODE_DSCP	= (1UL << 0),
+	CTINFO_MODE_CPMARK	= (1UL << 1)
 };
 
 #endif
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-06-11  8:26 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2019-06-11  8:26 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Grygorii Strashko

[-- Attachment #1: Type: text/plain, Size: 2784 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/ti/cpts.c: In function 'cpts_of_mux_clk_setup':
drivers/net/ethernet/ti/cpts.c:567:2: error: implicit declaration of function 'of_clk_parent_fill'; did you mean 'of_clk_get_parent_name'? [-Werror=implicit-function-declaration]
  of_clk_parent_fill(refclk_np, parent_names, num_parents);
  ^~~~~~~~~~~~~~~~~~
  of_clk_get_parent_name
drivers/net/ethernet/ti/cpts.c:575:11: error: implicit declaration of function 'clk_hw_register_mux_table'; did you mean 'clk_hw_register_clkdev'? [-Werror=implicit-function-declaration]
  clk_hw = clk_hw_register_mux_table(cpts->dev, refclk_np->name,
           ^~~~~~~~~~~~~~~~~~~~~~~~~
           clk_hw_register_clkdev
drivers/net/ethernet/ti/cpts.c:575:9: warning: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  clk_hw = clk_hw_register_mux_table(cpts->dev, refclk_np->name,
         ^
drivers/net/ethernet/ti/cpts.c:586:29: error: 'clk_hw_unregister_mux' undeclared (first use in this function); did you mean 'clk_hw_register_clkdev'?
            (void(*)(void *))clk_hw_unregister_mux,
                             ^~~~~~~~~~~~~~~~~~~~~
                             clk_hw_register_clkdev
drivers/net/ethernet/ti/cpts.c:586:29: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/ti/cpts.c:593:8: error: implicit declaration of function 'of_clk_add_hw_provider'; did you mean 'of_clk_get_from_provider'? [-Werror=implicit-function-declaration]
  ret = of_clk_add_hw_provider(refclk_np, of_clk_hw_simple_get, clk_hw);
        ^~~~~~~~~~~~~~~~~~~~~~
        of_clk_get_from_provider
drivers/net/ethernet/ti/cpts.c:593:42: error: 'of_clk_hw_simple_get' undeclared (first use in this function); did you mean 'ida_simple_get'?
  ret = of_clk_add_hw_provider(refclk_np, of_clk_hw_simple_get, clk_hw);
                                          ^~~~~~~~~~~~~~~~~~~~
                                          ida_simple_get
drivers/net/ethernet/ti/cpts.c:598:29: error: 'of_clk_del_provider' undeclared (first use in this function); did you mean 'of_clk_get_from_provider'?
            (void(*)(void *))of_clk_del_provider,
                             ^~~~~~~~~~~~~~~~~~~
                             of_clk_get_from_provider
cc1: some warnings being treated as errors

Caused by commit

  a3047a81ba13 ("net: ethernet: ti: cpts: add support for ext rftclk selection")

of_clk_parent_fill() and others above are only available if
CONFIG_COMMON_CLK is set (which it is not for this build).

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-05-31  0:35 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2019-05-31  0:35 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pablo Neira Ayuso

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from net/netfilter/utils.c:5:
include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag':
include/linux/netfilter_ipv6.h:110:9: error: implicit declaration of function 'nf_ct_frag6_gather'; did you mean 'nf_ct_attach'? [-Werror=implicit-function-declaration]
  return nf_ct_frag6_gather(net, skb, user);
         ^~~~~~~~~~~~~~~~~~
         nf_ct_attach

Caused by commit

  764dd163ac92 ("netfilter: nf_conntrack_bridge: add support for IPv6")

CONFIG_IPV6 is not set for this build.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-04-23  7:25 Stephen Rothwell
  2019-04-24  1:36 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-04-23  7:25 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

net/core/sock.c: In function 'sock_gettstamp':
net/core/sock.c:3007:23: error: expected '}' before ';' token
    .tv_sec = ts.tv_sec;
                       ^
net/core/sock.c:3011:4: error: expected ')' before 'return'
    return -EFAULT;
    ^~~~~~
net/core/sock.c:3013:2: error: expected expression before '}' token
  }
  ^

Caused by commit

  c7cbdbf29f48 ("net: rework SIOCGSTAMP ioctl handling")

I have applied the followinf patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 23 Apr 2019 17:12:19 +1000
Subject: [PATCH] net: fix sparc64 compilation of sock_gettstamp

Fixes: c7cbdbf29f48 ("net: rework SIOCGSTAMP ioctl handling")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/core/sock.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/core/sock.c b/net/core/sock.c
index 443b98d05f1e..925b84a872dd 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -3004,10 +3004,10 @@ int sock_gettstamp(struct socket *sock, void __user *userstamp,
 	/* beware of padding in sparc64 timeval */
 	if (timeval && !in_compat_syscall()) {
 		struct __kernel_old_timeval __user tv = {
-			.tv_sec = ts.tv_sec;
-			.tv_usec = ts.tv_nsec;
+			.tv_sec = ts.tv_sec,
+			.tv_usec = ts.tv_nsec,
 		};
-		if (copy_to_user(userstamp, &tv, sizeof(tv))
+		if (copy_to_user(userstamp, &tv, sizeof(tv)))
 			return -EFAULT;
 		return 0;
 	}
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-02-04  4:34 Stephen Rothwell
  2019-02-04  4:36 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-02-04  4:34 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Deepa Dinamani

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

/home/sfr/next/next/net/core/sock.c: In function 'sock_setsockopt':
/home/sfr/next/next/net/core/sock.c:1146:2: error: duplicate case value
  case SO_BINDTOIFINDEX:
  ^~~~
/home/sfr/next/next/net/core/sock.c:891:2: note: previously used here
  case SO_TIMESTAMP_NEW:
  ^~~~
/home/sfr/next/next/net/core/sock.c: In function 'sock_getsockopt':
/home/sfr/next/next/net/core/sock.c:1493:2: error: duplicate case value
  case SO_BINDTOIFINDEX:
  ^~~~
/home/sfr/next/next/net/core/sock.c:1293:2: note: previously used here
  case SO_TIMESTAMP_NEW:
  ^~~~

Caused by commit

  887feae36aee ("socket: Add SO_TIMESTAMP[NS]_NEW")

I applied the following fix patch (I just update the clashing id rather
than update them all, but the latter may be better).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 4 Feb 2019 15:24:11 +1100
Subject: [PATCH] socket: fix for Add SO_TIMESTAMP[NS]_NEW

Fixes: 887feae36aee ("socket: Add SO_TIMESTAMP[NS]_NEW")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/sparc/include/uapi/asm/socket.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sparc/include/uapi/asm/socket.h b/arch/sparc/include/uapi/asm/socket.h
index 8c9f74a66b55..88fe4f978aca 100644
--- a/arch/sparc/include/uapi/asm/socket.h
+++ b/arch/sparc/include/uapi/asm/socket.h
@@ -108,7 +108,7 @@
 #define SO_TIMESTAMPNS_OLD       0x0021
 #define SO_TIMESTAMPING_OLD      0x0023
 
-#define SO_TIMESTAMP_NEW         0x0041
+#define SO_TIMESTAMP_NEW         0x0046
 #define SO_TIMESTAMPNS_NEW       0x0042
 #define SO_TIMESTAMPING_NEW      0x0043
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2019-01-29  5:17 Stephen Rothwell
  2019-01-29  6:43 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2019-01-29  5:17 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Claudiu Manoil

[-- Attachment #1: Type: text/plain, Size: 2370 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/freescale/enetc/enetc.c: In function 'enetc_alloc_txbdr':
drivers/net/ethernet/freescale/enetc/enetc.c:685:17: error: implicit declaration of function 'vzalloc'; did you mean 'kzalloc'? [-Werror=implicit-function-declaration]
  txr->tx_swbd = vzalloc(txr->bd_count * sizeof(struct enetc_tx_swbd));
                 ^~~~~~~
                 kzalloc
drivers/net/ethernet/freescale/enetc/enetc.c:685:15: warning: assignment to 'struct enetc_tx_swbd *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  txr->tx_swbd = vzalloc(txr->bd_count * sizeof(struct enetc_tx_swbd));
               ^
drivers/net/ethernet/freescale/enetc/enetc.c:691:3: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
   vfree(txr->tx_swbd);
   ^~~~~
   kfree
drivers/net/ethernet/freescale/enetc/enetc.c: In function 'enetc_alloc_rxbdr':
drivers/net/ethernet/freescale/enetc/enetc.c:749:15: warning: assignment to 'struct enetc_rx_swbd *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  rxr->rx_swbd = vzalloc(rxr->bd_count * sizeof(struct enetc_rx_swbd));
               ^

Caused by commit

  d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 Jan 2019 16:13:08 +1100
Subject: [PATCH] enetc: include linux/vmalloc.h for vzalloc etc

Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index 37b587c541ee..5bb9eb35d76d 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -5,6 +5,7 @@
 #include <linux/tcp.h>
 #include <linux/udp.h>
 #include <linux/of_mdio.h>
+#include <linux/vmalloc.h>
 
 /* ENETC overhead: optional extension BD + 1 BD gap */
 #define ENETC_TXBDS_NEEDED(val)	((val) + 2)
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-12-20  2:28 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2018-12-20  2:28 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Petr Machata

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/vxlan.c: In function 'vxlan_changelink':
drivers/net/vxlan.c:3763:10: error: too few arguments to function 'vxlan_fdb_update'
    err = vxlan_fdb_update(vxlan, all_zeros_mac,
          ^~~~~~~~~~~~~~~~
drivers/net/vxlan.c:830:12: note: declared here
 static int vxlan_fdb_update(struct vxlan_dev *vxlan,
            ^~~~~~~~~~~~~~~~

Caused by commit

  ce5e098f7a10 ("vxlan: changelink: Fix handling of default remotes")

from the net tree interacting with commit

  0e6160f3f5a9 ("vxlan: vxlan_fdb_notify(): Make switchdev notification configurable")

from the net-next tree.

I added the following merge fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 20 Dec 2018 13:24:05 +1100
Subject: [PATCH] vxlan: fix for vxlan_fdb_update() API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/vxlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index efd709a5e3a8..5209ee9aac47 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -3768,7 +3768,7 @@ static int vxlan_changelink(struct net_device *dev, struct nlattr *tb[],
 					       dst->remote_vni,
 					       dst->remote_vni,
 					       dst->remote_ifindex,
-					       NTF_SELF);
+					       NTF_SELF, true);
 			if (err) {
 				spin_unlock_bh(&vxlan->hash_lock);
 				return err;
-- 
2.19.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-12-17  1:36 Stephen Rothwell
  2018-12-17 15:54 ` Paolo Abeni
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-12-17  1:36 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Paolo Abeni

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from net/core/dev.c:148:
net/core/dev.c: In function 'napi_gro_complete':
net/core/dev.c:5364:26: error: 'inet_gro_complete' undeclared (first use in this function); did you mean 'eth_gro_complete'?
       ipv6_gro_complete, inet_gro_complete,
                          ^~~~~~~~~~~~~~~~~
include/linux/indirect_call_wrapper.h:32:41: note: in definition of macro 'INDIRECT_CALL_2'
 #define INDIRECT_CALL_2(f, name, ...) f(__VA_ARGS__)
                                         ^~~~~~~~~~~

and on ....

Caused by commit

  aaa5d90b395a ("net: use indirect call wrappers at GRO network layer")

inet_gro_complete() is declared in include/net/inet_comon.h which is
not directly included in net/core/dev.c.

I have used the net-next tree from next-20181214 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-10-19  0:18 Stephen Rothwell
  2018-10-19  5:48 ` Or Gerlitz
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-10-19  0:18 UTC (permalink / raw)
  To: David Miller, Networking, Doug Ledford, Jason Gunthorpe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Mark Bloch,
	Leon Romanovsky, Paul Blakey, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/mlx5/flow.c: In function 'mlx5_ib_handler_MLX5_IB_METHOD_CREATE_FLOW':
drivers/infiniband/hw/mlx5/flow.c:163:12: error: 'struct mlx5_flow_act' has no member named 'has_flow_tag'; did you mean 'flow_tag'?
   flow_act.has_flow_tag = true;
            ^~~~~~~~~~~~
            flow_tag

Caused by commit

  d5634fee245f ("net/mlx5: Add a no-append flow insertion mode")

interacting with commit

  ba4a41198324 ("RDMA/mlx5: Add support for flow tag to raw create flow")

from the rdma tree.

I have applied the following merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 19 Oct 2018 11:10:39 +1100
Subject: [PATCH] net/mlx5: fix up for has_flow_tag changing to a flag

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/mlx5/flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/flow.c b/drivers/infiniband/hw/mlx5/flow.c
index e57435cb6d96..f86cdcafdafc 100644
--- a/drivers/infiniband/hw/mlx5/flow.c
+++ b/drivers/infiniband/hw/mlx5/flow.c
@@ -160,7 +160,7 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_CREATE_FLOW)(
 			ret = -EINVAL;
 			goto err_out;
 		}
-		flow_act.has_flow_tag = true;
+		flow_act.flags |= FLOW_ACT_HAS_TAG;
 	}
 
 	flow_handler = mlx5_ib_raw_fs_rule_add(dev, fs_matcher, &flow_act,
-- 
2.18.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-09-02 23:47 Stephen Rothwell
  2018-09-07  0:20 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-09-02 23:47 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Jacob Keller,
	Jeff Kirsher, Andrew Bowers

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from drivers/net/ethernet/intel/i40e/i40e_ethtool.c:9:
drivers/net/ethernet/intel/i40e/i40e_ethtool.c: In function '__i40e_add_stat_strings':
drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h:193:20: error: function '__i40e_add_stat_strings' can never be inlined because it uses variable argument lists
 static inline void __i40e_add_stat_strings(u8 **p, const struct i40e_stats stats[],
                    ^~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  8fd75c58a09a ("i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h")

It is not clear this patch has any value anyway as the moved functions
are only used in the file they were moved from.

I reverted that commit for today.

The same problem would exist in drivers/net/ethernet/intel/i40evf (where
a lot of code is duplicated from drivers/net/ethernet/intel/i40e) except
that this function is not declared inline there.
Luckily, i40e_ethtool_stats.h is only included my one file
drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c, otherwise there
would be multiple copies of __i40e_add_stat_strings().

Surely there is some scope for factoring out some common code between
these two drivers?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-08-06  2:10 Stephen Rothwell
  2018-08-06  4:43 ` Y.b. Lu
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-08-06  2:10 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Yangbo Lu

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/ptp/ptp_qoriq.o: In function `qoriq_ptp_probe':
ptp_qoriq.c:(.text+0xd0c): undefined reference to `__aeabi_uldivmod'

Caused by commit

  91305f281262 ("ptp_qoriq: support automatic configuration for ptp timer")

I just reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-08-03  2:14 Stephen Rothwell
  2018-08-03  2:34 ` Jakub Kicinski
  2018-08-03  2:44 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2018-08-03  2:14 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 2107 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (perf) failed
like this:

In file included from btf.c:10:0:
btf.h:25:24: error: redundant redeclaration of 'btf__type_by_id' [-Werror=redundant-decls]
 const struct btf_type *btf__type_by_id(const struct btf *btf, __u32 type_id);
                        ^~~~~~~~~~~~~~~
btf.h:20:24: note: previous declaration of 'btf__type_by_id' was here
 const struct btf_type *btf__type_by_id(const struct btf *btf, __u32 id);
                        ^~~~~~~~~~~~~~~
btf.c:405:24: error: redefinition of 'btf__type_by_id'
 const struct btf_type *btf__type_by_id(const struct btf *btf,
                        ^~~~~~~~~~~~~~~
btf.c:197:24: note: previous definition of 'btf__type_by_id' was here
 const struct btf_type *btf__type_by_id(const struct btf *btf, __u32 type_id)
                        ^~~~~~~~~~~~~~~
btf.c:40:20: error: 'btf_name_by_offset' defined but not used [-Werror=unused-function]
 static const char *btf_name_by_offset(const struct btf *btf, __u32 offset)
                    ^~~~~~~~~~~~~~~~~~
mv: cannot stat 'perf/.libbpf.o.tmp': No such file or directory
tools/build/Makefile.build:96: recipe for target 'perf/libbpf.o' failed
In file included from libbpf.c:52:0:
btf.h:25:24: error: redundant redeclaration of 'btf__type_by_id' [-Werror=redundant-decls]
 const struct btf_type *btf__type_by_id(const struct btf *btf, __u32 type_id);
                        ^~~~~~~~~~~~~~~
btf.h:20:24: note: previous declaration of 'btf__type_by_id' was here
 const struct btf_type *btf__type_by_id(const struct btf *btf, __u32 id);
                        ^~~~~~~~~~~~~~~
mv: cannot stat 'perf/.libbpf.o.tmp': No such file or directory
tools/build/Makefile.build:96: recipe for target 'perf/libbpf.o' failed

Caused by commit

  89b1698c93a9 ("Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net")

Some of the lines in tools/lib/bpf/btf.[ch] were duplicated (they existed
on both sides of the merge).

I have used the net-next tree from next-20180802 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-07-27 10:32 Stephen Rothwell
  2018-07-27 12:18 ` YueHaibing
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-07-27 10:32 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, YueHaibing

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

hns_roce_hw_v1.c:(.text.hns_roce_v1_reset+0x8c): undefined reference to `.hns_dsaf_roce_reset'
hns_roce_hw_v1.c:(.text.hns_roce_v1_reset+0xdc): undefined reference to `.hns_dsaf_roce_reset'

Caused by commit

  336a443bd9dd ("net: hns: Make many functions static")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 27 Jul 2018 20:23:20 +1000
Subject: [PATCH] net: hns: make hns_dsaf_roce_reset() not static

This function is declared in a header file and used in a different
source file.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
index 7afc67510569..619e6ce465c2 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -2836,7 +2836,7 @@ module_platform_driver(g_dsaf_driver);
  * @enable: false - request reset , true - drop reset
  * retuen 0 - success , negative -fail
  */
-static int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
+int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
 {
 	struct dsaf_device *dsaf_dev;
 	struct platform_device *pdev;
-- 
2.18.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-07-03  0:47 Stephen Rothwell
  2018-07-03  7:34 ` Sabrina Dubroca
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-07-03  0:47 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Sabrina Dubroca

[-- Attachment #1: Type: text/plain, Size: 2971 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/ipv4/fou.c: In function 'gue_gro_receive':
net/ipv4/fou.c:451:35: error: passing argument 2 of 'skb_gro_flush_final_remcsum' from incompatible pointer type [-Werror=incompatible-pointer-types]
  skb_gro_flush_final_remcsum(skb, pp, flush, &grc);
                                   ^~
In file included from include/net/inet_sock.h:23:0,
                 from include/linux/udp.h:20,
                 from net/ipv4/fou.c:6:
include/linux/netdevice.h:2799:20: note: expected 'struct sk_buff **' but argument is of type 'struct sk_buff *'
 static inline void skb_gro_flush_final_remcsum(struct sk_buff *skb,
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/vxlan.c: In function 'vxlan_gro_receive':
drivers/net/vxlan.c:627:35: error: passing argument 2 of 'skb_gro_flush_final_remcsum' from incompatible pointer type [-Werror=incompatible-pointer-types]
  skb_gro_flush_final_remcsum(skb, pp, flush, &grc);
                                   ^~
In file included from include/net/inet_sock.h:23:0,
                 from include/linux/udp.h:20,
                 from drivers/net/vxlan.c:17:
include/linux/netdevice.h:2799:20: note: expected 'struct sk_buff **' but argument is of type 'struct sk_buff *'
 static inline void skb_gro_flush_final_remcsum(struct sk_buff *skb,
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  d4546c2509b1 ("net: Convert GRO SKB handling to list_head.")

from the net-next tree interacting with commit

  603d4cf8fe09 ("net: fix use-after-free in GRO with ESP")

from Linus' tree.

I took a guess and aplied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 3 Jul 2018 10:37:05 +1000
Subject: [PATCH] net: update for conversion of GRO SKB handling

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/netdevice.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e1d4084c0651..64480a0f2c16 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2797,7 +2797,7 @@ static inline void skb_gro_flush_final(struct sk_buff *skb, struct sk_buff *pp,
 		NAPI_GRO_CB(skb)->flush |= flush;
 }
 static inline void skb_gro_flush_final_remcsum(struct sk_buff *skb,
-					       struct sk_buff **pp,
+					       struct sk_buff *pp,
 					       int flush,
 					       struct gro_remcsum *grc)
 {
@@ -2813,7 +2813,7 @@ static inline void skb_gro_flush_final(struct sk_buff *skb, struct sk_buff *pp,
 	NAPI_GRO_CB(skb)->flush |= flush;
 }
 static inline void skb_gro_flush_final_remcsum(struct sk_buff *skb,
-					       struct sk_buff **pp,
+					       struct sk_buff *pp,
 					       int flush,
 					       struct gro_remcsum *grc)
 {
-- 
2.17.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-05-29  3:42 Stephen Rothwell
  2018-05-29  5:41 ` Christoph Hellwig
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-05-29  3:42 UTC (permalink / raw)
  To: David Miller, Networking, Al Viro
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Björn Töpel, Alexei Starovoitov, Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/xdp/xsk.c: In function 'xsk_poll':
net/xdp/xsk.c:207:22: error: implicit declaration of function 'datagram_poll'; did you mean 'datagram_poll_mask'? [-Werror=implicit-function-declaration]
  unsigned int mask = datagram_poll(file, sock, wait);
                      ^~~~~~~~~~~~~ 
                      datagram_poll_mask

Caused by commit

  c497176cb2e4 ("xsk: add Rx receive functions and poll support")

interacting with commit

  db5051ead64a ("net: convert datagram_poll users tp ->poll_mask")

from the vfs tree.

[Christoph, I noticed that the comment above datagram_poll in
net/core/datagram.c needs the function name updated]

I have added the following merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 May 2018 13:34:25 +1000
Subject: [PATCH] xsk: update for "net: convert datagram_poll users tp->poll_mask"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/xdp/xsk.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
index cce0e4f8a536..4ee140afbc61 100644
--- a/net/xdp/xsk.c
+++ b/net/xdp/xsk.c
@@ -201,10 +201,9 @@ static int xsk_sendmsg(struct socket *sock, struct msghdr *m, size_t total_len)
 	return xsk_generic_xmit(sk, m, total_len);
 }
 
-static unsigned int xsk_poll(struct file *file, struct socket *sock,
-			     struct poll_table_struct *wait)
+static __poll_t xsk_poll_mask(struct socket *sock, __poll_t events)
 {
-	unsigned int mask = datagram_poll(file, sock, wait);
+	__poll_t mask = datagram_poll_mask(sock, events);
 	struct sock *sk = sock->sk;
 	struct xdp_sock *xs = xdp_sk(sk);
 
@@ -580,7 +579,7 @@ static const struct proto_ops xsk_proto_ops = {
 	.socketpair	= sock_no_socketpair,
 	.accept		= sock_no_accept,
 	.getname	= sock_no_getname,
-	.poll		= xsk_poll,
+	.poll_mask	= xsk_poll_mask,
 	.ioctl		= sock_no_ioctl,
 	.listen		= sock_no_listen,
 	.shutdown	= sock_no_shutdown,
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-05-29  3:25 Stephen Rothwell
  2018-05-30 21:38 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-05-29  3:25 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Jakub Kicinski, Alexei Starovoitov, Daniel Borkmann

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

x86_64-linux-ld: unknown architecture of input file `net/bpfilter/bpfilter_umh.o' is incompatible with i386:x86-64 output

Caused by commit

  d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")

In my builds, the host is PowerPC 64 LE ...

I have reverted that commit along with

  61a552eb487f ("bpfilter: fix build dependency")
  13405468f49d ("bpfilter: don't pass O_CREAT when opening console for debug")

for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-02-28 23:30 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2018-02-28 23:30 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Arkadi Sharshevsky, Jiri Pirko

[-- Attachment #1: Type: text/plain, Size: 2321 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/core/devlink.c: In function 'devlink_resource_validate_size':
net/core/devlink.c:2349:34: error: invalid type argument of '->' (have 'struct devlink_resource_size_params')
  if (size > resource->size_params->size_max) {
                                  ^~
net/core/devlink.c:2354:34: error: invalid type argument of '->' (have 'struct devlink_resource_size_params')
  if (size < resource->size_params->size_min) {
                                  ^~
net/core/devlink.c:2359:43: error: invalid type argument of '->' (have 'struct devlink_resource_size_params')
  div64_u64_rem(size, resource->size_params->size_granularity, &reminder);
                                           ^~

Caused by commit

  cc944ead839a ("devlink: Move size validation to core")

interacting with commit

  77d270967c5f ("mlxsw: spectrum: Fix handling of resource_size_param")

from the net tree.

I have applied the following merge fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 1 Mar 2018 10:24:31 +1100
Subject: [PATCH] devlink: merge fix up for resource_size_param changes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/core/devlink.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index e7cb957d9efb..1b5bf0d1cee9 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2346,17 +2346,17 @@ devlink_resource_validate_size(struct devlink_resource *resource, u64 size,
 	u64 reminder;
 	int err = 0;
 
-	if (size > resource->size_params->size_max) {
+	if (size > resource->size_params.size_max) {
 		NL_SET_ERR_MSG_MOD(extack, "Size larger than maximum");
 		err = -EINVAL;
 	}
 
-	if (size < resource->size_params->size_min) {
+	if (size < resource->size_params.size_min) {
 		NL_SET_ERR_MSG_MOD(extack, "Size smaller than minimum");
 		err = -EINVAL;
 	}
 
-	div64_u64_rem(size, resource->size_params->size_granularity, &reminder);
+	div64_u64_rem(size, resource->size_params.size_granularity, &reminder);
 	if (reminder) {
 		NL_SET_ERR_MSG_MOD(extack, "Wrong granularity");
 		err = -EINVAL;
-- 
2.16.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-01-29  1:50 Stephen Rothwell
  2018-01-29  2:09 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-01-29  1:50 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kirill Tkhai,
	Dan Streetman

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from /home/sfr/next/next/include/linux/init_task.h:17:0,
                 from /home/sfr/next/next/init/init_task.c:2:
/home/sfr/next/next/include/net/net_namespace.h: In function 'check_net':
/home/sfr/next/next/include/net/net_namespace.h:228:21: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  return atomic_read(&net->count) != 0;
                     ^
In file included from /home/sfr/next/next/include/linux/atomic.h:5:0,
                 from /home/sfr/next/next/include/linux/rcupdate.h:38,
                 from /home/sfr/next/next/include/linux/init_task.h:5,
                 from /home/sfr/next/next/init/init_task.c:2:
/home/sfr/next/next/arch/powerpc/include/asm/atomic.h:34:23: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'const refcount_t * {aka const struct refcount_struct *}'
 static __inline__ int atomic_read(const atomic_t *v)
                       ^~~~~~~~~~~

and several others similar.

Caused by commit

  273c28bc57ca ("net: Convert atomic_t net::count to refcount_t")

interacting with commit

  4ee806d51176 ("net: tcp: close sock if net namespace is exiting")

from the net tree.

I have applied the following merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Jan 2018 12:34:37 +1100
Subject: [PATCH] net: fixup for "net: tcp: close sock if net namespace is exiting"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/net/net_namespace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index 235105afa5e1..f306b2aa15a4 100644
--- a/include/net/net_namespace.h
+++ b/include/net/net_namespace.h
@@ -225,7 +225,7 @@ int net_eq(const struct net *net1, const struct net *net2)
 
 static inline int check_net(const struct net *net)
 {
-	return atomic_read(&net->count) != 0;
+	return refcount_read(&net->count) != 0;
 }
 
 void net_drop_ns(void *);
-- 
2.15.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-01-11  0:53 Stephen Rothwell
  2018-01-11  1:58 ` Alexei Starovoitov
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2018-01-11  0:53 UTC (permalink / raw)
  To: David Miller, Networking, Daniel Borkmann, Alexei Starovoitov
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

kernel/bpf/verifier.o: In function `bpf_check':
verifier.c:(.text+0xd86e): undefined reference to `bpf_patch_call_args'

Caused by commit

  1ea47e01ad6e ("bpf: add support for bpf_call to interpreter")

interacting with commit

  290af86629b2 ("bpf: introduce BPF_JIT_ALWAYS_ON config")

from the bpf and net trees.

I have just reverted commit 290af86629b2 for today.  A better solution
would be nice (lie fixing this in a merge between the net-next and net
trees).

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2018-01-10  4:06 Stephen Rothwell
  2018-01-10  5:53 ` Jason Wang
  2018-01-10 20:53 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2018-01-10  4:06 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Jason Wang

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

net/socket.o: In function `tun_xdp_to_ptr':
(.text+0x3180): multiple definition of `tun_xdp_to_ptr'
fs/compat_ioctl.o:compat_ioctl.c:(.text+0x0): first defined here
net/socket.o: In function `tun_ptr_to_xdp':
(.text+0x31a0): multiple definition of `tun_ptr_to_xdp'
fs/compat_ioctl.o:compat_ioctl.c:(.text+0x20): first defined here

Caused by commit

  fc72d1d54dd9 ("tuntap: XDP transmission")

I applied the following fix for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 10 Jan 2018 15:01:41 +1100
Subject: [PATCH] tuntap: fix for "tuntap: XDP transmission"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/if_tun.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/if_tun.h b/include/linux/if_tun.h
index 08e66827ad8e..c5b0a75a7812 100644
--- a/include/linux/if_tun.h
+++ b/include/linux/if_tun.h
@@ -42,11 +42,11 @@ static inline bool tun_is_xdp_buff(void *ptr)
 {
 	return false;
 }
-void *tun_xdp_to_ptr(void *ptr)
+static inline void *tun_xdp_to_ptr(void *ptr)
 {
 	return NULL;
 }
-void *tun_ptr_to_xdp(void *ptr)
+static inline void *tun_ptr_to_xdp(void *ptr)
 {
 	return NULL;
 }
-- 
2.15.1




-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-12-22  0:45 Stephen Rothwell
  2017-12-22  7:51 ` Ido Schimmel
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2017-12-22  0:45 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Ido Schimmel,
	Eric Dumazet

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/ipv6/route.c: In function 'inet6_rtm_getroute':
net/ipv6/route.c:4324:25: error: 'struct dst_entry' has no member named 'from'
  if (fibmatch && rt->dst.from) {
                         ^
In file included from include/linux/uio.h:12:0,
                 from include/linux/socket.h:8,
                 from net/ipv6/route.c:34:
net/ipv6/route.c:4325:46: error: 'struct dst_entry' has no member named 'from'
   struct rt6_info *ort = container_of(rt->dst.from,
                                              ^
include/linux/kernel.h:929:26: note: in definition of macro 'container_of'
  void *__mptr = (void *)(ptr);     \
                          ^
In file included from include/linux/kernel.h:10:0,
                 from include/linux/uio.h:12,
                 from include/linux/socket.h:8,
                 from net/ipv6/route.c:34:
net/ipv6/route.c:4325:46: error: 'struct dst_entry' has no member named 'from'
   struct rt6_info *ort = container_of(rt->dst.from,
                                              ^
include/linux/compiler.h:301:19: note: in definition of macro '__compiletime_assert'
   bool __cond = !(condition);    \
                   ^
include/linux/compiler.h:324:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
  ^
include/linux/build_bug.h:47:37: note: in expansion of macro 'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^
include/linux/kernel.h:930:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
  ^
include/linux/kernel.h:930:20: note: in expansion of macro '__same_type'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
                    ^
net/ipv6/route.c:4325:26: note: in expansion of macro 'container_of'
   struct rt6_info *ort = container_of(rt->dst.from,
                          ^
net/ipv6/route.c:4325:46: error: 'struct dst_entry' has no member named 'from'
   struct rt6_info *ort = container_of(rt->dst.from,
                                              ^
include/linux/compiler.h:301:19: note: in definition of macro '__compiletime_assert'
   bool __cond = !(condition);    \
                   ^
include/linux/compiler.h:324:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
  ^
include/linux/build_bug.h:47:37: note: in expansion of macro 'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^
include/linux/kernel.h:930:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
  ^
include/linux/kernel.h:931:6: note: in expansion of macro '__same_type'
     !__same_type(*(ptr), void),   \
      ^
net/ipv6/route.c:4325:26: note: in expansion of macro 'container_of'
   struct rt6_info *ort = container_of(rt->dst.from,
                          ^

Caused by commit

  3a2232e92e87 ("ipv6: Move dst->from into struct rt6_info")

interacting with commit

  58acfd714e6b ("ipv6: Honor specified parameters in fibmatch lookup"

from the net tree.

I have added the following merge fix patch for today (I am guessing
a bit here):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 22 Dec 2017 11:25:13 +1100
Subject: [PATCH] ipv6: fix up for "ipv6: Move dst->from into struct rt6_info"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ipv6/route.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 4efaac956f0c..2490280b3394 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -4321,9 +4321,8 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
 		goto errout;
 	}
 
-	if (fibmatch && rt->dst.from) {
-		struct rt6_info *ort = container_of(rt->dst.from,
-						    struct rt6_info, dst);
+	if (fibmatch && rt->from) {
+		struct rt6_info *ort = rt->from;
 
 		dst_hold(&ort->dst);
 		ip6_rt_put(rt);
-- 
2.15.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-12-20 23:43 Stephen Rothwell
  2017-12-20 23:59 ` Jakub Kicinski
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2017-12-20 23:43 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Jakub Kicinski, Daniel Borkmann

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/netdevsim/bpf.c: In function 'nsim_bpf_setup_tc_block_cb':
drivers/net/netdevsim/bpf.c:127:7: error: 'TC_CLSBPF_REPLACE' undeclared (first use in this function)
  case TC_CLSBPF_REPLACE:
       ^
drivers/net/netdevsim/bpf.c:129:7: error: 'TC_CLSBPF_ADD' undeclared (first use in this function)
  case TC_CLSBPF_ADD:
       ^
drivers/net/netdevsim/bpf.c:131:7: error: 'TC_CLSBPF_DESTROY' undeclared (first use in this function)
  case TC_CLSBPF_DESTROY:
       ^

Caused by commit

  31d3ad832948 ("netdevsim: add bpf offload support")

interacting with commit

  102740bd9436 ("cls_bpf: fix offload assumptions after callback conversion")

from the net tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 21 Dec 2017 10:18:46 +1100
Subject: [PATCH] netdevsim: fix up for "cls_bpf: fix offload assumptions after
 callback conversion"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/netdevsim/bpf.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/net/netdevsim/bpf.c b/drivers/net/netdevsim/bpf.c
index 7da814686ad9..afaf980bbbe7 100644
--- a/drivers/net/netdevsim/bpf.c
+++ b/drivers/net/netdevsim/bpf.c
@@ -123,16 +123,10 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type,
 	if (prog && !prog->aux->offload && !ns->bpf_tc_non_bound_accept)
 		return -EOPNOTSUPP;
 
-	switch (cls_bpf->command) {
-	case TC_CLSBPF_REPLACE:
-		return nsim_bpf_offload(ns, prog, true);
-	case TC_CLSBPF_ADD:
-		return nsim_bpf_offload(ns, prog, false);
-	case TC_CLSBPF_DESTROY:
-		return nsim_bpf_offload(ns, NULL, true);
-	default:
+	if (cls_bpf->command != TC_CLSBPF_OFFLOAD)
 		return -EOPNOTSUPP;
-	}
+
+	return nsim_bpf_offload(ns, prog, cls_bpf->oldprog);
 }
 
 int nsim_bpf_disable_tc(struct netdevsim *ns)
-- 
2.15.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-09-29  1:36 Stephen Rothwell
  2017-09-29  2:07 ` Florian Fainelli
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2017-09-29  1:36 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Vivien Didelot, Florian Fainelli

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/dsa/slave.c: In function 'dsa_slave_create':
net/dsa/slave.c:1191:18: error: 'struct dsa_slave_priv' has no member named 'phy'
  phy_disconnect(p->phy);
                  ^

Caused by commit

  0115dcd1787d ("net: dsa: use slave device phydev")

Interacting with commit

  e804441cfe0b ("net: dsa: Fix network device registration order")

from the net tree.

I applied the following merge fix patch (which I am not sure about):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 29 Sep 2017 11:28:45 +1000
Subject: [PATCH] net: dsa: merge fix patch for removal of phy

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/dsa/slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 8869954485db..9191c929c6c8 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1188,7 +1188,7 @@ int dsa_slave_create(struct dsa_port *port, const char *name)
 	return 0;
 
 out_phy:
-	phy_disconnect(p->phy);
+	phy_disconnect(slave_dev->phydev);
 	if (of_phy_is_fixed_link(p->dp->dn))
 		of_phy_deregister_fixed_link(p->dp->dn);
 out_free:
-- 
2.14.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-09-22  1:03 Stephen Rothwell
  2017-09-22  1:37 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2017-09-22  1:03 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Paolo Abeni

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/ipv4/fib_frontend.c: In function 'fib_validate_source':
net/ipv4/fib_frontend.c:411:16: error: 'struct netns_ipv4' has no member named 'fib_has_custom_local_routes'
   if (net->ipv4.fib_has_custom_local_routes)
                ^
net/ipv4/fib_frontend.c: In function 'inet_rtm_newroute':
net/ipv4/fib_frontend.c:773:12: error: 'struct netns_ipv4' has no member named 'fib_has_custom_local_routes'
   net->ipv4.fib_has_custom_local_routes = true;
            ^

Caused by commit

  6e617de84e87 ("net: avoid a full fib lookup when rp_filter is disabled.")

This build has CONFIG_IP_MULTIPLE_TABLES unset.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-08-15  2:28 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2017-08-15  2:28 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Wu

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arch/arm/boot/dts/rk3228-evb.dtb: ERROR (phandle_references): Reference to non-existent node or label "phy0"

Caused by commit

  db40f15b53e4 ("ARM: dts: rk3228-evb: Enable the integrated PHY for gmac")

Its possible that the error is caused by an interaction with another
commit, but I could not find anything obvious.  I have reverted that
commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-07-18  1:09 Stephen Rothwell
  2017-07-18  4:59 ` John Fastabend
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2017-07-18  1:09 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	John Fastabend, Jesper Dangaard Brouer, Daniel Borkmann

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/core/filter.o: In function `xdp_do_flush_map':
filter.c:(.text+0x3770): undefined reference to `__dev_map_flush'
net/core/filter.o: In function `__bpf_tx_xdp':
filter.c:(.text+0x56dc): undefined reference to `__dev_map_insert_ctx'
net/core/filter.o: In function `xdp_do_redirect_map':
filter.c:(.text+0x5e24): undefined reference to `__dev_map_lookup_elem'

Caused by commit

  11393cc9b9be ("xdp: Add batching support to redirect map")

This build has

CONFIG_BPF=y
# CONFIG_BPF_SYSCALL is not set

I have used the net-next tree from next-20170717 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-05-22  1:16 Stephen Rothwell
  2017-05-22  3:14 ` David Miller
  2017-05-22  3:42 ` Willem de Bruijn
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2017-05-22  1:16 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Miroslav Lichvar, Willem de Bruijn

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/socket.c: In function 'put_ts_pktinfo':
net/socket.c:695:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function)
  put_cmsg(msg, SOL_SOCKET, SCM_TIMESTAMPING_PKTINFO,
                            ^

Caused by commit

  aad9c8c470f2 ("net: add new control message for incoming HW-timestamped packets")

This probably broke every architecture that has its own
arch/<arch>/include/uapi/asm/socket.h that does not include
include/uapi/asm-generic/socket.h :-(

I have used the net-next tree from next-20170519 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2017-01-09 23:59 Stephen Rothwell
  2017-01-10 15:14 ` Ursula Braun
  2017-02-22 23:34 ` Stephen Rothwell
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2017-01-09 23:59 UTC (permalink / raw)
  To: David Miller, Networking, Al Viro
  Cc: linux-next, linux-kernel, Ursula Braun, Utz Bacher

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/smc/af_smc.c: In function 'smc_splice_read':
net/smc/af_smc.c:1258:39: error: passing argument 1 of 'smc->clcsock->ops->splice_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
   rc = smc->clcsock->ops->splice_read(smc->clcsock, ppos,
                                       ^
net/smc/af_smc.c:1258:39: note: expected 'struct file *' but argument is of type 'struct socket *'
net/smc/af_smc.c: At top level:
net/smc/af_smc.c:1288:17: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .splice_read = smc_splice_read,   
                 ^
net/smc/af_smc.c:1288:17: note: (near initialization for 'smc_sock_ops.splice_read')

Caused by commit

  ac7138746e14 ("smc: establish new socket family")

interacting with commit

  15a8f657c71d ("switch socket ->splice_read() to struct file *")

from the vfs tree.

I applied the following merge fix patch which could well be incorrect ...

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 Jan 2017 10:52:38 +1100
Subject: [PATCH] smc: merge fix for "switch socket ->splice_read() to struct file *"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/smc/af_smc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 5d4208ad029e..4875e65f0c4a 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1242,10 +1242,11 @@ static ssize_t smc_sendpage(struct socket *sock, struct page *page,
 	return rc;
 }
 
-static ssize_t smc_splice_read(struct socket *sock, loff_t *ppos,
+static ssize_t smc_splice_read(struct file *file, loff_t *ppos,
 			       struct pipe_inode_info *pipe, size_t len,
 				    unsigned int flags)
 {
+	struct socket *sock = file->private_data;
 	struct sock *sk = sock->sk;
 	struct smc_sock *smc;
 	int rc = -ENOTCONN;
@@ -1255,7 +1256,7 @@ static ssize_t smc_splice_read(struct socket *sock, loff_t *ppos,
 	if ((sk->sk_state != SMC_ACTIVE) && (sk->sk_state != SMC_CLOSED))
 		goto out;
 	if (smc->use_fallback) {
-		rc = smc->clcsock->ops->splice_read(smc->clcsock, ppos,
+		rc = smc->clcsock->ops->splice_read(file, ppos,
 						    pipe, len, flags);
 	} else {
 		rc = -EOPNOTSUPP;
-- 
2.10.2

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2016-05-10  1:29 Stephen Rothwell
  2016-05-10  1:32 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2016-05-10  1:29 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:37:0:
drivers/net/ethernet/mellanox/mlx5/core/en.h:525:29: error: field 'fts' has incomplete type
  struct mlx5e_flow_tables   fts;   
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en.h:526:29: error: field 'eth_addr' has incomplete type
  struct mlx5e_eth_addr_db   eth_addr;
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en.h:527:29: error: field 'vlan' has incomplete type
  struct mlx5e_vlan_db       vlan;  
                             ^
In file included from drivers/net/ethernet/mellanox/mlx5/core/en_fs.c:38:0:
drivers/net/ethernet/mellanox/mlx5/core/en.h:525:29: error: field 'fts' has incomplete type
  struct mlx5e_flow_tables   fts;   
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en.h:526:29: error: field 'eth_addr' has incomplete type
  struct mlx5e_eth_addr_db   eth_addr;
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en.h:527:29: error: field 'vlan' has incomplete type
  struct mlx5e_vlan_db       vlan;  
                             ^
In file included from drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:33:0:
drivers/net/ethernet/mellanox/mlx5/core/en.h:525:29: error: field 'fts' has incomplete type
  struct mlx5e_flow_tables   fts;   
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en.h:526:29: error: field 'eth_addr' has incomplete type
  struct mlx5e_eth_addr_db   eth_addr;
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en.h:527:29: error: field 'vlan' has incomplete type
  struct mlx5e_vlan_db       vlan;  
                             ^
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2619:0: error: unterminated #ifdef
 #ifdef CONFIG_MLX5_CORE_EN_VXLAN   
 ^

Caused by commit

  e800072c18f0 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")

which seems to have reversed some of the merge fixes in commit

  cba653210056 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")

But I am not reaaly sure what has happened here :-(

I tried to use the net-next tree from next-20160509 but that now has
conflicts agains other changes, so I applied the following fix patch
for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 May 2016 11:20:23 +1000
Subject: [PATCH] net-next: fix bad merge

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/en.h      | 3 ---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
index 7aea32e085b3..19b1b021af2d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
@@ -522,9 +522,6 @@ struct mlx5e_priv {
 	struct mlx5e_direct_tir    direct_tir[MLX5E_MAX_NUM_CHANNELS];
 
 	struct mlx5e_flow_steering fs;
-	struct mlx5e_flow_tables   fts;
-	struct mlx5e_eth_addr_db   eth_addr;
-	struct mlx5e_vlan_db       vlan;
 #ifdef CONFIG_MLX5_CORE_EN_VXLAN
 	struct mlx5e_vxlan_db      vxlan;
 #endif
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index b60a1bc6f457..98be1ce3afd8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -2620,6 +2620,7 @@ static const struct net_device_ops mlx5e_netdev_ops_sriov = {
 	.ndo_add_vxlan_port      = mlx5e_add_vxlan_port,
 	.ndo_del_vxlan_port      = mlx5e_del_vxlan_port,
 	.ndo_features_check      = mlx5e_features_check,
+#endif
 #ifdef CONFIG_RFS_ACCEL
 	.ndo_rx_flow_steer	 = mlx5e_rx_flow_steer,
 #endif
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2016-05-10  1:29 Stephen Rothwell
  2016-05-10  1:52 ` Andy Gross
  2016-05-10 18:39 ` Bjorn Andersson
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2016-05-10  1:29 UTC (permalink / raw)
  To: David Miller, netdev, Olof Johansson, Arnd Bergmann, linux-arm-kernel
  Cc: linux-next, linux-kernel, Bjorn Andersson, Andy Gross

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/qrtr/smd.c:106:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .callback = qcom_smd_qrtr_callback,
              ^
net/qrtr/smd.c:106:14: note: (near initialization for 'qcom_smd_qrtr_driver.callback')

Caused by commit

  bdabad3e363d ("net: Add Qualcomm IPC router")

interacting with commit

  b853cb9628bf ("soc: qcom: smd: Make callback pass channel reference")

from the arm-soc tree.

I added the following merge fix patch (and it turned out I needed the
new stubs).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 May 2016 11:14:06 +1000
Subject: [PATCH] soc: qcom: smd: fix for Qualcomm IPC router and callback API
 change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/soc/qcom/smd.h | 9 +++++++++
 net/qrtr/smd.c               | 9 ++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/include/linux/soc/qcom/smd.h b/include/linux/soc/qcom/smd.h
index 086e36d76be9..fbebbfc82ed3 100644
--- a/include/linux/soc/qcom/smd.h
+++ b/include/linux/soc/qcom/smd.h
@@ -70,6 +70,15 @@ static inline void qcom_smd_driver_unregister(struct qcom_smd_driver *drv)
 	WARN_ON(1);
 }
 
+static inline void *qcom_smd_get_drvdata(struct qcom_smd_channel *channel)
+{
+	return NULL;
+}
+
+static inline void qcom_smd_set_drvdata(struct qcom_smd_channel *channel, void *data)
+{
+}
+
 static inline int qcom_smd_send(struct qcom_smd_channel *channel,
 				const void *data, int len)
 {
diff --git a/net/qrtr/smd.c b/net/qrtr/smd.c
index 84ebce73aa23..0d11132b3370 100644
--- a/net/qrtr/smd.c
+++ b/net/qrtr/smd.c
@@ -21,13 +21,14 @@
 struct qrtr_smd_dev {
 	struct qrtr_endpoint ep;
 	struct qcom_smd_channel *channel;
+	struct device *dev;
 };
 
 /* from smd to qrtr */
-static int qcom_smd_qrtr_callback(struct qcom_smd_device *sdev,
+static int qcom_smd_qrtr_callback(struct qcom_smd_channel *channel,
 				  const void *data, size_t len)
 {
-	struct qrtr_smd_dev *qdev = dev_get_drvdata(&sdev->dev);
+	struct qrtr_smd_dev *qdev = qcom_smd_get_drvdata(channel);
 	int rc;
 
 	if (!qdev)
@@ -35,7 +36,7 @@ static int qcom_smd_qrtr_callback(struct qcom_smd_device *sdev,
 
 	rc = qrtr_endpoint_post(&qdev->ep, data, len);
 	if (rc == -EINVAL) {
-		dev_err(&sdev->dev, "invalid ipcrouter packet\n");
+		dev_err(qdev->dev, "invalid ipcrouter packet\n");
 		/* return 0 to let smd drop the packet */
 		rc = 0;
 	}
@@ -73,12 +74,14 @@ static int qcom_smd_qrtr_probe(struct qcom_smd_device *sdev)
 		return -ENOMEM;
 
 	qdev->channel = sdev->channel;
+	qdev->dev = &sdev->dev;
 	qdev->ep.xmit = qcom_smd_qrtr_send;
 
 	rc = qrtr_endpoint_register(&qdev->ep, QRTR_EP_NID_AUTO);
 	if (rc)
 		return rc;
 
+	qcom_smd_set_drvdata(sdev->channel, qdev);
 	dev_set_drvdata(&sdev->dev, qdev);
 
 	dev_dbg(&sdev->dev, "Qualcomm SMD QRTR driver probed\n");
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2016-04-13  7:50 Stephen Rothwell
  2016-04-13 15:15 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2016-04-13  7:50 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Mark Rustad, Jeff Kirsher,
	Andrew Bowers, Build bot for Mark Brown, kernel-build-reports,
	linaro-kernel

Hi all,

[A report from Mark's buildbot]

After merging the net-next tree, today's linux-next build (arm
allmodconfig) failed like thisi (this has actually been failing for a
few days, now):

ERROR: "__bad_udelay" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko] undefined!

Caused by commit

  49425dfc7451 ("ixgbe: Add support for x550em_a 10G MAC type")

arm only allows udelay()s up to 2 milliseconds.  This commit
adds a 5 ms udelay in ixgbe_acquire_swfw_sync_x550em_a() in
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2016-02-18  1:28 Stephen Rothwell
  2016-02-18 20:28 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2016-02-18  1:28 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Yuval Mintz, Ariel Elior

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:56:0,
                 from drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:30:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c: In function 'bnx2x_dcbx_get_ap_feature':
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:224:11: error: 'DCBX_APP_SF_DEFAULT' undeclared (first use in this function)
           DCBX_APP_SF_DEFAULT) &&  
           ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.h:120:45: note: in definition of macro 'GET_FLAGS'
 #define GET_FLAGS(flags, bits)  ((flags) & (bits))
                                             ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:224:11: note: each undeclared identifier is reported only once for each function it appears in
           DCBX_APP_SF_DEFAULT) &&  
           ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.h:120:45: note: in definition of macro 'GET_FLAGS'
 #define GET_FLAGS(flags, bits)  ((flags) & (bits))
                                             ^

Caused by commit

  e5d3a51cefbb ("This adds support for default application priority.")

This build is big endian.

I have used the net-next tree from next-20160217 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2016-01-11  2:46 Stephen Rothwell
  2016-01-11  3:02 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2016-01-11  2:46 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Andrew Lunn, Roosen Henri

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/net/phy/micrel.c: In function 'ksz9031_config_init':
drivers/net/phy/micrel.c:492:22: error: 'struct phy_device' has no member named 'dev'
  dev_walker = &phydev->dev;
                      ^

Caused by commit

  e5a03bfd873c ("phy: Add an mdio_device structure")

interacting with commit

  b4c19f71252e ("phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.")

from the net tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 11 Jan 2016 13:25:09 +1100
Subject: [PATCH] phy: micrel: fix up for "phy: Add an mdio_device structure"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/phy/micrel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 41b598548f2e..03833dbfca67 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -489,7 +489,7 @@ static int ksz9031_config_init(struct phy_device *phydev)
 	 * properties in the MAC node. Walk up the tree of devices to
 	 * find a device with an OF node.
 	 */
-	dev_walker = &phydev->dev;
+	dev_walker = &phydev->mdio.dev;
 	do {
 		of_node = dev_walker->of_node;
 		dev_walker = dev_walker->parent;
-- 
2.6.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-10-06  5:34 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2015-10-06  5:34 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Peter Nørlund

Hi all,

After merging the net-next tree, today's linux-next build (i386 defconfig)
failed like this:

net/built-in.o: In function `fib_rebalance':
fib_semantics.c:(.text+0x9d6d4): undefined reference to `__divdi3'

Caused by commit

  0e884c78ee19 ("ipv4: L3 hash-based multipath")

I have reverted that commit (and the following commit since it may depend
on the former) for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-08-24  3:21 Stephen Rothwell
  2015-08-24  3:33 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-08-24  3:21 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Jiri Benc

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In function 'dst_hold',
    inlined from '__ipv6_dev_ac_dec' at /home/sfr/next/next/net/ipv6/anycast.c:328:2:
/home/sfr/next/next/include/linux/compiler.h:447:38: error: call to '__compiletime_assert_243' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct dst_entry, __refcnt) & 63
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
                                      ^
/home/sfr/next/next/include/linux/compiler.h:430:4: note: in definition of macro '__compiletime_assert'
    prefix ## suffix();    \
    ^
/home/sfr/next/next/include/linux/compiler.h:447:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
  ^
/home/sfr/next/next/include/linux/bug.h:50:37: note: in expansion of macro 'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^
/home/sfr/next/next/include/linux/bug.h:74:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
  ^
/home/sfr/next/next/include/net/dst.h:243:2: note: in expansion of macro 'BUILD_BUG_ON'
  BUILD_BUG_ON(offsetof(struct dst_entry, __refcnt) & 63);
  ^

And many more :-(

Caused by commit

  61adedf3e3f1 ("route: move lwtunnel state to dst_entry")

I have used the net-next tree from next-20150821 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-08-20  2:57 Stephen Rothwell
  2015-08-20  5:16 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-08-20  2:57 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Jiri Benc

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/ipv4/fib_semantics.c: In function 'fib_encap_match':
net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function 'lwtstate_free' [-Werror=implicit-function-declaration]
   lwtstate_free(lwtstate);
   ^

Caused by commit

  df383e6240ef ("lwtunnel: fix memory leak")

CONFIG_LWTUNNEL is not set for this build.

I reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-08-18  8:39 Stephen Rothwell
  2015-08-18 21:25 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-08-18  8:39 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Govindarajulu Varadarajan,
	N V V Satyanarayana Reddy

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/built-in.o: In function `.vnic_wq_devcmd2_alloc':
(.text+0x49fe40): multiple definition of `.vnic_wq_devcmd2_alloc'
drivers/scsi/built-in.o:(.text+0xb4318): first defined here
drivers/net/built-in.o:(.opd+0x2af00): multiple definition of `vnic_wq_devcmd2_alloc'
drivers/scsi/built-in.o:(.opd+0xad70): first defined here
drivers/net/built-in.o: In function `.vnic_wq_init_start':
(.text+0x49f9c0): multiple definition of `.vnic_wq_init_start'
drivers/scsi/built-in.o:(.text+0xb3b58): first defined here
drivers/net/built-in.o:(.opd+0x2ae88): multiple definition of `vnic_wq_init_start'
drivers/scsi/built-in.o:(.opd+0xace0): first defined here

Caused by commit

  373fb0873d43 ("enic: add devcmd2")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-07-23  1:58 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2015-07-23  1:58 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Thomas Graf

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/ipv4/ip_tunnel_core.c:301:1: warning: data definition has no type or storage class
 module_init(ip_tunnel_core_init);
 ^
net/ipv4/ip_tunnel_core.c:301:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
net/ipv4/ip_tunnel_core.c:301:1: warning: parameter names (without types) in function declaration
net/ipv4/ip_tunnel_core.c:307:1: warning: data definition has no type or storage class
 module_exit(ip_tunnel_core_exit);
 ^
net/ipv4/ip_tunnel_core.c:307:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
net/ipv4/ip_tunnel_core.c:307:1: warning: parameter names (without types) in function declaration
net/ipv4/ip_tunnel_core.c:295:19: warning: 'ip_tunnel_core_init' defined but not used [-Wunused-function]
 static int __init ip_tunnel_core_init(void)
                   ^

Caused by commit

  3093fbe7ff4b ("route: Per route IP tunnel metadata via lightweight tunnel")

Forgot to include module.h ...

I have used the net-next tree from next-20150722 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-06-24  7:37 Stephen Rothwell
  2015-06-24  8:01 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-06-24  7:37 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Suman Tripathi, Iyappan Subramanian

[-- Attachment #1: Type: text/plain, Size: 2020 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (KCONFIG_NAME)
failed like this:

drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function 'xgene_get_port_id_acpi':
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:880:2: error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
  status = acpi_evaluate_integer(ACPI_HANDLE(dev), "_SUN", NULL, &temp);
  ^
drivers/net/ethernet/apm/xgene/xgene_enet_main.c: At top level:
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:874:12: warning: 'xgene_get_port_id_acpi' defined but not used [-Wunused-function]
 static int xgene_get_port_id_acpi(struct device *dev,
            ^

Caused by commit 0738c54d6324 ("drivers: net: xgene: Fix the ACPI support
for RGMII/SGMII0/XFI interface of APM X-Gene SoC ethernet controller").

I have applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 24 Jun 2015 17:29:51 +1000
Subject: [PATCH] drivers: net: xgene: fix for ACPI support without ACPI

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index b334f279ce8d..95153b234c71 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -871,6 +871,7 @@ static const struct net_device_ops xgene_ndev_ops = {
 	.ndo_set_mac_address = xgene_enet_set_mac_address,
 };
 
+#ifdef CONFIG_ACPI
 static int xgene_get_port_id_acpi(struct device *dev,
 				  struct xgene_enet_pdata *pdata)
 {
@@ -886,6 +887,7 @@ static int xgene_get_port_id_acpi(struct device *dev,
 
 	return 0;
 }
+#endif
 
 static int xgene_get_port_id_dt(struct device *dev, struct xgene_enet_pdata *pdata)
 {
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-06-01  3:44 Stephen Rothwell
  2015-06-01  4:35 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-06-01  3:44 UTC (permalink / raw)
  To: David Miller, netdev, Rusty Russell
  Cc: linux-next, linux-kernel, Saeed Mahameed, Rana Shahout,
	Achiad Shochat, Amir Vadai

[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/mellanox/mlx5/core/main.c: In function 'mlx5_irq_set_affinity_hint':
drivers/net/ethernet/mellanox/mlx5/core/main.c:474:2: error: implicit declaration of function 'cpumask_set_cpu_local_first' [-Werror=implicit-function-declaration]
  err = cpumask_set_cpu_local_first(i, numa_node, priv->irq_info[i].mask);
  ^

Caused by commit db058a186f98 ("net/mlx5_core: Set irq affinity hints")
interacting with commit f36963c9d3f6 ("cpumask_set_cpu_local_first =>
cpumask_local_spread, lament") from Linus' tree.

I have applied the following merge fix patch (Dave, you could do this
by back merging commit f36963c9d3f6 from Linus' tree - which is based
on v4.1-rc2 if that worries you).  Please yell if this is not correct
(it does build).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 1 Jun 2015 13:36:49 +1000
Subject: [PATCH] net/mlx5_core: merge fix for cpumask_set_cpu_local_first API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/main.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 1c37f587426d..2510fed3494d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -471,11 +471,8 @@ static int mlx5_irq_set_affinity_hint(struct mlx5_core_dev *mdev, int i)
 		return -ENOMEM;
 	}
 
-	err = cpumask_set_cpu_local_first(i, numa_node, priv->irq_info[i].mask);
-	if (err) {
-		mlx5_core_warn(mdev, "cpumask_set_cpu_local_first failed");
-		goto err_clear_mask;
-	}
+	cpumask_set_cpu(cpumask_local_spread(i, numa_node),
+			priv->irq_info[i].mask);
 
 	err = irq_set_affinity_hint(irq, priv->irq_info[i].mask);
 	if (err) {
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-03-30  4:05 Stephen Rothwell
  2015-03-31 18:13 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-03-30  4:05 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Ben Hutchings

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_fill_tx_frame':
drivers/net/usb/cdc_ncm.c:1187:2: error: too few arguments to function 'usbnet_set_skb_tx_stats'
  usbnet_set_skb_tx_stats(skb_out, n);
  ^
In file included from drivers/net/usb/cdc_ncm.c:51:0:
include/linux/usb/usbnet.h:238:1: note: declared here
 usbnet_set_skb_tx_stats(struct sk_buff *skb,
 ^

Caused by a bad merge between commits 1e9e39f4a298 ("usbnet: Fix
tx_packets stat for FLAG_MULTI_FRAME drivers") and 7a1e890e2168
("usbnet: Fix tx_bytes statistic running backward in cdc_ncm") form the
net tree and commit 6588af614e7b ("usbnet: Fix tx_packets stat for
FLAG_MULTI_FRAME drivers") from the net-next tree.  (Presumably,
6588af614e7b was cherry-picked as a bug fix.  So, Dave, something to
watch for if you merge net into net-next.)

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Mar 2015 14:59:49 +1100
Subject: [PATCH] usbnet: fix bad merge in cdc_ncm.c

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/usb/cdc_ncm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index ee6fed0af6f5..c3e4da9e79ca 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1184,8 +1184,6 @@ cdc_ncm_fill_tx_frame(struct usbnet *dev, struct sk_buff *skb, __le32 sign)
 	usbnet_set_skb_tx_stats(skb_out, n,
 				ctx->tx_curr_frame_payload - skb_out->len);
 
-	usbnet_set_skb_tx_stats(skb_out, n);
-
 	return skb_out;
 
 exit_no_skb:
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-03-24  2:45 Stephen Rothwell
  2015-03-24  3:00 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-03-24  2:45 UTC (permalink / raw)
  To: David Miller, netdev, Al Viro
  Cc: linux-next, linux-kernel, Christoph Hellwig, Tadeusz Struk

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

crypto/algif_skcipher.c: In function 'skcipher_async_cb':
crypto/algif_skcipher.c:109:2: error: implicit declaration of function 'aio_complete' [-Werror=implicit-function-declaration]
  aio_complete(iocb, err, err);
  ^

Caused by commit a596999b7ddf ("crypto: algif - change algif_skcipher
to be asynchronous") interacting with commit 04b2fa9f8f36 ("fs: split
generic and aio kiocb") from the vfs tree.

I applied the following merge fix patch (which gets it building, but I
am not sure if more is needed).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 24 Mar 2015 13:40:45 +1100
Subject: [PATCH] crypto: algif - cope with aio_complete() going away

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/algif_skcipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c
index 8276f21ea7be..506eb5f62b03 100644
--- a/crypto/algif_skcipher.c
+++ b/crypto/algif_skcipher.c
@@ -106,7 +106,7 @@ static void skcipher_async_cb(struct crypto_async_request *req, int err)
 	atomic_dec(&ctx->inflight);
 	skcipher_free_async_sgls(sreq);
 	kfree(req);
-	aio_complete(iocb, err, err);
+	iocb->ki_complete(iocb, err, err);
 }
 
 static inline int skcipher_sndbuf(struct sock *sk)
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-03-05  2:42 Stephen Rothwell
  2015-03-05  5:01 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-03-05  2:42 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Eric W. Biederman

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/mpls/af_mpls.c: In function 'resize_platform_label_table':
net/mpls/af_mpls.c:767:4: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
    labels = vzalloc(size);
    ^

Caused by commit 7720c01f3f59 ("mpls: Add a sysctl to control the size
of the mpls label table").

I have added this commit for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 5 Mar 2015 13:37:05 +1100
Subject: [PATCH] mpls: using vzalloc requires including vmalloc.h

Fixes this build error:

net/mpls/af_mpls.c: In function 'resize_platform_label_table':
net/mpls/af_mpls.c:767:4: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
    labels = vzalloc(size);
    ^

Fixes: 7720c01f3f59 ("mpls: Add a sysctl to control the size of the mpls label table")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/mpls/af_mpls.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 23e51d13b0ff..20cf48a8593d 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -7,6 +7,7 @@
 #include <linux/if_arp.h>
 #include <linux/ipv6.h>
 #include <linux/mpls.h>
+#include <linux/vmalloc.h>
 #include <net/ip.h>
 #include <net/dst.h>
 #include <net/sock.h>
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-02-10 11:02 Stephen Rothwell
  2015-02-11  4:51 ` Jeff Kirsher
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-02-10 11:02 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Carolyn Wyborny, Jeff Kirsher

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (i386
allmodconfig and a few others) failed like this:

drivers/net/ethernet/intel/i40e/i40e_txrx.c: In function 'i40e_setup_rx_descriptors':
drivers/net/ethernet/intel/i40e/i40e_txrx.c:1101:3: error: incompatible type for argument 1 of '__seqcount_init'
include/linux/seqlock.h:53:20: note: expected 'struct seqcount_t *' but argument is of type 'seqcount_t'

Caused by commit 638702bd59a3 ("i40e/i40evf: Add call to u64_stats_init
to init").

Discovered after the release, so no fix done.

The indentation of the lines added by that patch is also a bit strange.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-02-09  3:07 Stephen Rothwell
  2015-02-09  5:52 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-02-09  3:07 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Herbert Xu

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

lib/rhashtable.c: In function 'rhashtable_walk_next':
lib/rhashtable.c:1002:3: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
   return ERR_PTR(-EAGAIN);
   ^
lib/rhashtable.c:1002:3: warning: return makes pointer from integer without a cast

Caused by commit f2dba9c6ff0d ("rhashtable: Introduce
rhashtable_walk_*"). See Rule 1 in Documentation/SubmitChecklist.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 9 Feb 2015 14:04:03 +1100
Subject: [PATCH] rhashtable: using ERR_PTR requires linux/err.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 lib/rhashtable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index e96fc00208bc..9cc4c4a90d00 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -23,6 +23,7 @@
 #include <linux/jhash.h>
 #include <linux/random.h>
 #include <linux/rhashtable.h>
+#include <linux/err.h>
 
 #define HASH_DEFAULT_SIZE	64UL
 #define HASH_MIN_SIZE		4UL
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-01-19  3:06 Stephen Rothwell
  2015-01-19  3:13 ` Marcel Holtmann
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-01-19  3:06 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Jiri Pirko, Scott Feldman, Gustavo Padovan

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from net/bridge/br.c:22:0:
include/net/switchdev.h:73:1: error: expected identifier or '(' before '{' token
 {
 ^
include/net/switchdev.h:71:19: warning: 'call_netdev_switch_notifiers' declared 'static' but never defined [-Wunused-function]
 static inline int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
                   ^

Caused by commit 03bf0c281234 ("switchdev: introduce switchdev notifier").

I have used the net-next tree from next-20150116 for today.  I also had
to use the bluetooth tree from next-20150116 as it was fast forwarded
to be the same as the net-next tree today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-01-12  3:05 Stephen Rothwell
  2015-01-12  3:08 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2015-01-12  3:05 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, WANG Cong, Vinson Lee

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

Documentation/networking/timestamping/txtimestamp.c: In function '__recv_errmsg_cmsg':
Documentation/networking/timestamping/txtimestamp.c:205:33: error: dereferencing pointer to incomplete type
Documentation/networking/timestamping/txtimestamp.c:206:23: error: dereferencing pointer to incomplete type

Caused by commit cd91cc5bdddf ("doc: fix the compile error of
txtimestamp.c").  On (at least) Debian stable, the system's definition
of struct in6_pktinfo depends on __USE_GNU being defined (at least, I
think that is the problem).

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2015-01-02 22:11 Stephen Rothwell
  2015-01-02 22:21 ` Sedat Dilek
                   ` (2 more replies)
  0 siblings, 3 replies; 394+ messages in thread
From: Stephen Rothwell @ 2015-01-02 22:11 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Richard Cochran, Jeff Kirsher

[-- Attachment #1: Type: text/plain, Size: 2463 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/mellanox/mlx4/en_clock.c: In function 'mlx4_en_init_timestamp':
drivers/net/ethernet/mellanox/mlx4/en_clock.c:249:2: error: implicit declaration of function 'CLOCKSOURCE_MASK' [-Werror=implicit-function-declaration]
  mdev->cycles.mask = CLOCKSOURCE_MASK(48);
  ^
drivers/net/ethernet/mellanox/mlx4/en_clock.c:257:3: error: implicit declaration of function 'clocksource_khz2mult' [-Werror=implicit-function-declaration]
   clocksource_khz2mult(1000 * dev->caps.hca_core_clock, mdev->cycles.shift);
   ^
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c: In function 'ixgbe_ptp_start_cyclecounter':
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c:796:2: error: implicit declaration of function 'CLOCKSOURCE_MASK' [-Werror=implicit-function-declaration]
  adapter->cc.mask = CLOCKSOURCE_MASK(64);
  ^

Presumably caused by commit 74d23cc704d1 ("time: move the
timecounter/cyclecounter code into its own file").

I added the following commit for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sat, 3 Jan 2015 09:07:21 +1100
Subject: [PATCH] ixgbe_ptp, mlx4: Include clocksource.h to get CLOCKSOURCE_MASK

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c  | 1 +
 drivers/net/ethernet/mellanox/mlx4/en_clock.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
index 47c29eaaa140..73548280cbae 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
@@ -25,6 +25,7 @@
   Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
 
 *******************************************************************************/
+#include <linux/clocksource.h>
 #include "ixgbe.h"
 #include <linux/ptp_classify.h>
 
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_clock.c b/drivers/net/ethernet/mellanox/mlx4/en_clock.c
index e9cce4f72b24..7c6ef4b48f8e 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_clock.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_clock.c
@@ -31,6 +31,7 @@
  *
  */
 
+#include <linux/clocksource.h>
 #include <linux/mlx4/device.h>
 
 #include "mlx4_en.h"
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-12-10  8:54 Stephen Rothwell
  2014-12-10 10:14 ` Hariprasad S
  2014-12-10 20:52 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2014-12-10  8:54 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Hariprasad Shenai

[-- Attachment #1: Type: text/plain, Size: 4399 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/chelsio/cxgb4vf/built-in.o:(.opd+0x630): multiple definition of `t4_bar2_sge_qregs'
drivers/net/ethernet/chelsio/cxgb4/built-in.o:(.opd+0x14d0): first defined here
drivers/net/ethernet/chelsio/cxgb4vf/built-in.o: In function `.t4_bar2_sge_qregs':
(.text+0x9220): multiple definition of `.t4_bar2_sge_qregs'
drivers/net/ethernet/chelsio/cxgb4/built-in.o:(.text+0x24e24): first defined here

Caused by commit e85c9a7abfa4 ("cxgb4/cxgb4vf: Add code to calculate T5
BAR2 Offsets for SGE Queue Registers") which added both versions.  :-(

I have applied this fir patch for today (including the subject
typo :-)):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 10 Dec 2014 19:48:02 +1100
Subject: [PATCH] cxgb4/cxgb4vf: global named must be unique

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h      | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 ++--
 drivers/net/ethernet/chelsio/cxgb4/sge.c        | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c      | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h
index 2c37e1bf253a..a18d33fdb271 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h
@@ -1007,7 +1007,7 @@ int t4_prep_fw(struct adapter *adap, struct fw_info *fw_info,
 int t4_prep_adapter(struct adapter *adapter);
 
 enum t4_bar2_qtype { T4_BAR2_QTYPE_EGRESS, T4_BAR2_QTYPE_INGRESS };
-int t4_bar2_sge_qregs(struct adapter *adapter,
+int cxgb4_t4_bar2_sge_qregs(struct adapter *adapter,
 		      unsigned int qid,
 		      enum t4_bar2_qtype qtype,
 		      u64 *pbar2_qoffset,
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index c8c5b3d36d4e..1645f59648f0 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -3815,7 +3815,7 @@ int cxgb4_bar2_sge_qregs(struct net_device *dev,
 			 u64 *pbar2_qoffset,
 			 unsigned int *pbar2_qid)
 {
-	return t4_bar2_sge_qregs(netdev2adap(dev),
+	return cxgb4_t4_bar2_sge_qregs(netdev2adap(dev),
 				 qid,
 				 (qtype == CXGB4_BAR2_QTYPE_EGRESS
 				  ? T4_BAR2_QTYPE_EGRESS
@@ -4011,7 +4011,7 @@ static void process_db_drop(struct work_struct *work)
 		unsigned int bar2_qid;
 		int ret;
 
-		ret = t4_bar2_sge_qregs(adap, qid, T4_BAR2_QTYPE_EGRESS,
+		ret = cxgb4_t4_bar2_sge_qregs(adap, qid, T4_BAR2_QTYPE_EGRESS,
 					&bar2_qoffset, &bar2_qid);
 		if (ret)
 			dev_err(adap->pdev_dev, "doorbell drop recovery: "
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index f12debd98dac..ebf935a1e352 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -2270,7 +2270,7 @@ static void __iomem *bar2_address(struct adapter *adapter,
 	u64 bar2_qoffset;
 	int ret;
 
-	ret = t4_bar2_sge_qregs(adapter, qid, qtype,
+	ret = cxgb4_t4_bar2_sge_qregs(adapter, qid, qtype,
 				&bar2_qoffset, pbar2_qid);
 	if (ret)
 		return NULL;
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index 67345c73e570..28d04153f999 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -4031,7 +4031,7 @@ int t4_prep_adapter(struct adapter *adapter)
 }
 
 /**
- *	t4_bar2_sge_qregs - return BAR2 SGE Queue register information
+ *	cxgb4_t4_bar2_sge_qregs - return BAR2 SGE Queue register information
  *	@adapter: the adapter
  *	@qid: the Queue ID
  *	@qtype: the Ingress or Egress type for @qid
@@ -4055,7 +4055,7 @@ int t4_prep_adapter(struct adapter *adapter)
  *	Write Combining Doorbell Buffer. If the BAR2 Queue ID is not 0,
  *	then these "Inferred Queue ID" register may not be used.
  */
-int t4_bar2_sge_qregs(struct adapter *adapter,
+int cxgb4_t4_bar2_sge_qregs(struct adapter *adapter,
 		      unsigned int qid,
 		      enum t4_bar2_qtype qtype,
 		      u64 *pbar2_qoffset,
-- 
2.1.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-11-17  2:34 Stephen Rothwell
  2014-11-22  3:30 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-11-17  2:34 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Jarno Rajahalme, Pravin B Shelar

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from include/linux/printk.h:6:0,
                 from include/linux/kernel.h:13,
                 from net/openvswitch/flow.h:23,
                 from net/openvswitch/flow_netlink.c:21:
net/openvswitch/flow_netlink.c: In function 'ovs_key_from_nlattrs':
include/linux/kern_levels.h:4:18: error: called object is not a function or function pointer
 #define KERN_SOH "\001"  /* ASCII Start Of Header */
                  ^
include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
 #define KERN_INFO KERN_SOH "6" /* informational */
                   ^
include/linux/printk.h:247:9: note: in expansion of macro 'KERN_INFO'
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
         ^
net/openvswitch/datapath.h:205:3: note: in expansion of macro 'pr_info'
   pr_info("netlink: " fmt "\n", ##__VA_ARGS__); \
   ^
net/openvswitch/flow_netlink.c:777:4: note: in expansion of macro 'OVS_NLERR'
    OVS_NLERR("IPv6 flow label %x is out of range (max=%x).\n",
    ^
net/openvswitch/datapath.h:205:27: error: expected ')' before string constant
   pr_info("netlink: " fmt "\n", ##__VA_ARGS__); \
                           ^
net/openvswitch/flow_netlink.c:19:41: note: in definition of macro 'pr_fmt'
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
                                         ^
net/openvswitch/datapath.h:205:3: note: in expansion of macro 'pr_info'
   pr_info("netlink: " fmt "\n", ##__VA_ARGS__); \
   ^
net/openvswitch/flow_netlink.c:777:4: note: in expansion of macro 'OVS_NLERR'
    OVS_NLERR("IPv6 flow label %x is out of range (max=%x).\n",
    ^

Caused by commit 05da5898a96c ("openvswitch: Add support for
OVS_FLOW_ATTR_PROBE") interacting with commit fecaef85f718
("openvswitch: Validate IPv6 flow key and mask values") from the net
tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 17 Nov 2014 13:31:33 +1100
Subject: [PATCH] openvswitch: fix up for OVS_NLERR API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/openvswitch/flow_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index 259b2f1ebd0d..45bdcf596414 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -774,7 +774,7 @@ static int ovs_key_from_nlattrs(struct sw_flow_match *match, u64 attrs,
 		}
 
 		if (ipv6_key->ipv6_label & htonl(0xFFF00000)) {
-			OVS_NLERR("IPv6 flow label %x is out of range (max=%x).\n",
+			OVS_NLERR(log, "IPv6 flow label %x is out of range (max=%x).\n",
 				  ntohl(ipv6_key->ipv6_label), (1 << 20) - 1);
 			return -EINVAL;
 		}
-- 
2.1.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-10-01  7:04 Stephen Rothwell
  2014-10-01  7:29 ` Jeff Kirsher
  2014-10-01 17:42 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2014-10-01  7:04 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Alexander Duyck, Jeff Kirsher

[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
                      ^
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c: In function 'fm10k_set_ringparam':
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:477:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
  temp_ring = vmalloc(i * sizeof(struct fm10k_ring));
  ^
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:477:12: warning: assignment makes pointer from integer without a cast
  temp_ring = vmalloc(i * sizeof(struct fm10k_ring));
            ^
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:546:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(temp_ring);
  ^

Caused by commit 82dd0f7ee9a3 ("fm10k: Add ethtool support").  See Rule
1 in Documentation/SubmitChecklist.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 1 Oct 2014 17:00:49 +1000
Subject: [PATCH] fm10k: using vmalloc requires including linux/vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
index a9bbe60347d8..2d04464e6aa3 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
@@ -18,6 +18,8 @@
  * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
  */
 
+#include <linux/vmalloc.h>
+
 #include "fm10k.h"
 
 struct fm10k_stats {
-- 
2.1.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-09-30  3:13 Stephen Rothwell
  2014-09-30  3:22 ` Stephen Rothwell
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-09-30  3:13 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Pablo Neira Ayuso

[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/bridge/br_nf_core.c:77:1: error: expected identifier or '(' before '{' token
 {
 ^
net/bridge/br_nf_core.c:88:12: error: redefinition of 'br_nf_core_init'
 int __init br_nf_core_init(void)
            ^
In file included from net/bridge/br_nf_core.c:23:0:
net/bridge/br_private.h:762:19: note: previous definition of 'br_nf_core_init' was here
 static inline int br_nf_core_init(void) { return 0; }
                   ^
net/bridge/br_nf_core.c:93:6: error: redefinition of 'br_nf_core_fini'
 void br_nf_core_fini(void)
      ^
In file included from net/bridge/br_nf_core.c:23:0:
net/bridge/br_private.h:763:20: note: previous definition of 'br_nf_core_fini' was here
 static inline void br_nf_core_fini(void) {}
                    ^

Caused by commit 34666d467cbf ("netfilter: bridge: move br_netfilter
out of the core").  This build has CONFIG_BRIDGE_NETFILTER not set ...

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 30 Sep 2014 13:09:09 +1000
Subject: [PATCH] netfilter: bridge: don't build br_nf_core unless necessary

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/bridge/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/bridge/Makefile b/net/bridge/Makefile
index 5e3eac5dc8b9..eb653a225397 100644
--- a/net/bridge/Makefile
+++ b/net/bridge/Makefile
@@ -6,12 +6,11 @@ obj-$(CONFIG_BRIDGE) += bridge.o
 
 bridge-y	:= br.o br_device.o br_fdb.o br_forward.o br_if.o br_input.o \
 			br_ioctl.o br_stp.o br_stp_bpdu.o \
-			br_stp_if.o br_stp_timer.o br_netlink.o \
-			br_nf_core.o
+			br_stp_if.o br_stp_timer.o br_netlink.o
 
 bridge-$(CONFIG_SYSFS) += br_sysfs_if.o br_sysfs_br.o
 
-obj-$(CONFIG_BRIDGE_NETFILTER) += br_netfilter.o
+obj-$(CONFIG_BRIDGE_NETFILTER) += br_netfilter.o br_nf_core.o
 
 bridge-$(CONFIG_BRIDGE_IGMP_SNOOPING) += br_multicast.o br_mdb.o
 
-- 
2.1.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* Re: linux-next: build failure after merge of the net-next tree
@ 2014-07-18  4:35 Anish Bhatt
  0 siblings, 0 replies; 394+ messages in thread
From: Anish Bhatt @ 2014-07-18  4:35 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Manoj Malviya, netdev, Karen Xie, linux-next, linux-kernel, David Miller

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 222 bytes --]

This is totally my bad. Already posted the fix some time ago.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-07-18  3:21 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2014-07-18  3:21 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Anish Bhatt, Karen Xie, Manoj Malviya

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".ipv6_dev_get_saddr" [drivers/scsi/cxgbi/libcxgbi.ko] undefined!
ERROR: ".ip6_route_output" [drivers/scsi/cxgbi/libcxgbi.ko] undefined!

Caused by commit fc8d0590d914 ("libcxgbi: Add ipv6 api to driver").
Presumably some missing Kconfig dependency (this build does not have
CONFIG_IPV6 enabled) or it needs some #ifdef guarding.

I have used the net-next tree from next-20140717 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-07-09  3:26 Stephen Rothwell
  2014-07-09  3:47 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-07-09  3:26 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Tom Herbert

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/linux/tcp.h:23:0,
                 from include/linux/ipv6.h:63,
                 from include/net/ipv6.h:16,
                 from include/linux/sunrpc/clnt.h:27,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:32:
include/net/ipv6.h: In function 'ip6_set_txhash':
include/net/sock.h:327:33: error: 'struct sock_common' has no member named 'skc_v6_daddr'
 #define sk_v6_daddr  __sk_common.skc_v6_daddr
                                 ^
include/net/ipv6.h:695:49: note: in expansion of macro 'sk_v6_daddr'
  keys.dst = (__force __be32)ipv6_addr_hash(&sk->sk_v6_daddr);
                                                 ^
In file included from include/linux/sunrpc/clnt.h:27:0,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:32:
include/net/ipv6.h: In function 'ip6_make_flowlabel':
include/net/ipv6.h:705:37: error: 'struct net' has no member named 'ipv6'
  if (!flowlabel && (autolabel || net->ipv6.sysctl.auto_flowlabels)) {
                                     ^

And lots more ...

Caused by commits b73c3d0e4f0e ("net: Save TX flow hash in sock and set
in skbuf on xmit") and cb1ce2ef387b ("ipv6: Implement automatic flow
label generation on transmit").  This build has CONFIG_IPV6 unset.

I have used the net-next tree from next-20140708 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-06-30  2:47 Stephen Rothwell
  2014-06-30  6:47 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-06-30  2:47 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Octavian Purdila

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/net/inet_connection_sock.h:23:0,
                 from include/linux/tcp.h:24,
                 from include/net/tcp.h:24,
                 from net/ipv4/tcp_input.c:72:
net/ipv4/tcp_input.c: In function 'pr_drop_req':
include/net/inet_sock.h:77:41: error: 'struct sock_common' has no member named 'skc_v6_daddr'
 #define ir_v6_rmt_addr  req.__req_common.skc_v6_daddr
                                         ^
include/net/sock.h:2273:57: note: in expansion of macro 'ir_v6_rmt_addr'
  do { if (net_msg_warn && net_ratelimit()) printk(fmt,##args); } while(0)
                                                         ^
net/ipv4/tcp_input.c:5889:3: note: in expansion of macro 'LIMIT_NETDEBUG'
   LIMIT_NETDEBUG(KERN_DEBUG pr_fmt("drop open request from %pI6/%u\n"),
   ^

Caused by commit 1fb6f159fd21 ("tcp: add tcp_conn_request").  This
build has CONFIG_IPV6 unset.

I have used the net-next tree from next-20140627 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-06-12  2:14 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2014-06-12  2:14 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Linus Lüssing

[-- Attachment #1: Type: text/plain, Size: 2989 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/bridge/br_multicast.c: In function 'br_multicast_has_querier_adjacent':
net/bridge/br_multicast.c:2248:25: error: 'struct net_bridge' has no member named 'ip6_other_query'
   if (!timer_pending(&br->ip6_other_query.timer) ||
                         ^
In file included from include/linux/idr.h:18:0,
                 from include/linux/kernfs.h:14,
                 from include/linux/sysfs.h:15,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from include/linux/dma-mapping.h:5,
                 from arch/powerpc/include/asm/machdep.h:14,
                 from arch/powerpc/include/asm/archrandom.h:6,
                 from include/linux/random.h:81,
                 from include/linux/net.h:22,
                 from include/linux/skbuff.h:27,
                 from include/linux/if_ether.h:23,
                 from net/bridge/br_multicast.c:15:
net/bridge/br_multicast.c:2249:25: error: 'struct net_bridge' has no member named 'ip6_querier'
       rcu_dereference(br->ip6_querier.port) == port)
                         ^
net/bridge/br_multicast.c:2249:25: error: 'struct net_bridge' has no member named 'ip6_querier'
       rcu_dereference(br->ip6_querier.port) == port)
                         ^
In file included from include/linux/err.h:4:0,
                 from net/bridge/br_multicast.c:13:
net/bridge/br_multicast.c:2249:25: error: 'struct net_bridge' has no member named 'ip6_querier'
       rcu_dereference(br->ip6_querier.port) == port)
                         ^
net/bridge/br_multicast.c:2249:25: error: 'struct net_bridge' has no member named 'ip6_querier'
       rcu_dereference(br->ip6_querier.port) == port)
                         ^
In file included from include/linux/idr.h:18:0,
                 from include/linux/kernfs.h:14,
                 from include/linux/sysfs.h:15,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from include/linux/dma-mapping.h:5,
                 from arch/powerpc/include/asm/machdep.h:14,
                 from arch/powerpc/include/asm/archrandom.h:6,
                 from include/linux/random.h:81,
                 from include/linux/net.h:22,
                 from include/linux/skbuff.h:27,
                 from include/linux/if_ether.h:23,
                 from net/bridge/br_multicast.c:15:
net/bridge/br_multicast.c:2249:25: error: 'struct net_bridge' has no member named 'ip6_querier'
       rcu_dereference(br->ip6_querier.port) == port)
                         ^

Caused by commit 2cd4143192e8 ("bridge: memorize and export selected
IGMP/MLD querier port").  This build has CONFIG_IPV6 not set.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-06-06  6:45 Stephen Rothwell
  2014-06-06 13:21 ` Tom Lendacky
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-06-06  6:45 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Lendacky, Thomas

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc allyesconfig)
failed like this:


drivers/net/ethernet/amd/xgbe/xgbe-dev.c:119:25: fatal error: asm/cputype.h: No such file or directory
 #include <asm/cputype.h>
                         ^

Caused by commit c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver").

I reverted commit 54a4ca8e3730 ("Merge branch 'amd-xgbe'") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-06-06  4:06 Stephen Rothwell
  2014-06-06  4:12 ` Alexei Starovoitov
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-06-06  4:06 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/core/filter.c: In function 'convert_bpf_extensions':
net/core/filter.c:696:17: error: 'A_REG' undeclared (first use in this function)
   insn->a_reg = A_REG;
                 ^

Caused by my bad merge resolution :-(

I applied this in the hope that it is correct (at least it builds):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 6 Jun 2014 14:00:07 +1000
Subject: [PATCH] net: filter: merge fix up

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/core/filter.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index 7b46e4553c17..74dd87596257 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -691,10 +691,7 @@ static bool convert_bpf_extensions(struct sock_filter *fp,
 		*insn = BPF_ALU32_IMM(BPF_AND, BPF_REG_A, PKT_TYPE_MAX);
 #ifdef __BIG_ENDIAN_BITFIELD
 		insn++;
-
-		insn->code = BPF_ALU | BPF_RSH | BPF_K;
-		insn->a_reg = A_REG;
-		insn->imm = 5;
+		*insn = BPF_ALU32_IMM(BPF_RSH, BPF_REG_A, 5);
 #endif
 		break;
 
-- 
2.0.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-06-02  8:36 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2014-06-02  8:36 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Daniel Mack

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) failed like this:

ERROR: "of_mdiobus_link_phydev" [drivers/net/phy/libphy.ko] undefined!

Caused by commit 86f6cf41272d ("net: of_mdio: add
of_mdiobus_link_phydev()") from te net-next tree.

CONFIG_PHYLIB=m for this build.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-05-19  3:38 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2014-05-19  3:38 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Bjørn Mork

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig, gcc 4.6.3) failed like this:

drivers/built-in.o: In function `cdc_ncm_get_coalesce':
ak8975.c:(.text+0x1ac994): undefined reference to `__aeabi_uldivmod'

(The file name above seems to be rubbish, the above function is in
drivers/net/usb/cdc_ncm.c)

Probably caused by commit 6c4e548ff366 ("net: cdc_ncm: use ethtool to
tune coalescing settings").  I assume that there are some 64 bit
divides in that function.

I have used the net-next tree from next-20140516 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2014-01-06  4:54 Stephen Rothwell
  2014-01-06  5:10 ` Hannes Frederic Sowa
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2014-01-06  4:54 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Li RongQing

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from net/core/dev.c:134:0:
include/linux/if_macvlan.h: In function 'macvlan_count_rx':
include/linux/if_macvlan.h:68:3: error: invalid use of undefined type 'struct vlan_pcpu_stats'
   pcpu_stats = this_cpu_ptr(vlan->pcpu_stats);
   ^

And lots more.

Caused by commit cdf3e274cf1b ("macvlan: unify macvlan_pcpu_stats and
vlan_pcpu_stats");

I have reverted that commit for today.
--- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-12-19  0:57 Stephen Rothwell
  2013-12-19 19:09 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2013-12-19  0:57 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Francesco Fusco

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

lib/hash.c:16:43: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__read_mostly'
 static struct fast_hash_ops arch_hash_ops __read_mostly = {
                                           ^
lib/hash.c: In function 'arch_fast_hash':
lib/hash.c:23:9: error: 'arch_hash_ops' undeclared (first use in this function)
  return arch_hash_ops.hash(data, len, seed);
         ^
lib/hash.c:23:9: note: each undeclared identifier is reported only once for each function it appears in
lib/hash.c: In function 'arch_fast_hash2':
lib/hash.c:29:9: error: 'arch_hash_ops' undeclared (first use in this function)
  return arch_hash_ops.hash2(data, len, seed);
         ^
lib/hash.c: In function 'hashlib_init':
lib/hash.c:35:24: error: 'arch_hash_ops' undeclared (first use in this function)
  setup_arch_fast_hash(&arch_hash_ops);
                        ^
lib/hash.c: In function 'arch_fast_hash':
lib/hash.c:24:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
lib/hash.c: In function 'arch_fast_hash2':
lib/hash.c:30:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Caused by commit 71ae8aac3e19 ("lib: introduce arch optimized hash
library").  Read Rule 1 in Documentation/SubmitChecklist :-(  Hint:
__read_mostly is defined in linux/cache.h ...

I have used the net-next tree from next-20131217 again today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-12-18  1:56 Stephen Rothwell
  2013-12-18  2:21 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2013-12-18  1:56 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Francesco Fusco, Daniel Borkmann, Thomas Graf

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/linux/hashtable.h:12:0,
                 from include/linux/elevator.h:5,
                 from include/linux/blkdev.h:222,
                 from init/do_mounts.h:2,
                 from init/do_mounts_rd.c:21:
include/linux/hash.h:18:22: fatal error: asm/hash.h: No such file or directory
 #include <asm/hash.h>
                      ^

And many more ...

Caused by commit 71ae8aac3e19 ("lib: introduce arch optimized hash
library").  Presumably this would break any architecture other than
x86 :-(

I have used the net-next tree from next-20131217 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-07-30  2:16 Stephen Rothwell
       [not found] ` <CAFkjPTny4TUFu9xrF-90DrJwXsfzBOpb_yYOwe_0r9ohsc2vcQ@mail.gmail.com>
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2013-07-30  2:16 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Eric Van Hensbergen, Andi Shyti

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/9p/trans_rdma.c:724:15: error: 'rdma_cancelled' undeclared here (not in a function)
  .cancelled = rdma_cancelled,
               ^

Caused by commit 59ea52dc461e ("net: trans_rdma: remove unused function")
interacting with commit d538a4ba906a ("net/9p: link rdma_cancelled in
with trans_module") from the v9fs tree.

I just reverted that net-next tree commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-04-26  3:48 Stephen Rothwell
  2013-04-30  8:03 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2013-04-26  3:48 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Patrick McHardy, Ajit Khaparde

[-- Attachment #1: Type: text/plain, Size: 2087 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/emulex/benet/be_main.c: In function 'be_insert_vlan_in_pkt':
drivers/net/ethernet/emulex/benet/be_main.c:786:3: error: too few arguments to function '__vlan_put_tag'
include/linux/if_vlan.h:220:31: note: declared here
drivers/net/ethernet/emulex/benet/be_main.c:796:3: error: too few arguments to function '__vlan_put_tag'
include/linux/if_vlan.h:220:31: note: declared here

Caused by comt interaction of commit 86a9bad3ab6b ("net: vlan: add
protocol argument to packet tagging functions") from the net-next tree
and commit bc0c3405abbb ("be2net: fix a Tx stall bug caused by a specific
ipv6 packet") from the net tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 26 Apr 2013 13:45:23 +1000
Subject: [PATCH] be2net: merge fix for __vlan_put_tag() API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 768a7d1..d6ab777 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -783,7 +783,7 @@ static struct sk_buff *be_insert_vlan_in_pkt(struct be_adapter *adapter,
 	}
 
 	if (vlan_tag) {
-		skb = __vlan_put_tag(skb, vlan_tag);
+		skb = __vlan_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
 		if (unlikely(!skb))
 			return skb;
 
@@ -793,7 +793,7 @@ static struct sk_buff *be_insert_vlan_in_pkt(struct be_adapter *adapter,
 	/* Insert the outer VLAN, if any */
 	if (adapter->qnq_vid) {
 		vlan_tag = adapter->qnq_vid;
-		skb = __vlan_put_tag(skb, vlan_tag);
+		skb = __vlan_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
 		if (unlikely(!skb))
 			return skb;
 		if (skip_hw_vlan)
-- 
1.8.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-04-22  3:27 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2013-04-22  3:27 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Patrick McHardy

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_proc_rwqes':
drivers/net/ethernet/ibm/ehea/ehea_main.c:728:5: error: too few arguments to function '__vlan_hwaccel_put_tag'
include/linux/if_vlan.h:237:31: note: declared here

Caused by commit 86a9bad3ab6b ("net: vlan: add protocol argument to
packet tagging functions").  Grep is your friend.  :-(

drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_setup_single_port':
drivers/net/ethernet/ibm/ehea/ehea_main.c:3027:9: error: expected expression before '|' token

Caused by commit f646968f8f7c ("net: vlan: rename NETIF_F_HW_VLAN_*
feature flags to NETIF_F_HW_VLAN_CTAG_*").

I have used the net-net tree from next-20130419 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-04-19  3:21 Stephen Rothwell
  2013-04-19  7:34 ` Antonio Quartulli
  2013-04-23  0:39 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2013-04-19  3:21 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Martin Hundebøll, Marek Lindner,
	Antonio Quartulli

[-- Attachment #1: Type: text/plain, Size: 6924 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/batman-adv/network-coding.c: In function 'batadv_nc_skb_store_sniffed_unicast':
net/batman-adv/network-coding.c:1487:2: warning: passing argument 1 of 'batadv_is_my_mac' from incompatible pointer type [enabled by default]
net/batman-adv/main.h:168:5: note: expected 'struct batadv_priv *' but argument is of type 'unsigned char *'
net/batman-adv/network-coding.c:1487:2: error: too few arguments to function 'batadv_is_my_mac'
net/batman-adv/main.h:168:5: note: declared here
net/batman-adv/network-coding.c: In function 'batadv_nc_skb_decode_packet':
net/batman-adv/network-coding.c:1540:2: warning: passing argument 1 of 'batadv_is_my_mac' from incompatible pointer type [enabled by default]
net/batman-adv/main.h:168:5: note: expected 'struct batadv_priv *' but argument is of type 'uint8_t *'
net/batman-adv/network-coding.c:1540:2: error: too few arguments to function 'batadv_is_my_mac'
net/batman-adv/main.h:168:5: note: declared here
net/batman-adv/network-coding.c: In function 'batadv_nc_find_decoding_packet':
net/batman-adv/network-coding.c:1611:2: warning: passing argument 1 of 'batadv_is_my_mac' from incompatible pointer type [enabled by default]
net/batman-adv/main.h:168:5: note: expected 'struct batadv_priv *' but argument is of type 'uint8_t *'
net/batman-adv/network-coding.c:1611:2: error: too few arguments to function 'batadv_is_my_mac'
net/batman-adv/main.h:168:5: note: declared here
net/batman-adv/network-coding.c: In function 'batadv_nc_recv_coded_packet':
net/batman-adv/network-coding.c:1678:2: warning: passing argument 1 of 'batadv_is_my_mac' from incompatible pointer type [enabled by default]
net/batman-adv/main.h:168:5: note: expected 'struct batadv_priv *' but argument is of type 'unsigned char *'
net/batman-adv/network-coding.c:1678:2: error: too few arguments to function 'batadv_is_my_mac'
net/batman-adv/main.h:168:5: note: declared here
net/batman-adv/network-coding.c:1679:6: warning: passing argument 1 of 'batadv_is_my_mac' from incompatible pointer type [enabled by default]
net/batman-adv/main.h:168:5: note: expected 'struct batadv_priv *' but argument is of type 'uint8_t *'
net/batman-adv/network-coding.c:1679:6: error: too few arguments to function 'batadv_is_my_mac'
net/batman-adv/main.h:168:5: note: declared here
net/batman-adv/network-coding.c:1683:2: warning: passing argument 1 of 'batadv_is_my_mac' from incompatible pointer type [enabled by default]
net/batman-adv/main.h:168:5: note: expected 'struct batadv_priv *' but argument is of type 'uint8_t *'
net/batman-adv/network-coding.c:1683:2: error: too few arguments to function 'batadv_is_my_mac'
net/batman-adv/main.h:168:5: note: declared here

Caused by commits 612d2b4fe0a1 ("batman-adv: network coding - save
overheard and tx packets for decoding") and 2df5278b0267 ("batman-adv:
network coding - receive coded packets and decode them") from the
net-next tree interacting with commit fe8a93b95145 ("batman-adv: make
is_my_mac() check for the current mesh only") from the net tree.

I added the following merge fix patch and can carry it as necessary:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 19 Apr 2013 13:13:25 +1000
Subject: [PATCH] batman-adv: merge fix for batadv_is_my_mac() API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/batman-adv/network-coding.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 6b9a544..382db5e 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -1484,7 +1484,7 @@ void batadv_nc_skb_store_sniffed_unicast(struct batadv_priv *bat_priv,
 {
 	struct ethhdr *ethhdr = (struct ethhdr *)skb_mac_header(skb);
 
-	if (batadv_is_my_mac(ethhdr->h_dest))
+	if (batadv_is_my_mac(bat_priv, ethhdr->h_dest))
 		return;
 
 	/* Set data pointer to MAC header to mimic packets from our tx path */
@@ -1496,6 +1496,7 @@ void batadv_nc_skb_store_sniffed_unicast(struct batadv_priv *bat_priv,
 /**
  * batadv_nc_skb_decode_packet - decode given skb using the decode data stored
  *  in nc_packet
+ * @bat_priv: the bat priv with all the soft interface information
  * @skb: unicast skb to decode
  * @nc_packet: decode data needed to decode the skb
  *
@@ -1503,7 +1504,7 @@ void batadv_nc_skb_store_sniffed_unicast(struct batadv_priv *bat_priv,
  * in case of an error.
  */
 static struct batadv_unicast_packet *
-batadv_nc_skb_decode_packet(struct sk_buff *skb,
+batadv_nc_skb_decode_packet(struct batadv_priv *bat_priv, struct sk_buff *skb,
 			    struct batadv_nc_packet *nc_packet)
 {
 	const int h_size = sizeof(struct batadv_unicast_packet);
@@ -1537,7 +1538,7 @@ batadv_nc_skb_decode_packet(struct sk_buff *skb,
 	/* Select the correct unicast header information based on the location
 	 * of our mac address in the coded_packet header
 	 */
-	if (batadv_is_my_mac(coded_packet_tmp.second_dest)) {
+	if (batadv_is_my_mac(bat_priv, coded_packet_tmp.second_dest)) {
 		/* If we are the second destination the packet was overheard,
 		 * so the Ethernet address must be copied to h_dest and
 		 * pkt_type changed from PACKET_OTHERHOST to PACKET_HOST
@@ -1608,7 +1609,7 @@ batadv_nc_find_decoding_packet(struct batadv_priv *bat_priv,
 
 	/* Select the correct packet id based on the location of our mac-addr */
 	dest = ethhdr->h_source;
-	if (!batadv_is_my_mac(coded->second_dest)) {
+	if (!batadv_is_my_mac(bat_priv, coded->second_dest)) {
 		source = coded->second_source;
 		packet_id = coded->second_crc;
 	} else {
@@ -1675,12 +1676,12 @@ static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
 	ethhdr = (struct ethhdr *)skb_mac_header(skb);
 
 	/* Verify frame is destined for us */
-	if (!batadv_is_my_mac(ethhdr->h_dest) &&
-	    !batadv_is_my_mac(coded_packet->second_dest))
+	if (!batadv_is_my_mac(bat_priv, ethhdr->h_dest) &&
+	    !batadv_is_my_mac(bat_priv, coded_packet->second_dest))
 		return NET_RX_DROP;
 
 	/* Update stat counter */
-	if (batadv_is_my_mac(coded_packet->second_dest))
+	if (batadv_is_my_mac(bat_priv, coded_packet->second_dest))
 		batadv_inc_counter(bat_priv, BATADV_CNT_NC_SNIFFED);
 
 	nc_packet = batadv_nc_find_decoding_packet(bat_priv, ethhdr,
@@ -1698,7 +1699,7 @@ static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
 		goto free_nc_packet;
 
 	/* Decode the packet */
-	unicast_packet = batadv_nc_skb_decode_packet(skb, nc_packet);
+	unicast_packet = batadv_nc_skb_decode_packet(bat_priv, skb, nc_packet);
 	if (!unicast_packet) {
 		batadv_inc_counter(bat_priv, BATADV_CNT_NC_DECODE_FAILED);
 		goto free_nc_packet;
-- 
1.8.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-02-19  1:17 Stephen Rothwell
  2013-02-19  1:30 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2013-02-19  1:17 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel,
	"YOSHIFUJI Hideaki / 吉藤英明",
	Romain KUNTZ

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/ipv6/xfrm6_policy.c: In function 'xfrm6_dst_destroy':
net/ipv6/xfrm6_policy.c:238:6: error: 'struct rt6_info' has no member named 'n'
net/ipv6/xfrm6_policy.c:239:28: error: 'struct rt6_info' has no member named 'n'

Caused by commit 887c95cc1da5 ("ipv6: Complete neighbour entry removal
from dst_entry") interacting with commit 18cf0d0784b4 ("xfrm: release
neighbor upon dst destruction") from the net tree.

I assume that the problem fixed by the net tree commit is fixed some
other way in the net-next tree, so I reverted the net tree commit.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2013-01-11  2:18 Stephen Rothwell
  0 siblings, 0 replies; 394+ messages in thread
From: Stephen Rothwell @ 2013-01-11  2:18 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Greg KH, Sony Chacko, Sritej Velaga,
	Sucheta Chakraborty, Anirban Chakraborty

[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:1721:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'qlcnic_probe'
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:1912:23: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'qlcnic_remove'

Caused by commits 7e2cf4feba05 ("qlcnic: change driver hardware interface
mechanism") and 13159183ec7a ("qlcnic: 83xx base driver") from the
net-next tree interacting with commit 54b956b90360 ("Remove __dev*
markings from init.h") from the drover-core.current tree.

I have added the following merge fix patch for today which could be added
directly to the scsi tree (please).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 11 Jan 2013 13:15:05 +1100
Subject: [PATCH] qlcnic: remove new __dev* annotations

CONFIG_HOTPLUG is always true now and the __dev* macros have been removed.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index d331313..fb7ac8e 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -1717,7 +1717,7 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter *adapter,
 	return 0;
 }
 
-static int __devinit
+static int
 qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
 	struct net_device *netdev = NULL;
@@ -1909,7 +1909,7 @@ err_out_disable_pdev:
 	return err;
 }
 
-static void __devexit qlcnic_remove(struct pci_dev *pdev)
+static void qlcnic_remove(struct pci_dev *pdev)
 {
 	struct qlcnic_adapter *adapter;
 	struct net_device *netdev;
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2012-09-28  1:43 Stephen Rothwell
  2012-09-28  2:19 ` David Miller
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2012-09-28  1:43 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Ivan Vecera

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/emulex/benet/be_main.c: In function 'be_find_vfs':
drivers/net/ethernet/emulex/benet/be_main.c:1090:28: error: 'struct pci_dev' has no member named 'physfn'

Caused by commit 51af6d7c1f31 ("be2net: fix vfs enumeration").  physfn is
only defined if CONFIG_PCI_ATS is set.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2012-07-20  2:01 Stephen Rothwell
  2012-07-20  2:48 ` Stephen Rothwell
  2012-07-20  3:21 ` Christian Riesch
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2012-07-20  2:01 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Michael Neuling, Christian Riesch

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
pmac32_defconfig) failed like this:

ERROR: "phy_disconnect" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_stop" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_ethtool_gset" [drivers/net/usb/asix.ko] undefined!
ERROR: "mdiobus_unregister" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_start_aneg" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_print_status" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_start" [drivers/net/usb/asix.ko] undefined!
ERROR: "mdiobus_free" [drivers/net/usb/asix.ko] undefined!
ERROR: "mdiobus_register" [drivers/net/usb/asix.ko] undefined!
ERROR: "genphy_resume" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_connect" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_mii_ioctl" [drivers/net/usb/asix.ko] undefined!
ERROR: "phy_ethtool_sset" [drivers/net/usb/asix.ko] undefined!
ERROR: "mdiobus_alloc_size" [drivers/net/usb/asix.ko] undefined!

Caused by commit 16626b0cc3d5 ("asix: Add a new driver for the AX88172A")
and reverting that commit fixes the build.

Thanks to Mikey for reporting this porblem.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2012-07-10  3:08 Stephen Rothwell
  2012-07-10  7:25 ` Bjørn Mork
  2012-07-11  6:36 ` David Miller
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2012-07-10  3:08 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, "Bjørn Mork"

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/usb/qmi_wwan.c:381:13: error: 'qmi_wwan_unbind_shared' undeclared here (not in a function)

Caused by a bad automatic merge between commit 6fecd35d4cd7 ("net:
qmi_wwan: add ZTE MF60") from the net tree and commit 230718bda1be ("net:
qmi_wwan: bind to both control and data interface") from the net-next
tree.

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 Jul 2012 13:06:01 +1000
Subject: [PATCH] net: fix for qmi_wwan_unbind_shared changes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/usb/qmi_wwan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 06cfcc7..85c983d 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -378,7 +378,7 @@ static const struct driver_info qmi_wwan_force_int2 = {
 	.description	= "Qualcomm WWAN/QMI device",
 	.flags		= FLAG_WWAN,
 	.bind		= qmi_wwan_bind_shared,
-	.unbind		= qmi_wwan_unbind_shared,
+	.unbind		= qmi_wwan_unbind,
 	.manage_power	= qmi_wwan_manage_power,
 	.data		= BIT(2), /* interface whitelist bitmap */
 };
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 394+ messages in thread
* linux-next: build failure after merge of the net-next tree
@ 2012-06-20  3:33 Stephen Rothwell
  2012-06-20  4:24 ` David Miller
  2012-06-20  4:27 ` Bhupesh SHARMA
  0 siblings, 2 replies; 394+ messages in thread
From: Stephen Rothwell @ 2012-06-20  3:33 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-next, linux-kernel, Federico Vaga, Giancarlo Asnaghi,
	Wolfgang Grandegger, Bhupesh Sharma, Marc Kleine-Budde

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "clk_get_rate" [drivers/net/can/c_can/c_can_pci.ko] undefined!
ERROR: "clk_get" [drivers/net/can/c_can/c_can_pci.ko] undefined!
ERROR: "clk_put" [drivers/net/can/c_can/c_can_pci.ko] undefined!

Caused by commit 5b92da0443c2 ("c_can_pci: generic module for C_CAN/D_CAN
on PCI").  Maybe a missing Kconfig dependency/select?

I have used the net-next tree from next-20120619 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread
[parent not found: <20120423121451.c88c9bfaaf4d79313f7219f3@canb.auug.org.au>]
* linux-next: build failure after merge of the net-next tree
@ 2011-10-25 13:55 Stephen Rothwell
  2011-10-25 14:16 ` Eric Dumazet
  0 siblings, 1 reply; 394+ messages in thread
From: Stephen Rothwell @ 2011-10-25 13:55 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Eric Dumazet, Linus

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
pseries_defconfig) failed like this:

drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'write_swqe2_data':
drivers/net/ethernet/ibm/ehea/ehea_main.c:1692: error: implicit declaration of function 'frag_size'

Presumably caused by commit 9e903e085262 ("net: add skb frag size
accessors").  I guess it should have been "skb_frag_size()".
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 394+ messages in thread

end of thread, other threads:[~2024-03-05  0:19 UTC | newest]

Thread overview: 394+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 10:20 linux-next: build failure after merge of the net-next tree Stephen Rothwell
2021-08-09 13:21 ` Arnd Bergmann
2021-08-15 12:04   ` Stephen Rothwell
2021-08-19 23:16     ` Stephen Rothwell
2021-09-01  6:44       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2024-03-01  1:11 Stephen Rothwell
2024-03-01  9:09 ` Eric Dumazet
2024-03-01  9:54   ` Eric Dumazet
2024-03-05  0:19     ` Stephen Rothwell
2023-12-21  2:09 Stephen Rothwell
2023-12-21  2:18 ` Christian Marangi
2024-01-04 21:15 ` Jakub Kicinski
2023-06-26  1:28 Stephen Rothwell
2023-06-26  7:48 ` David Howells
2023-06-26  8:12   ` Stephen Rothwell
2023-06-13  6:46 Stephen Rothwell
2023-06-14  9:01 ` Simon Horman
2023-06-15 22:30 ` Stephen Rothwell
2023-06-16  8:12   ` Simon Horman
2023-06-16  5:50 ` patchwork-bot+netdevbpf
2023-02-21  1:40 Stephen Rothwell
2023-01-23 23:02 Stephen Rothwell
2023-01-24  9:57 ` Matthieu Baerts
2023-01-24 17:00 ` patchwork-bot+netdevbpf
2022-11-27 23:15 Stephen Rothwell
2022-11-16  6:33 Stephen Rothwell
2022-11-16  8:47 ` Jamie Bainbridge
2022-07-07  1:00 Stephen Rothwell
2022-06-19 23:34 Stephen Rothwell
2022-06-19 23:48 ` Kuniyuki Iwashima
2022-05-20  4:59 Stephen Rothwell
2022-05-20  5:20 ` Jakub Kicinski
2022-05-20  7:39   ` Pablo Neira Ayuso
2022-05-20 13:49     ` Felix Fietkau
2022-05-20 13:52       ` Pablo Neira Ayuso
2022-05-10  3:05 Stephen Rothwell
2022-03-21  7:39 Stephen Rothwell
2022-03-21 21:45 ` Jakub Kicinski
2022-03-22  6:18   ` Saeed Mahameed
2022-03-15 11:44 Stephen Rothwell
2022-03-15 13:14 ` Vladimir Oltean
2022-03-07 10:45 Stephen Rothwell
2022-03-07 17:18 ` Dimitris Michailidis
2022-03-07 10:36 Stephen Rothwell
2022-03-07 20:53 ` Maciej Fijalkowski
2022-03-02  0:56 Stephen Rothwell
2022-03-02  1:15 ` Jakub Kicinski
2022-02-09 23:59 Stephen Rothwell
2021-10-28  1:56 Stephen Rothwell
2021-10-28  7:45 ` Saeed Mahameed
2021-10-22  0:24 Stephen Rothwell
2021-10-22 16:10 ` patchwork-bot+netdevbpf
2021-10-11  6:34 Stephen Rothwell
2021-10-08  5:21 Stephen Rothwell
2021-10-08  5:52 ` Kalle Valo
2021-10-08  8:14   ` Geert Uytterhoeven
2021-10-08 14:43     ` Kalle Valo
2021-10-08 15:14       ` David Miller
2021-10-06  1:23 Stephen Rothwell
2021-10-06  1:52 ` Jakub Kicinski
2021-10-06  3:43   ` Stephen Rothwell
2021-10-06 12:49     ` Jakub Kicinski
2021-10-05  0:56 Stephen Rothwell
2021-10-05  1:24 ` Stephen Rothwell
2021-10-05  1:35   ` Stephen Rothwell
2021-10-01  6:18 Stephen Rothwell
2021-10-01 13:40 ` David Miller
2021-10-01 14:01   ` David Miller
2021-10-05  1:11   ` Stephen Rothwell
2021-10-05  4:40     ` Wei Wang
2021-10-05 10:35     ` David Miller
2021-09-14  2:15 Stephen Rothwell
2021-09-16  9:03 ` Masahiro Yamada
2021-09-16 12:11   ` Stephen Rothwell
2021-09-01  6:38 Stephen Rothwell
2021-09-01  6:54 ` Stephen Rothwell
2021-08-27  2:22 Stephen Rothwell
2021-08-23  2:09 Stephen Rothwell
2021-08-23  6:34 ` Heiner Kallweit
2021-08-23 10:20   ` David Miller
2021-08-05 12:01 Mark Brown
2021-08-05 12:12 ` David Miller
2021-08-05 12:34 ` Loic Poulain
2021-07-21  1:26 Stephen Rothwell
2021-07-21 10:30 ` Vladimir Oltean
2021-06-23 22:29 Stephen Rothwell
2021-06-23 22:46 ` Marcin Wojtas
2021-06-24  2:22   ` Ismail, Mohammad Athari
2021-06-24  2:29   ` Nathan Chancellor
2021-06-24  6:13     ` Naresh Kamboju
2021-06-24  7:05       ` Marcin Wojtas
2021-06-24  8:54       ` Stephen Rothwell
2021-06-24 14:25         ` Marcin Wojtas
2021-06-24 16:40           ` Nathan Chancellor
2021-06-24 18:15             ` Marcin Wojtas
2021-06-24 19:14               ` Jakub Kicinski
2021-06-24 20:18                 ` Marcin Wojtas
2021-06-24 22:41           ` Stephen Rothwell
2021-06-25 21:08             ` Marcin Wojtas
2021-05-14  3:40 Stephen Rothwell
2021-05-11 23:52 Stephen Rothwell
2021-05-11 23:54 ` Stephen Rothwell
2021-05-13  1:11   ` Stephen Rothwell
2021-05-13  6:35     ` Loic Poulain
2021-05-13 22:51       ` Stephen Rothwell
2021-04-12  5:04 Stephen Rothwell
2021-04-12  9:02 ` Florian Westphal
2021-04-12 13:25 ` Pablo Neira Ayuso
2021-02-04  1:33 Stephen Rothwell
2021-02-04  3:52 ` Brian Vazquez
2021-02-04  9:38   ` Stephen Rothwell
2021-02-04 12:19     ` Joachim Wiberg
2021-02-04 15:36   ` Vladimir Oltean
2021-02-04 17:34     ` Brian Vazquez
2020-12-14  2:14 Stephen Rothwell
2020-12-16  1:03 ` Stephen Rothwell
2020-12-02  1:38 Stephen Rothwell
2020-10-06  3:58 Stephen Rothwell
2020-10-06  5:13 ` Christoph Hellwig
2020-10-06  5:41   ` Stephen Rothwell
2020-10-06  8:53     ` Daniel Borkmann
2020-09-29  3:04 Stephen Rothwell
2020-09-30 22:09 ` Stephen Rothwell
2020-09-30 23:06   ` Vadym Kochan
2020-09-30 23:19     ` Stephen Rothwell
2020-10-02  1:40 ` David Miller
2020-10-02  2:00   ` Stephen Rothwell
2020-08-05 12:31 Stephen Rothwell
2020-08-05 13:06 ` Stefano Brivio
2020-08-05 13:21   ` Heiko Carstens
2020-08-05 13:23     ` Stefano Brivio
2020-07-29 11:27 Stephen Rothwell
2020-07-29 18:13 ` Brian Vazquez
2020-08-17  7:20 ` Sven Joachim
     [not found]   ` <CAMzD94Rz4NYnhheS8SmuL14MNM4VGxOnAW-WZ9k1JEqrbwyrvw@mail.gmail.com>
2020-08-22  6:16     ` Sven Joachim
2020-08-24  8:08       ` Sven Joachim
2020-08-27 18:12         ` Brian Vazquez
2020-08-28 15:09           ` Sven Joachim
2020-08-28 15:12             ` Randy Dunlap
2020-08-28 23:16               ` Brian Vazquez
2020-08-28 23:42                 ` Randy Dunlap
2020-08-29  6:50                   ` Sven Joachim
2020-07-13  1:54 Stephen Rothwell
2020-07-13  7:29 ` Nikolay Aleksandrov
2020-01-16  7:53 Stephen Rothwell
2020-01-20  9:03 ` David Miller
2020-01-09 23:57 Stephen Rothwell
2020-01-10  2:30 ` David Miller
2019-12-18 22:32 Stephen Rothwell
2019-12-18 22:38 ` Jose Abreu
2019-12-18 22:58   ` Jose Abreu
2019-11-05  8:53 Stephen Rothwell
2019-11-05 13:50 ` Andrew Lunn
2019-11-05 14:22   ` Stephen Rothwell
2019-09-04  6:00 Stephen Rothwell
2019-09-04  6:18 ` Masahiro Yamada
2019-09-05 19:26   ` Andrii Nakryiko
2019-09-06  2:52     ` Masahiro Yamada
2019-09-06  9:02       ` Andrii Nakryiko
2019-09-04  8:18 ` Andrii Nakryiko
2019-08-29 10:05 Stephen Rothwell
2019-08-30 21:35 ` David Miller
2019-07-25  9:37 Stephen Rothwell
2019-07-11 11:52 Jason Gunthorpe
2019-07-09  3:56 Stephen Rothwell
2019-07-09  6:43 ` Leon Romanovsky
2019-07-10  4:31   ` Stephen Rothwell
2019-07-10  5:20     ` Leon Romanovsky
2019-07-10 17:52   ` Jason Gunthorpe
2019-07-11  1:50     ` Stephen Rothwell
2019-07-11  2:26       ` Jason Gunthorpe
2019-07-11  3:13         ` Stephen Rothwell
2019-07-11  3:16           ` Stephen Rothwell
2019-07-11  3:27             ` Stephen Rothwell
2019-07-11  5:40             ` Leon Romanovsky
2019-07-11  8:00   ` Bernard Metzler
2019-07-11 12:29     ` Bernard Metzler
2019-07-11 14:33       ` Jason Gunthorpe
2019-07-12  1:45         ` Stephen Rothwell
2019-07-12 15:21           ` Jason Gunthorpe
2019-06-20  9:13 Stephen Rothwell
2019-06-24  3:12 ` Stephen Rothwell
2019-06-24  3:59   ` Palmer Dabbelt
2019-06-19  3:23 Stephen Rothwell
2019-06-19  4:02 ` Masahiro Yamada
2019-06-19  4:14   ` Masahiro Yamada
2019-06-19  8:50     ` Kevin 'ldir' Darbyshire-Bryant
2019-06-19 13:46     ` David Miller
2019-06-19 14:13 ` David Miller
2019-06-19 15:09   ` Kevin 'ldir' Darbyshire-Bryant
2019-06-19 16:11     ` Kevin 'ldir' Darbyshire-Bryant
2019-06-11  8:26 Stephen Rothwell
2019-05-31  0:35 Stephen Rothwell
2019-04-23  7:25 Stephen Rothwell
2019-04-24  1:36 ` David Miller
2019-02-04  4:34 Stephen Rothwell
2019-02-04  4:36 ` David Miller
2019-01-29  5:17 Stephen Rothwell
2019-01-29  6:43 ` David Miller
2018-12-20  2:28 Stephen Rothwell
2018-12-17  1:36 Stephen Rothwell
2018-12-17 15:54 ` Paolo Abeni
2018-10-19  0:18 Stephen Rothwell
2018-10-19  5:48 ` Or Gerlitz
2018-09-02 23:47 Stephen Rothwell
2018-09-07  0:20 ` Stephen Rothwell
2018-09-07 15:30   ` Keller, Jacob E
2018-09-07 17:31     ` David Miller
2018-09-07 22:03       ` Keller, Jacob E
2018-08-06  2:10 Stephen Rothwell
2018-08-06  4:43 ` Y.b. Lu
2018-08-03  2:14 Stephen Rothwell
2018-08-03  2:34 ` Jakub Kicinski
2018-08-03  2:44 ` David Miller
2018-07-27 10:32 Stephen Rothwell
2018-07-27 12:18 ` YueHaibing
2018-07-03  0:47 Stephen Rothwell
2018-07-03  7:34 ` Sabrina Dubroca
2018-05-29  3:42 Stephen Rothwell
2018-05-29  5:41 ` Christoph Hellwig
2018-05-29  3:25 Stephen Rothwell
2018-05-30 21:38 ` Stephen Rothwell
2018-06-01  3:59   ` Stephen Rothwell
2018-06-01  8:52     ` Alexei Starovoitov
2018-06-06  4:49       ` Stephen Rothwell
2018-02-28 23:30 Stephen Rothwell
2018-01-29  1:50 Stephen Rothwell
2018-01-29  2:09 ` David Miller
2018-01-11  0:53 Stephen Rothwell
2018-01-11  1:58 ` Alexei Starovoitov
2018-01-12  3:11   ` David Miller
2018-01-12  4:21     ` Alexei Starovoitov
2018-01-12 10:45       ` Daniel Borkmann
2018-01-12 15:56         ` Alexei Starovoitov
2018-01-12 16:21           ` Daniel Borkmann
2018-01-12 16:43             ` Alexei Starovoitov
2018-01-10  4:06 Stephen Rothwell
2018-01-10  5:53 ` Jason Wang
2018-01-10 20:53 ` David Miller
2017-12-22  0:45 Stephen Rothwell
2017-12-22  7:51 ` Ido Schimmel
2017-12-20 23:43 Stephen Rothwell
2017-12-20 23:59 ` Jakub Kicinski
2017-09-29  1:36 Stephen Rothwell
2017-09-29  2:07 ` Florian Fainelli
2017-09-22  1:03 Stephen Rothwell
2017-09-22  1:37 ` David Miller
2017-09-22  7:10   ` Paolo Abeni
2017-08-15  2:28 Stephen Rothwell
2017-07-18  1:09 Stephen Rothwell
2017-07-18  4:59 ` John Fastabend
2017-05-22  1:16 Stephen Rothwell
2017-05-22  3:14 ` David Miller
2017-05-22  3:43   ` Stephen Rothwell
2017-05-22 14:17     ` David Miller
2017-05-22  3:42 ` Willem de Bruijn
2017-01-09 23:59 Stephen Rothwell
2017-01-10 15:14 ` Ursula Braun
2017-02-22 23:34 ` Stephen Rothwell
2016-05-10  1:29 Stephen Rothwell
2016-05-10  1:32 ` David Miller
2016-05-10  1:29 Stephen Rothwell
2016-05-10  1:52 ` Andy Gross
2016-05-10 18:39 ` Bjorn Andersson
2016-05-13 21:01   ` Arnd Bergmann
2016-04-13  7:50 Stephen Rothwell
2016-04-13 15:15 ` David Miller
2016-04-17  9:47   ` Arnd Bergmann
2016-04-22  9:20   ` Mark Brown
2016-04-22 23:20     ` Jeff Kirsher
2016-04-24 22:59       ` Mark Brown
2016-02-18  1:28 Stephen Rothwell
2016-02-18 20:28 ` David Miller
2016-02-18 22:14   ` Yuval Mintz
2016-01-11  2:46 Stephen Rothwell
2016-01-11  3:02 ` David Miller
2015-10-06  5:34 Stephen Rothwell
2015-08-24  3:21 Stephen Rothwell
2015-08-24  3:33 ` David Miller
2015-08-24  4:20   ` Stephen Rothwell
2015-08-20  2:57 Stephen Rothwell
2015-08-20  5:16 ` David Miller
2015-08-18  8:39 Stephen Rothwell
2015-08-18 21:25 ` David Miller
2015-07-23  1:58 Stephen Rothwell
2015-06-24  7:37 Stephen Rothwell
2015-06-24  8:01 ` David Miller
2015-06-01  3:44 Stephen Rothwell
2015-06-01  4:35 ` David Miller
2015-03-30  4:05 Stephen Rothwell
2015-03-31 18:13 ` David Miller
2015-03-24  2:45 Stephen Rothwell
2015-03-24  3:00 ` David Miller
2015-03-24 10:43   ` Christoph Hellwig
2015-03-24 15:59     ` David Miller
2015-03-05  2:42 Stephen Rothwell
2015-03-05  5:01 ` David Miller
2015-03-05 23:26   ` Stephen Rothwell
2015-03-06  2:01     ` David Miller
2015-03-06  2:42       ` Stephen Rothwell
2015-02-10 11:02 Stephen Rothwell
2015-02-11  4:51 ` Jeff Kirsher
2015-02-09  3:07 Stephen Rothwell
2015-02-09  5:52 ` David Miller
2015-01-19  3:06 Stephen Rothwell
2015-01-19  3:13 ` Marcel Holtmann
2015-01-19  3:30   ` Stephen Rothwell
2015-01-12  3:05 Stephen Rothwell
2015-01-12  3:08 ` David Miller
2015-01-12  3:12   ` Stephen Rothwell
2015-01-02 22:11 Stephen Rothwell
2015-01-02 22:21 ` Sedat Dilek
2015-01-02 23:32   ` Stephen Rothwell
2015-01-03  3:01 ` Stephen Rothwell
2015-01-03 19:45 ` David Miller
2015-01-05  3:36   ` Stephen Rothwell
2014-12-10  8:54 Stephen Rothwell
2014-12-10 10:14 ` Hariprasad S
2014-12-10 20:52 ` David Miller
2014-11-17  2:34 Stephen Rothwell
2014-11-22  3:30 ` David Miller
2014-10-01  7:04 Stephen Rothwell
2014-10-01  7:29 ` Jeff Kirsher
2014-10-01 17:42 ` David Miller
2014-09-30  3:13 Stephen Rothwell
2014-09-30  3:22 ` Stephen Rothwell
2014-07-18  4:35 Anish Bhatt
2014-07-18  3:21 Stephen Rothwell
2014-07-09  3:26 Stephen Rothwell
2014-07-09  3:47 ` David Miller
2014-07-09  3:53   ` Stephen Rothwell
2014-06-30  2:47 Stephen Rothwell
2014-06-30  6:47 ` David Miller
2014-06-12  2:14 Stephen Rothwell
2014-06-06  6:45 Stephen Rothwell
2014-06-06 13:21 ` Tom Lendacky
2014-06-06  4:06 Stephen Rothwell
2014-06-06  4:12 ` Alexei Starovoitov
2014-06-02  8:36 Stephen Rothwell
2014-05-19  3:38 Stephen Rothwell
2014-01-06  4:54 Stephen Rothwell
2014-01-06  5:10 ` Hannes Frederic Sowa
2013-12-19  0:57 Stephen Rothwell
2013-12-19 19:09 ` David Miller
2013-12-18  1:56 Stephen Rothwell
2013-12-18  2:21 ` David Miller
2013-12-18  2:30   ` David Miller
2013-12-18  8:33     ` Geert Uytterhoeven
2013-12-18 10:15       ` Peter Zijlstra
2013-12-18 10:32         ` Geert Uytterhoeven
2013-12-18 11:07           ` David Laight
2013-12-18 11:33             ` Peter Zijlstra
2013-12-18 11:36               ` Peter Zijlstra
2013-12-18 17:06         ` David Miller
2013-12-18 15:10     ` Francesco Fusco
2013-07-30  2:16 Stephen Rothwell
     [not found] ` <CAFkjPTny4TUFu9xrF-90DrJwXsfzBOpb_yYOwe_0r9ohsc2vcQ@mail.gmail.com>
2013-07-30 22:54   ` David Miller
2013-04-26  3:48 Stephen Rothwell
2013-04-30  8:03 ` David Miller
2013-04-22  3:27 Stephen Rothwell
2013-04-19  3:21 Stephen Rothwell
2013-04-19  7:34 ` Antonio Quartulli
2013-04-19  8:13   ` Stephen Rothwell
2013-04-23  0:39 ` David Miller
2013-02-19  1:17 Stephen Rothwell
2013-02-19  1:30 ` David Miller
2013-01-11  2:18 Stephen Rothwell
2012-09-28  1:43 Stephen Rothwell
2012-09-28  2:19 ` David Miller
2012-10-01 11:53   ` Ivan Vecera
2012-07-20  2:01 Stephen Rothwell
2012-07-20  2:48 ` Stephen Rothwell
2012-07-20  3:21 ` Christian Riesch
2012-07-10  3:08 Stephen Rothwell
2012-07-10  7:25 ` Bjørn Mork
2012-07-11  6:36 ` David Miller
2012-06-20  3:33 Stephen Rothwell
2012-06-20  4:24 ` David Miller
2012-06-20  4:27 ` Bhupesh SHARMA
2012-06-20  4:37   ` David Miller
2012-06-20  4:45     ` Bhupesh SHARMA
2012-06-20  4:47       ` David Miller
2012-06-20 11:35         ` Mark Brown
2012-06-20  8:31       ` Marc Kleine-Budde
2012-06-20  8:41         ` David Miller
2012-06-20  9:03         ` Federico Vaga
2012-06-20  9:06           ` David Miller
2012-06-20  9:59             ` Federico Vaga
2012-06-20  9:58               ` David Miller
2012-06-20 10:17                 ` Federico Vaga
2012-06-20  8:08   ` viresh kumar
2012-06-20  8:20     ` David Miller
2012-06-20  8:45       ` viresh kumar
2012-06-20 10:26       ` Stephen Rothwell
2012-06-20 10:33         ` Marc Kleine-Budde
     [not found] <20120423121451.c88c9bfaaf4d79313f7219f3@canb.auug.org.au>
2012-04-23  4:25 ` David Miller
2011-10-25 13:55 Stephen Rothwell
2011-10-25 14:16 ` Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).