From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73DADC4338F for ; Tue, 10 Aug 2021 07:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4230D60F38 for ; Tue, 10 Aug 2021 07:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233888AbhHJHfk (ORCPT ); Tue, 10 Aug 2021 03:35:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233697AbhHJHfi (ORCPT ); Tue, 10 Aug 2021 03:35:38 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53151C0613D3 for ; Tue, 10 Aug 2021 00:35:17 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id mq2-20020a17090b3802b0290178911d298bso4052738pjb.1 for ; Tue, 10 Aug 2021 00:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7EzgN9g1XtwnyFgpdk0FQ59crTERL3asDSmTaguV9xw=; b=AuOgsblc4N+hr+jtlgYsCxhbLE8O+YSNlnuJH9zDj9JMZc+kCmcwFRTv+5/YNfgvn4 +5kWdadLfVcSyV9nk99Q/4jdRKRY1W82ZPXDnYkr1oPJaxgjZf1VkVPKX9nmDLal5UXl Er6+ASCwLQwR8GqfcCyBbs1KpKrPfmGtqdtO8DEUZF5LrqxJ0kAgyNSUIiD+tpL4XeZ1 Hx0cFNAI0y5mhD5XjHiJLiVktD6IJ/wTjTOtxivYNqN4gk9xFGuvecZnUhiN4Ihq2k9u msU5qKLy0QZGJwI07XEMoLHXzRraVZZKXO3Md+Dj442FU+8NSo0/cUSyyYpnM6n2pXc3 acAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7EzgN9g1XtwnyFgpdk0FQ59crTERL3asDSmTaguV9xw=; b=gA0jkNw2d2Z/90sQAPO2yaMsUJlRV71KziglCCvHx4zB4D7eknY4cSwOP7m4bciM/o CwwVp89hUhy5IDTARcJ09yhLwlnOQxzmJUt5DNYspV0XlZuWYC3J4r9iuaONmE6WAgZ1 8V/wDTZLnkeG/KO0fNPV6EXTzJzSuIOXNZPNr6TwRqjcx+gwZ8Kd5aF57+HBT8AF2gQF Vg0XJbuvKVdlzXD9CgoxvAMM+NRAbwfb7AB/H11jSEHTBLgVD6I9hhbDd0NnCPlO+wdd dUkwqE3oXuLaThKXGoAnFogOxTbCHyE6hy4qbOOt5UTknJvnTIBfPRQb150sf9Lwv2M0 Y/Qg== X-Gm-Message-State: AOAM533NsPmfQxKtae2VevZK6oH07X/+dGIAlc4KITaYM9zIWZDE3YCG 8TUDMd1+CsJ1Am8wByoGrMXg6Q== X-Google-Smtp-Source: ABdhPJyTE+WX5eApTwQ/BWrztdRfSU9QZ8XJbeCuJSJ38AXbx5SetupsHR5upHroaSJcA82ydwu+0g== X-Received: by 2002:a62:6307:0:b029:3ca:f9cc:b1b8 with SMTP id x7-20020a6263070000b02903caf9ccb1b8mr11838858pfb.39.1628580916410; Tue, 10 Aug 2021 00:35:16 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id lk17sm1854172pjb.37.2021.08.10.00.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 00:35:15 -0700 (PDT) Date: Tue, 10 Aug 2021 13:05:12 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: "Michael S. Tsirkin" , Viresh Kumar , Linus Walleij , Cornelia Huck , Linux Kernel Mailing List , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Bartosz Golaszewski , Geert Uytterhoeven , "open list:GPIO SUBSYSTEM" , Marc Zyngier , Thomas Gleixner , "Enrico Weigelt, metux IT consult" , Jason Wang , Stratos Mailing List Subject: Re: [Stratos-dev] [PATCH V4 2/2] gpio: virtio: Add IRQ support Message-ID: <20210810073512.5n5vsjvvurgdemk6@vireshk-i7> References: <0100017b1610f711-c53c79f2-9e28-4c45-bb42-8db09688b18e-000000@email.amazonses.com> <20210805124922.j7lts7tfmm4t2kpf@vireshk-i7> <0100017b1a6c0a05-e41dc16c-b326-4017-a63d-a24a6c1fde70-000000@email.amazonses.com> <20210809073020.y6ruibdm37xnx7hg@vireshk-i7> <0100017b2a85eaf8-08b905fc-89f7-43a4-857e-070ca9691ce1-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09-08-21, 13:19, Arnd Bergmann wrote: > I don't see anything wrong with this version, Great. > but let's see what > Marc thinks. I expect that he can still poke some holes in it, or > at least find some simplifications. Right, though I may resend the patches properly first to make it less confusing. > I was slightly surprised at the relation between the disabled and > masked states, where 'disable' always implies 'mask' and > 'enable' always implies 'unmask', but I don't actually know how > those two are actually defined in the irqchip code in Linux, so > I assume you did this correctly. I did have a look at the irq-core, but didn't go in real depth. I rather saw how stuff happens at the driver's end. - On setup-irq, the core only calls enable() and not unmask(). - On interrupt, the core calls mask(), followed by unmask() (which can be delayed for threaded irqs). - On disable_irq(), the core only calls disable(). - On enable_irq(), the core only calls enable(). And so I ended up at this version :) -- viresh