From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA76C04FE3 for ; Tue, 10 Aug 2021 14:19:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97DB961008 for ; Tue, 10 Aug 2021 14:19:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243446AbhHJOTv (ORCPT ); Tue, 10 Aug 2021 10:19:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:52806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240782AbhHJOQy (ORCPT ); Tue, 10 Aug 2021 10:16:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B5C2E6109F; Tue, 10 Aug 2021 14:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628604975; bh=9usGj9LMxMGrtwCjIZPjldvX11yA78hDphKW+uN0NgQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LGKzF22ZBvTLjEN8OK9LwyhPpe7QNixAq/uIFo2hRnEUo+aAK2H9iIOs/mR0fk7yT DMntC0a6Bk2X75krgsMsq3xvuSdi7iDlWi6/E8HnL33nvFuZWABS3giEsRZxWFeK7V I0CMWUa5CsVelAdBqHsJQdALgM6t++gq9E5MG7D4U2c3VDxtBSTzFNWSjAFF9mQMmb LLtj5XJz91rJPYXclbhLAysvPiXt8omrOgNojRDZzLZgu5TWgY9GfOngkalqrWhkuw IErlh8isqkUx9WPpKFgbQRgUo1TGjiaPwnhWYV3v1FnPQdahKzzInV8wRHw6YdVJFh SJqczloS6iBtw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sreekanth Reddy , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 07/13] scsi: core: Avoid printing an error if target_alloc() returns -ENXIO Date: Tue, 10 Aug 2021 10:15:59 -0400 Message-Id: <20210810141606.3117932-7-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210810141606.3117932-1-sashal@kernel.org> References: <20210810141606.3117932-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sreekanth Reddy [ Upstream commit 70edd2e6f652f67d854981fd67f9ad0f1deaea92 ] Avoid printing a 'target allocation failed' error if the driver target_alloc() callback function returns -ENXIO. This return value indicates that the corresponding H:C:T:L entry is empty. Removing this error reduces the scan time if the user issues SCAN_WILD_CARD scan operation through sysfs parameter on a host with a lot of empty H:C:T:L entries. Avoiding the printk on -ENXIO matches the behavior of the other callback functions during scanning. Link: https://lore.kernel.org/r/20210726115402.1936-1-sreekanth.reddy@broadcom.com Signed-off-by: Sreekanth Reddy Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_scan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 79232cef1af1..3fd109fd9335 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -454,7 +454,8 @@ static struct scsi_target *scsi_alloc_target(struct device *parent, error = shost->hostt->target_alloc(starget); if(error) { - dev_printk(KERN_ERR, dev, "target allocation failed, error %d\n", error); + if (error != -ENXIO) + dev_err(dev, "target allocation failed, error %d\n", error); /* don't want scsi_target_reap to do the final * put because it will be under the host lock */ scsi_target_destroy(starget); -- 2.30.2