From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-s390@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v2 0/3] A few gup refactorings and documentation updates
Date: Wed, 11 Aug 2021 00:05:39 -0700 [thread overview]
Message-ID: <20210811070542.3403116-1-jhubbard@nvidia.com> (raw)
OK, here is v2 with changes as recommended by Christoph Hellwig and
Matthew Wilcox (thanks!):
* Changed refs to @refs, and added some more documentation as well.
* Completely removed try_get_page(). (I'm adding more people and lists
to Cc, because of those call site changes.)
* Reversed the logic in try_grab_page() to make it a touch more
readable.
Also, this has been rebased to today's linux-next (next-20210810), and
re-tested on that.
Here is the v1 cover letter, edited slightly to keep up with the latest
story.
While reviewing some of the other things going on around gup.c, I
noticed that the documentation was wrong for a few of the routines that
I wrote. And then I noticed that there was some significant code
duplication too. So this fixes those issues.
This is not entirely risk-free, but after looking closely at this, I
think it's actually a useful improvement, getting rid of the code
duplication here.
However, it is possible I've overlooked something. I did some local LTP
and other testing on an x86 test machine but failed to find any problems
yet.
And the original v1 is here:
https://lore.kernel.org/r/20210808235018.1924918-1-jhubbard@nvidia.com
John Hubbard (3):
mm/gup: documentation corrections for gup/pup
mm/gup: small refactoring: simplify try_grab_page()
mm/gup: Remove try_get_page(), call try_get_compound_head() directly
arch/s390/mm/fault.c | 2 +-
fs/pipe.c | 2 +-
include/linux/mm.h | 10 +-----
mm/gup.c | 79 ++++++++++++++++++++++----------------------
4 files changed, 43 insertions(+), 50 deletions(-)
--
2.32.0
next reply other threads:[~2021-08-11 7:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 7:05 John Hubbard [this message]
2021-08-11 7:05 ` [PATCH v2 1/3] mm/gup: documentation corrections for gup/pup John Hubbard
2021-08-11 7:05 ` [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() John Hubbard
2021-08-12 9:20 ` Christoph Hellwig
2021-08-12 21:59 ` John Hubbard
2021-08-11 7:05 ` [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly John Hubbard
2021-08-11 20:35 ` William Kucharski
2021-08-11 22:07 ` John Hubbard
2021-08-12 2:17 ` William Kucharski
2021-08-12 9:22 ` Christoph Hellwig
2021-08-12 18:19 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811070542.3403116-1-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).