From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF01C432BE for ; Thu, 12 Aug 2021 04:22:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D067560231 for ; Thu, 12 Aug 2021 04:22:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233791AbhHLEWd (ORCPT ); Thu, 12 Aug 2021 00:22:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhHLEWb (ORCPT ); Thu, 12 Aug 2021 00:22:31 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6889BC0613D3 for ; Wed, 11 Aug 2021 21:22:07 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id a20so5631325plm.0 for ; Wed, 11 Aug 2021 21:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V2OoNgUgDhLYLo0G/A9MxruZCr+/VPFKnTGlfuhSRBg=; b=Cp0YBwB3VoJ6c1xlgx8o0IXEBN7VUK7qeorVOgi6mSqV0k8cW0qYQ4PtF/hz4+mCeH jfZnSgVzPWfbQQrVeIpbNEhi/mXhg+yTZAHgxHxdLws72JTAIEno2pU3Z22pk1Z3df0W RUGEGrmMrxGeWGSG+fti9x2zWGFw+9eQwXxrm6BE2RkRnfE/f6Qwye48KJLKQ7wDb7vC elcsOVs+mocn2d8dePThq1JD7OrEMittYEmcqOB8jnB0kNlPUXuFNxJvarKHwZYOmkQX s0KaCTJ5VTGyx8QJix6/0NhOGitJntW9+Wqh8rk4mdrEcZdx9aUPrZNSKNviBkSItFJE Aegg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V2OoNgUgDhLYLo0G/A9MxruZCr+/VPFKnTGlfuhSRBg=; b=GIXrBGmXgt9VGYVip8gRojmuIfn/MtiiMSq/2j+Ez/S3bfExmQoO0n9Q1r+P/UbQmD Z6k7vWruKwS92zPpvgZ9Vacj7X46V6hG//M/qjeAPSEdob7/SJ7jnUOKZRcIwzdAqqqw rJbWUO7qFZcXJdK0EbF+1qE0Xk1Zu7wztJoy26VEGQWoivAoLIXwukJjMDayqqCGk+An 1jWlwKxDPjrFL4LwyjRQWOzeKXnE05GH/8sqaAM8Ml+B7Zid608PVetYDlCu+T7U5yK4 JMm4fOA91/T0hVOT+6TzkdHWZBXXW7XQkeEk6+kfUhUgqLVb1q2uV1cWkxizfbwgvZjI YfHA== X-Gm-Message-State: AOAM533b05o3QLrSiimZG5DMlHS3j4iHGw4+bJLuX7mqT4JLI4VY+48C o9FPnCQzmuJDNm6+C24K0aSRYA== X-Google-Smtp-Source: ABdhPJySH0sOcWbvWBwKwwS9V1PFVMc96Xd12LGXhQOasIzv3HTUQxkmrRpQYi6FkNoPzJJILXNdLw== X-Received: by 2002:a63:7883:: with SMTP id t125mr2028840pgc.243.1628742127011; Wed, 11 Aug 2021 21:22:07 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id gz23sm1146608pjb.0.2021.08.11.21.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 21:22:06 -0700 (PDT) Date: Thu, 12 Aug 2021 09:52:04 +0530 From: Viresh Kumar To: Lukasz Luba Cc: Rafael Wysocki , Sudeep Holla , Cristian Marussi , linux-pm@vger.kernel.org, Vincent Guittot , Quentin Perret , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 9/9] cpufreq: scmi: Use .register_em() callback Message-ID: <20210812042204.lxugyjxa2cyz45ib@vireshk-i7> References: <6094d891b4cb0cba3357e2894c8a4431c4c65e67.1628682874.git.viresh.kumar@linaro.org> <143a03df-d858-b2de-a2cc-983c35d71e53@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <143a03df-d858-b2de-a2cc-983c35d71e53@arm.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-08-21, 17:32, Lukasz Luba wrote: > > > On 8/11/21 12:58 PM, Viresh Kumar wrote: > > Set the newly added .register_em() callback to register with the EM > > after the cpufreq policy is properly initialized. > > > > Signed-off-by: Viresh Kumar > > --- > > drivers/cpufreq/scmi-cpufreq.c | 55 ++++++++++++++++++++-------------- > > 1 file changed, 32 insertions(+), 23 deletions(-) > > > +static void scmi_cpufreq_register_em(struct cpufreq_policy *policy) > > +{ > > + struct em_data_callback em_cb = EM_DATA_CB(scmi_get_cpu_power); > > + bool power_scale_mw = perf_ops->power_scale_mw_get(ph); > > + struct scmi_data *priv = policy->driver_data; > > + > > + em_dev_register_perf_domain(get_cpu_device(policy->cpu), priv->nr_opp, > > + &em_cb, priv->opp_shared_cpus, > > + power_scale_mw); > > I would free the priv->opp_shared_cpus mask here, since we don't > need it anymore and memory can be reclaimed. Yes, we don't need it anymore, but this isn't a good place to undo what init() has done. Moreover, it is possible that register_em() may not get called at all, if some error has occurred after init() has successfully returned. It is always better to use exit() for such things. It won't hurt a lot to keep this around anyway. > Don't forget this > setup would be called N CPUs times, on this per-CPU policy platform. Yes, but EM will just ignore this call. Though I have made a change here now to check for non-zero nr_opp to avoid the unnecessary call. > If freed here, then also there wouldn't be a need to free it in > scmi_cpufreq_exit() so you can remove it from there. -- viresh