From: Bjorn Helgaas <helgaas@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
bhelgaas@google.com, maz@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linuxarm@huawei.com, robin.murphy@arm.com, will@kernel.org,
lorenzo.pieralisi@arm.com, dwmw@amazon.co.uk,
Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH v2 0/2] msi: extend msi_irqs sysfs entries to platform devices
Date: Thu, 12 Aug 2021 14:59:25 -0500 [thread overview]
Message-ID: <20210812195925.GA2503574@bjorn-Precision-5520> (raw)
In-Reply-To: <20210812105341.51657-1-21cnbao@gmail.com>
On Thu, Aug 12, 2021 at 10:53:39PM +1200, Barry Song wrote:
> From: Barry Song <song.bao.hua@hisilicon.com>
>
> Just like pci devices have msi_irqs which can be used by userspace irq affinity
> tools or applications to bind irqs, platform devices also widely support msi
> irqs.
> For platform devices, for example ARM SMMU, userspaces also care about its msi
> irqs as applications can know the mapping between devices and irqs and then
> make smarter decision on handling irq affinity. For example, for SVA mode,
> it is better to pin io page fault to the numa node applications are running
> on. Otherwise, io page fault will get a remote page from the node iopf happens
> rather than from the node applications are running on.
>
> The first patch extracts the sysfs populate/destory code from PCI to
> MSI core. The 2nd patch lets platform-msi export msi_irqs entry so that
> userspace can know the mapping between devices and irqs for platform
> devices.
>
> -v2:
> extract common code for msi_irqs sysfs populate/destory from PCI to MSI core,
> platform_device can directly reuse common code;
>
> -v1:
> https://lore.kernel.org/lkml/20210811105020.12980-1-song.bao.hua@hisilicon.com/
>
> Barry Song (2):
> genirq/msi: extract common sysfs populate entries to msi core from pci
> platform-msi: Add ABI to show msi_irqs of platform devices
>
> Documentation/ABI/testing/sysfs-bus-platform | 14 +++
> drivers/base/platform-msi.c | 10 ++
> drivers/pci/msi.c | 124 ++-----------------------
> include/linux/msi.h | 4 +
> kernel/irq/msi.c | 134 +++++++++++++++++++++++++++
> 5 files changed, 171 insertions(+), 115 deletions(-)
I assume the IRQ guys will take care of this.
For the drivers/pci/ part:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
But I would update the commit logs to consistently capitalize
initialisms. Currently it's a mix of "PCI", "pci", "MSI", "msi",
"numa", "irq", "io", etc.
Also, if you rewrap the 2/2 commit log to fit in 75 columns, you won't
have a line that becomes 83 columns when "git log" indents it. Maybe
also indent quoted things like the "ls" output by 2 spaces and add a
blank line before so the text doesn't run into them.
prev parent reply other threads:[~2021-08-12 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 10:53 [PATCH v2 0/2] msi: extend msi_irqs sysfs entries to platform devices Barry Song
2021-08-12 10:53 ` [PATCH v2 1/2] genirq/msi: extract common sysfs populate entries to msi core from pci Barry Song
2021-08-12 10:53 ` [PATCH v2 2/2] platform-msi: Add ABI to show msi_irqs of platform devices Barry Song
2021-08-12 11:02 ` [PATCH v2 0/2] msi: extend msi_irqs sysfs entries to " Greg KH
2021-08-12 19:59 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812195925.GA2503574@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=21cnbao@gmail.com \
--cc=bhelgaas@google.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=song.bao.hua@hisilicon.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).