From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A12EC4338F for ; Fri, 13 Aug 2021 03:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 330D060FC4 for ; Fri, 13 Aug 2021 03:58:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238658AbhHMD6Y (ORCPT ); Thu, 12 Aug 2021 23:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233750AbhHMD6W (ORCPT ); Thu, 12 Aug 2021 23:58:22 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1AD4C061756 for ; Thu, 12 Aug 2021 20:57:56 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id nt11so13458371pjb.2 for ; Thu, 12 Aug 2021 20:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MvmuwhxcqYAbdPmkTIufV5uQRwUnrxELEdSjPA9KrXo=; b=eOwiRNh4MUanAxbqTJMBRZCZfu41L9y7gdH60FKetDLsqWzSItkABZc2JszeZ82opI bfkEzhtcD2es9gu2FAoDAUD+8r0bgLFFKMlRuYwEIbemol70oWZxCO31WcLOv5eMCRNa CJz0KsyMOp6WuJk25J8DqIzQcqdedVyC1mhgHbhFE87rdyadBI69e49/dXtQgjr5nbwK VwFZ8KAWt5PmbX1zUdzO5/uHS77AD+9oVD4cjLD1dgCyEgN0HdYt+pNQ9evzQR5Xju/D A2Cbwl1uAfUjP6ecqadlbt+ewPMPfQYRiHSWmx1YWwU4/vp+unPk39FFAHC70KWSX+1c sUrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MvmuwhxcqYAbdPmkTIufV5uQRwUnrxELEdSjPA9KrXo=; b=JCBK7tkRiambz9fgxv3HbaQzwhLNplTE3Li9SL+rovBwE7BRjj8tg0Xh9MDJT9l5M/ 5sylYOW5u7Nf+YQV0Vvj+6XnlfYK6IkCn8R0DDrQ7zhgMQNXC4tPS6lod92Gt7rX+BfV zOClUFf+/7zeY5B9q4L5XWmABW8xrYLlT/i6ln6L8hcA8KQ6zXV+4j2hCVAw3mePpa60 FyyzZxhV/LAjNkiSkW+XL2l8yBazIi0DwWAxzQfIs0SIQbMeRRS+wxpuQRXTcALTKugC CLiCPoQ+Sb9qcktgN6SZZamB72ue8jGWi53SWugLFMtRp4jDiAz9XG4a7pdX1wFJAxuM ITWA== X-Gm-Message-State: AOAM5319H+EWK72hy/yYX2XGuwH/r9oGSaGQOSyrbl8qNb5gTLtSuUWx mzrf4GSUmVTZlYb+FBy57ow7IQ== X-Google-Smtp-Source: ABdhPJxRDakJcVqHqBRWt5r47fIPr4C/oo8C0jNq80oWE8P2YNHnQVm97OlAzna+HWJyBkUGtgz+2g== X-Received: by 2002:a65:44c3:: with SMTP id g3mr421133pgs.233.1628827076146; Thu, 12 Aug 2021 20:57:56 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id x1sm299780pfn.64.2021.08.12.20.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 20:57:55 -0700 (PDT) Date: Fri, 13 Aug 2021 09:27:53 +0530 From: Viresh Kumar To: Rajendra Nayak Cc: ulf.hansson@linaro.org, bjorn.andersson@linaro.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, swboyd@chromium.org, rojay@codeaurora.org, stephan@gerhold.net, digetx@gmail.com Subject: Re: [PATCH v7 1/3] opp: Don't print an error if required-opps is missing Message-ID: <20210813035753.7b6ye4yzztmp2ly7@vireshk-i7> References: <1628767642-4008-1-git-send-email-rnayak@codeaurora.org> <1628767642-4008-2-git-send-email-rnayak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1628767642-4008-2-git-send-email-rnayak@codeaurora.org> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-08-21, 16:57, Rajendra Nayak wrote: > The 'required-opps' property is considered optional, hence remove > the pr_err() in of_parse_required_opp() when we find the property is > missing. > While at it, also fix the return value of > of_get_required_opp_performance_state() when of_parse_required_opp() > fails, return a -ENODEV instead of the -EINVAL. > > Signed-off-by: Rajendra Nayak > --- > drivers/opp/of.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) Acked-by: Viresh Kumar -- viresh