linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove()
@ 2021-08-13 14:34 Douglas Anderson
  2021-08-13 15:45 ` Stephen Boyd
  2021-08-13 17:26 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2021-08-13 14:34 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Douglas Anderson, Jaroslav Kysela,
	Liam Girdwood, Oder Chiou, Stephen Boyd, Takashi Iwai,
	alsa-devel, linux-kernel

In commit 772d44526e20 ("ASoC: rt5682: Properly turn off regulators if
wrong device ID") I deleted code but forgot to delete a variable
that's now unused. Delete it.

Fixes: 772d44526e20 ("ASoC: rt5682: Properly turn off regulators if wrong device ID")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 sound/soc/codecs/rt5682-i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c
index e559b965a0a6..b9d5d7a0975b 100644
--- a/sound/soc/codecs/rt5682-i2c.c
+++ b/sound/soc/codecs/rt5682-i2c.c
@@ -294,8 +294,6 @@ static void rt5682_i2c_shutdown(struct i2c_client *client)
 
 static int rt5682_i2c_remove(struct i2c_client *client)
 {
-	struct rt5682_priv *rt5682 = i2c_get_clientdata(client);
-
 	rt5682_i2c_shutdown(client);
 
 	return 0;
-- 
2.33.0.rc1.237.g0d66db33f3-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove()
  2021-08-13 14:34 [PATCH] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove() Douglas Anderson
@ 2021-08-13 15:45 ` Stephen Boyd
  2021-08-13 17:26 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-08-13 15:45 UTC (permalink / raw)
  To: Douglas Anderson, Mark Brown
  Cc: Stephen Rothwell, Jaroslav Kysela, Liam Girdwood, Oder Chiou,
	Takashi Iwai, alsa-devel, linux-kernel

Quoting Douglas Anderson (2021-08-13 07:34:05)
> In commit 772d44526e20 ("ASoC: rt5682: Properly turn off regulators if
> wrong device ID") I deleted code but forgot to delete a variable
> that's now unused. Delete it.
>
> Fixes: 772d44526e20 ("ASoC: rt5682: Properly turn off regulators if wrong device ID")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove()
  2021-08-13 14:34 [PATCH] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove() Douglas Anderson
  2021-08-13 15:45 ` Stephen Boyd
@ 2021-08-13 17:26 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-08-13 17:26 UTC (permalink / raw)
  To: Douglas Anderson
  Cc: Mark Brown, linux-kernel, Takashi Iwai, Oder Chiou, alsa-devel,
	Liam Girdwood, Jaroslav Kysela, Stephen Boyd, Stephen Rothwell

On Fri, 13 Aug 2021 07:34:05 -0700, Douglas Anderson wrote:
> In commit 772d44526e20 ("ASoC: rt5682: Properly turn off regulators if
> wrong device ID") I deleted code but forgot to delete a variable
> that's now unused. Delete it.
> 
> 
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove()
      commit: a1ea05723c27a6f77894a60038a7b2b12fcec9a7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-13 17:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 14:34 [PATCH] ASoC: rt5682: Remove unused variable in rt5682_i2c_remove() Douglas Anderson
2021-08-13 15:45 ` Stephen Boyd
2021-08-13 17:26 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).